Skip to contentSkip to conversation

ASoC: codecs: pcm512x: only print info once on no sclk

PATCH In review Christian Hewitt 2 participants 2 messages Jun 25 – Jun 30

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: codecs: pcm512x: only print info once on no sclk

If sclk is not provided the driver falls back to using bclk and prints an info message in the system log. Under normal operations the message is repeated many times:

[   17.929576] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.949172] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.953029] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.965059] pcm512x 0-004c: No SCLK, using BCLK: -2
[   82.592980] pcm512x 0-004c: No SCLK, using BCLK: -2
[   82.866293] pcm512x 0-004c: No SCLK, using BCLK: -2

Switch from dev_info to dev_info_once to reduce log noise.

---
Changes since v1:
- Remove WIP tag from subject (oops)

This was observed on an Odroid Hifi-Sheild2 board used with Kodi which appears to reset the audio connection frequently resulting in 100+ repeats of the message over time.

 sound/soc/codecs/pcm512x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/pcm512x.c +1 -1
index fdef98ce52f1..fe3b5011fa16 100644
@@ -633,7 +633,7 @@ static int pcm512x_dai_startup_slave(struct snd_pcm_substream *substream,
 	struct regmap *regmap = pcm512x->regmap;
 
 	if (IS_ERR(pcm512x->sclk)) {
-		dev_info(dev, "No SCLK, using BCLK: %ld\n",
+		dev_info_once(dev, "No SCLK, using BCLK: %ld\n",
 			 PTR_ERR(pcm512x->sclk));
 
 		/* Disable reporting of missing SCLK as an error */
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 1 line · Christian Hewitt

ASoC: codecs: pcm512x: only print info once on no sclk

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2

Thanks!

[1/1] ASoC: codecs: pcm512x: only print info once on no sclk

      https://git.kernel.org/broonie/sound/c/c5315c8dcbcb

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark