Skip to contentSkip to conversation

ARM: dts: armada-395-gp: drop unsupported SDHCI clock-frequency

PATCH In review Rosen Penev 2 participants 2 messages Aug 24 – Aug 28

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: armada-395-gp: drop unsupported SDHCI clock-frequency

The SDHCI node carries a "clock-frequency" property, but the marvell,armada-380-sdhci binding does not define it and dtbs_check rejects the node as a result. No driver consumes it either: only a few other sdhci-pltfm based drivers (imx, mcf, iproc, arasan, dwcmshc, xenon) read that property, while sdhci-pxav3 derives the maximum clock from the io clock rate.

Remove the property.

Fixes 356645123581 ("ARM: dts: mvebu: armada-395-gp: add support for the Armada 395 GP Board")
Assisted-by opencode:big-pickle
---
 arch/arm/boot/dts/marvell/armada-395-gp.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/marvell/armada-395-gp.dts +0 -1
index b854b73a64b4..fafa204387fd 100644
@@ -59,7 +59,6 @@ sata@a8000 {
 
 			/* CON18 */
 			mmc@d8000 {
-				clock-frequency = <200000000>;
 				broken-cd;
 				wp-inverted;
 				bus-width = <8>;
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 7 lines · Rosen Penev

The SDHCI node carries a "clock-frequency" property, but the marvell,armada-380-sdhci binding does not define it and dtbs_check rejects the node as a result. No driver consumes it either: only a few other sdhci-pltfm based drivers (imx, mcf, iproc, arasan, dwcmshc, xenon) read that property, while sdhci-pxav3 derives the maximum clock from the io clock rate.

Quoted 5 lines

Remove the property.

Fixes 356645123581 ("ARM: dts: mvebu: armada-395-gp: add support for the Armada 395 GP Board")
Assisted-by opencode:big-pickle

Applied on mvebu/dt

Thanks,

Gregory

Quoted 19 lines
---
 arch/arm/boot/dts/marvell/armada-395-gp.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/marvell/armada-395-gp.dts +0 -1
index b854b73a64b4..fafa204387fd 100644
@@ -59,7 +59,6 @@ sata@a8000 {
 
 			/* CON18 */
 			mmc@d8000 {
-				clock-frequency = <200000000>;
 				broken-cd;
 				wp-inverted;
 				bus-width = <8>;
Signature · 1 line
2.55.0
Signature · 3 lines
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com