Skip to contentSkip to conversation

dt-bindings: pinctrl: brcm,nsp-gpio: Convert to DT schema

PATCH In review Rosen Penev 3 participants 3 messages Oct 4 – Oct 8

Subsystems (3)
Device tree bindings GPIO Pin control
lore
Share & tools
lore

Rosen Penev

author
#0 lore raw

PATCH v4 1/1 dt-bindings: pinctrl: brcm,nsp-gpio: Convert to DT schema

The brcm,nsp-gpio-a compatible used by the NSP GPIO controller was only documented in the legacy text binding, so dtbs_check reported "failed to match any schema" for the gpio@20 node in bcm-nsp.dtsi.

Convert the text binding to DT schema. Beyond a direct conversion:

- Require pin configuration nodes to use a '-pins' suffix and GPIO hogs a '-hog' suffix, as the old example used arbitrary node names. No in-tree DTS has child nodes under this controller, so nothing is affected.
- Document slew-rate, which the driver supports but the text binding never listed.
- Add #interrupt-cells and gpio-line-names, and make #interrupt-cells depend on interrupt-controller.

Assisted-by LLM
Signed-off-by Rosen Penev <[email protected]>

---
v4: rewrite to add extra stuff not present in original.
v3: add additionalProperties
v2: don't drop gpio-hog

 .../bindings/pinctrl/brcm,nsp-gpio.txt        |  80 -----------
 .../bindings/pinctrl/brcm,nsp-gpio.yaml       | 130 ++++++++++++++++++
 2 files changed, 130 insertions(+), 80 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml
Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.txt deleted +0 -80
deleted file mode 100644
index 0844168a6dd4..000000000000
@@ -1,80 +0,0 @@
-Broadcom Northstar plus (NSP) GPIO/PINCONF Controller
-
-Required properties:
-- compatible:
-    Must be "brcm,nsp-gpio-a"
-
-- reg:
-    Should contain the register physical address and length for each of
-    GPIO base, IO control registers
-
-- #gpio-cells:
-    Must be two. The first cell is the GPIO pin number (within the
-    controller's pin space) and the second cell is used for the following:
-    bit[0]: polarity (0 for active high and 1 for active low)
-
-- gpio-controller:
-    Specifies that the node is a GPIO controller
-
-- ngpios:
-    Number of gpios supported (58x25 supports 32 and 58x23 supports 24)
-
-Optional properties:
-- interrupts:
-    Interrupt ID
-
-- interrupt-controller:
-    Specifies that the node is an interrupt controller
-
-- gpio-ranges:
-    Specifies the mapping between gpio controller and pin-controllers pins.
-    This requires 4 fields in cells defined as -
-    1. Phandle of pin-controller.
-    2. GPIO base pin offset.
-    3  Pin-control base pin offset.
-    4. number of gpio pins which are linearly mapped from pin base.
-
-Supported generic PINCONF properties in child nodes:
-- pins:
-    The list of pins (within the controller's own pin space) that properties
-    in the node apply to. Pin names are "gpio-<pin>"
-
-- bias-disable:
-    Disable pin bias
-
-- bias-pull-up:
-    Enable internal pull up resistor
-
-- bias-pull-down:
-    Enable internal pull down resistor
-
-- drive-strength:
-    Valid drive strength values include 2, 4, 6, 8, 10, 12, 14, 16 (mA)
-
-Example:
-
-	gpioa: gpio@18000020 {
-		compatible = "brcm,nsp-gpio-a";
-		reg = <0x18000020 0x100>,
-		      <0x1803f1c4 0x1c>;
-		#gpio-cells = <2>;
-		gpio-controller;
-		ngpios = <32>;
-		gpio-ranges = <&pinctrl 0 0 31>;
-		interrupt-controller;
-		interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
-
-		/* Hog a few default settings */
-		pinctrl-names = "default";
-		pinctrl-0 = <&led>;
-		led: led {
-			pins = "gpio-1";
-			bias-pull-up;
-		};
-
-		pwr: pwr {
-			gpio-hog;
-			gpios = <3 1>;
-			output-high;
-		};
-	};
Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml new file +130 -0

130 lines not on this page · raw message

Signature · 1 line
2.56.0
maintainer Reviewed-by on v4 1/1
#1 lore raw
Quoted 21 lines · Rosen Penev

The brcm,nsp-gpio-a compatible used by the NSP GPIO controller was only documented in the legacy text binding, so dtbs_check reported "failed to match any schema" for the gpio@20 node in bcm-nsp.dtsi.

Convert the text binding to DT schema. Beyond a direct conversion:

- Require pin configuration nodes to use a '-pins' suffix and GPIO hogs a '-hog' suffix, as the old example used arbitrary node names. No in-tree DTS has child nodes under this controller, so nothing is affected.
- Document slew-rate, which the driver supports but the text binding never listed.
- Add #interrupt-cells and gpio-line-names, and make #interrupt-cells depend on interrupt-controller.

Assisted-by LLM
Signed-off-by Rosen Penev <[email protected]>

---
v4: rewrite to add extra stuff not present in original.
v3: add additionalProperties
v2: don't drop gpio-hog

Quoted 6 lines
 .../bindings/pinctrl/brcm,nsp-gpio.txt        |  80 -----------
 .../bindings/pinctrl/brcm,nsp-gpio.yaml       | 130 ++++++++++++++++++
 2 files changed, 130 insertions(+), 80 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml
Reviewed-by Rob Herring (Arm) <[email protected]>
maintainer
#2 lore raw
In reply to Rosen Penev
Quoted 15 lines · Rosen Penev

The brcm,nsp-gpio-a compatible used by the NSP GPIO controller was only documented in the legacy text binding, so dtbs_check reported "failed to match any schema" for the gpio@20 node in bcm-nsp.dtsi.

Convert the text binding to DT schema. Beyond a direct conversion:

- Require pin configuration nodes to use a '-pins' suffix and GPIO hogs a '-hog' suffix, as the old example used arbitrary node names. No in-tree DTS has child nodes under this controller, so nothing is affected.
- Document slew-rate, which the driver supports but the text binding never listed.
- Add #interrupt-cells and gpio-line-names, and make #interrupt-cells depend on interrupt-controller.

Quoted 2 lines
Assisted-by LLM
Signed-off-by Rosen Penev <[email protected]>

Patch applied, thanks Rosen, excellent work.

Yours,
Linus Walleij