Skip to contentSkip to conversation

dma: add dmaengine driver for Samsung s3c24xx SoCs

RFC Jingoo Han 1 participant 1 message May 16, 2013 Arm Samsung Exynos

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw
Quoted 29 lines · Tomasz Figa

Hi Linus, Heiko,

Quoted 25 lines · On Tuesday 14 of May 2013 14:47:19 Linus Walleij wrote:
Quoted 11 lines · Heiko St?bner

Conceptually the s3c24xx-dma feels like a distant relative of the pl08x with numerous virtual channels being mapped to a lot less physical ones. The driver therefore borrows a lot from the amba-pl08x driver in this regard. Functionality-wise the driver gains a memcpy ability in addition to the slave_sg one.

The driver currently only supports the "newer" SoCs which can use any physical channel for any dma slave. Support for the older SoCs where each channel only supports a subset of possible dma slaves will have to be added later.

Quoted 4 lines

Tested on a s3c2416-based board, memcpy using the dmatest module and slave_sg partially using the spi-s3c64xx driver.

So have I understood correctly if I assume that *some* S3C variants, i.e. this: arch/arm/mach-s3c64xx/dma.c have a vanilla, unmodified, or just slightly modified PL08x block, while this DMAC is something probably based on the PL08x where some ASIC engineer has had a good time hacking around in the VHDL code to meet some feature requirements. Correct? Or plausible guess?

Quoted 4 lines
Quoted 1 line

Exactly *how* far away from the pl08x hardware is it?

AFAIK the DMAC of S3C24xx is completely different from PL08x. I think Heiko just meant that it uses similar concepts, like virtual channels.

Yes, right.
the DMAC of S3C24xx is completely different from PL08x.
As Heiko mentioned, the DMAC of S3C24xx is 'home grown' as other IPs of S3C24xx.

Best regards,
Jingoo Han