Skip to contentSkip to conversation

extcon: Set platform drvdata in gpio_extcon_probe() and fix irq leak

PATCH MyungJoo Ham 2 participants 2 messages Jun 20, 2012

lore
Share & tools
lore
#0 lore raw
Quoted 19 lines · 함명주
Quoted 7 lines
Quoted 6 lines

Add missing platform_set_drvdata() in gpio_extcon_probe(), otherwise calling platform_get_drvdata in gpio_extcon_remove() returns NULL.

Also add missing free_irq call in gpio_extcon_remove().

Quoted 7 lines

Thanks!

I'll apply this patch to the extcon-for-next.
I would appear in http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next soon after syncing servers.

Does this mean you are going to have a separate extcon git tree somewhere, feeding into linux-next, and sending stuff directly to Linus?

Quoted 7 lines

I don't see an entry in the MAINTAINERS file saying this, which is why I was picking up extcon patches, should I not be doing this?

confused,

greg k-h

You are right. We do not have MAINTAINERS entry for extcon.

I can wait until we have MAINTAINERS entry registered for extcon, which we have not request or submit, yet. Until then, I think you may pick up the extcon patches and I will simply follow your repositories (keep rebasing from yours)

Sorry for the confusion.

MyungJoo

�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#1 lore raw
Quoted 22 lines · MyungJoo Ham
Quoted 22 lines · 함명주
Quoted 7 lines
Quoted 6 lines

Add missing platform_set_drvdata() in gpio_extcon_probe(), otherwise calling platform_get_drvdata in gpio_extcon_remove() returns NULL.

Also add missing free_irq call in gpio_extcon_remove().

Quoted 7 lines

Thanks!

I'll apply this patch to the extcon-for-next.
I would appear in http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next soon after syncing servers.

Does this mean you are going to have a separate extcon git tree somewhere, feeding into linux-next, and sending stuff directly to Linus?

I don't see an entry in the MAINTAINERS file saying this, which is why I was picking up extcon patches, should I not be doing this?

Quoted 6 lines
Quoted 4 lines

confused,

greg k-h

You are right. We do not have MAINTAINERS entry for extcon.

You can easily fix that (hint, hint, hint...)

Quoted 4 lines

I can wait until we have MAINTAINERS entry registered for extcon, which we have not request or submit, yet. Until then, I think you may pick up the extcon patches and I will simply follow your repositories (keep rebasing from yours)

My trees never need rebasing, why would you need to do that? What is going into your tree that isn't in mine? Am I missing patches?

I would be very glad for you to take over this maintainership, if it's something you want to do, otherwise I have no problem taking the patches. It's up to you.

thanks,

greg k-h