Skip to contentSkip to conversation

w1 - call request_module with w1 master mutex unlocked

PATCH In review Hans-Frieder Vogt 1 participant 1 message Oct 6, 2013 W1 dallas's 1-wire bus

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 w1 - call request_module with w1 master mutex unlocked

request_module for w1 slave modules needs to be called with the w1 master mutex
unlocked. Because w1_attach_slave_device gets always(?) called with mutex locked, we need to temporarily unlock the w1 master mutex for the loading of the
w1 slave module.

Signed-off by: Hans-Frieder Vogt <[email protected]>

---
 drivers/w1/w1.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/w1/w1.c +3 -0
@@ -716,7 +716,10 @@ static int w1_attach_slave_device(struct
 	atomic_set(&sl->refcnt, 0);
 	init_completion(&sl->released);
 
+	/* slave modules need to be loaded in a context with unlocked mutex */
+	mutex_unlock(&dev->mutex);
 	request_module("w1-family-0x%0x", rn->family);
+	mutex_lock(&dev->mutex);
 
 	spin_lock(&w1_flock);
 	f = w1_family_registered(rn->family);

Hans-Frieder Vogt e-mail: hfvogt <at> gmx .dot. net