Skip to contentSkip to conversation

VFS: make file->f_pos access atomic on 32bit arch

PATCH Michael Trimarchi 1 participant 1 message Sep 16, 2008 VFS

lore
Share & tools
lore
#0 lore raw

hi,

----- Messaggio originale -----

Quoted 12 lines

Da: Bodo Eggert <[email protected]>
A: Hisashi Hifumi <[email protected]>; [email protected]; [email protected]; [email protected]
Inviato: Martedì 16 settembre 2008, 17:32:08
Oggetto: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

Quoted 5 lines · Hisashi Hifumi

Protecting file->f_pos with a lock adds some overhead but I think we should fix this.
I used seqlock to serialize the access to file->f_pos. This approach is similar to inode->i_size synchronization.

Quoted 7 lines

Review

Quoted 4 lines

Comments?

(quoted diff) +2 -0
+             if (offset != file_pos_read(file))
+                     file_pos_write(file, offset);

Maybe file_pos_write should do this check?

I agree :)

Regards Michael

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

__________________________________________________
Do You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi
http://mail.yahoo.it
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html