Skip to contentSkip to conversation

kconfig: cleanups, documentation updates, and one bug fix

PATCH In review Martin Walch 2 participants 2 messages Oct 3, 2013 – Oct 8, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

v2 cover kconfig: cleanups, documentation updates, and one bug fix

In this second attempt, I tried to incorporate all replies I received for the first version of this patch set:

PATCH 1: kconfig: add short explanation to SYMBOL_WRITE
Ignore this one as long as there is no clear conclusion about the purpose of SYMBOL_WRITE. I only include it, so the patch numbers do not change and there is no "hole" in the patch set.

PATCH 2: kconfig: fix trivial typos and update mconf documentation
In the first place, this corrected only three typos. Now this patch corrects all bad occurrences of "tell" instead of "tells" and fixes several more spelling mistakes. Furthermore some changes that have been made to mconf during the last years are now also updated in the documentation.

PATCH 3: kconfig: adjust warning message for conflicting types
Now explicitely state that the second type is being ignored.

PATCH 4: kconfig: remove unused definition from scanner
No changes since the first version.

PATCH 5: kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
As I do not think it is worth to make this a separate patch, I appended this fix for a bug that is only triggered by the search function of mconf.

Martin Walch (5):
kconfig: add short explanation to SYMBOL_WRITE
kconfig: fix trivial typos and update mconf documentation
kconfig: adjust warning message for conflicting types
kconfig: remove unused definition from scanner
kconfig: fix bug in search results string: use strlen(gstr->s), not

    gstr->len
 scripts/kconfig/expr.h   |  2 +-
 scripts/kconfig/mconf.c  | 60 +++++++++++++++++++++++-------------------------
 scripts/kconfig/menu.c   | 11 +++++----
 scripts/kconfig/symbol.c |  2 +-
 scripts/kconfig/zconf.l  |  1 -
 5 files changed, 37 insertions(+), 39 deletions(-)
Signature · 1 line
1.8.1.5
#1 lore raw

Martin, All,

On 2013-10-03 19:24 +0200, Martin Walch spake thusly:

Quoted 2 lines

In this second attempt, I tried to incorporate all replies I received for the first version of this patch set:

Since there have been positive reviews for thie patches in this series, I'll take it in my tree.

Regards,
Yann E. MORIN.

Quoted 44 lines

PATCH 1: kconfig: add short explanation to SYMBOL_WRITE
Ignore this one as long as there is no clear conclusion about the purpose of SYMBOL_WRITE. I only include it, so the patch numbers do not change and there is no "hole" in the patch set.

PATCH 2: kconfig: fix trivial typos and update mconf documentation
In the first place, this corrected only three typos. Now this patch corrects all bad occurrences of "tell" instead of "tells" and fixes several more spelling mistakes. Furthermore some changes that have been made to mconf during the last years are now also updated in the documentation.

PATCH 3: kconfig: adjust warning message for conflicting types
Now explicitely state that the second type is being ignored.

PATCH 4: kconfig: remove unused definition from scanner
No changes since the first version.

PATCH 5: kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
As I do not think it is worth to make this a separate patch, I appended this fix for a bug that is only triggered by the search function of mconf.

Martin Walch (5):
kconfig: add short explanation to SYMBOL_WRITE
kconfig: fix trivial typos and update mconf documentation
kconfig: adjust warning message for conflicting types
kconfig: remove unused definition from scanner
kconfig: fix bug in search results string: use strlen(gstr->s), not

    gstr->len
 scripts/kconfig/expr.h   |  2 +-
 scripts/kconfig/mconf.c  | 60 +++++++++++++++++++++++-------------------------
 scripts/kconfig/menu.c   | 11 +++++----
 scripts/kconfig/symbol.c |  2 +-
 scripts/kconfig/zconf.l  |  1 -
 5 files changed, 37 insertions(+), 39 deletions(-)
Signature · 7 lines
1.8.1.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'