Skip to contentSkip to conversation

fs/* - compile warning cleanup

PATCH In review Stephen Biggs 1 participant 1 message Feb 14, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 16/21 fs/* - compile warning cleanup

Description: compile warning cleanup - handle error return warning from clear_user - the driver writer does not want to check the return value

fs/binfmt_elf.c +9 -4
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/fs/binfmt_elf.c linux-2.6.11-rc3-mm2/fs/binfmt_elf.c
@@ -823,11 +823,16 @@ static int load_elf_binary(struct linux_
 					nbyte = elf_brk - elf_bss;
 				/*
 				 * This bss-zeroing can fail if the ELF file
-				 * specifies odd protections.  So we don't check
-				 * the return value
+				 * specifies odd protections, so we don't want to
+				 * check the return value. However, since clear_user() is
+				 * declared with attribute 'warn_unused_result', this
+				 * causes a warning during compilation. Putting (void)
+				 * before the call to clear_user() doesn't silence the warning.
+				 * Thus, we need to "trick" the compiler into shutting up.
 				 */
-				(void)clear_user((void __user *)elf_bss +
-							load_bias, nbyte);
+				if (clear_user((void __user *)elf_bss +
+							load_bias, nbyte)) {
+				}
 			}
 		}
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors