Skip to contentSkip to conversation

kernel/* - compile warning cleanup

PATCH In review Stephen Biggs 1 participant 1 message Feb 14, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 18/21 kernel/* - compile warning cleanup

Description: compile warning cleanup - handle copy_to/from_user error returns

kernel/module.c +4 -1
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/kernel/module.c linux-2.6.11-rc3-mm2/kernel/module.c
@@ -1402,7 +1402,10 @@ static void who_is_doing_it(void)
 	char args[512];
 	unsigned int i, len = current->mm->arg_end - current->mm->arg_start;
 
-	copy_from_user(args, (void *)current->mm->arg_start, len);
+	if(copy_from_user(args, (void *)current->mm->arg_start, len)) {
+		printk(KERN_ERR "kernel/module.c:%s: copy_from_user failed!\n",__FUNCTION__);
+		return;
+	}
 
 	for (i = 0; i < len; i++) {
 		if (args[i] == '\0')

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors