Skip to contentSkip to conversation

buffer overflows in the tty flip buffer in 2.6.17

DISCUSSION Mockern 4 participants 6 messages Feb 17, 2007 – Feb 19, 2007

lore
Share & tools
lore

Mockern

author
#0 lore raw

When data is received from the hardware, it needs to be placed into the tty device's flip buffer. This can be done with the following bit of code:

for (i = 0; i < data_size; ++i) {
        if (tty->flip.count >= TTY_FLIPBUF_SIZE)
                tty_flip_buffer_push(tty);
        tty_insert_flip_char(tty, data[i], 0);
}

tty_flip_buffer_push(tty);

This example makes sure there are no buffer overflows in the tty flip buffer as the data is being added.

But how it is done in 2.6.17 linux kernel? I did check this "overflow code" in new tty driver's code. This code looks like just removed. But somehow overflow in the tty buffer must be kept.

#1 lore raw

Mockern napsal(a):

Quoted 9 lines

When data is received from the hardware, it needs to be placed into the tty device's flip buffer. This can be done with the following bit of code:

for (i = 0; i < data_size; ++i) {
        if (tty->flip.count >= TTY_FLIPBUF_SIZE)
                tty_flip_buffer_push(tty);
        tty_insert_flip_char(tty, data[i], 0);
}

tty_flip_buffer_push(tty);

size = tty_buffer_request_room(tty, data_size);
tty_insert_flip_string(tty, data, min(data_size, size));
tty_flip_buffer_push(tty);
+ cope with size < data_size (some data_size -= size with 3 lines above in do {} while (data_size))

regards,

Signature · 6 lines
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E

Hnus <[email protected]> is an alias for /dev/null
#2 lore raw
In reply to Mockern
Quoted 7 lines · Mockern

When data is received from the hardware, it needs to be placed into the tty device's flip buffer. This can be done with the following bit of code:

for (i = 0; i < data_size; ++i) {
        if (tty->flip.count >= TTY_FLIPBUF_SIZE)
                tty_flip_buffer_push(tty);
        tty_insert_flip_char(tty, data[i], 0);
}
Quoted 5 lines

tty_flip_buffer_push(tty);

This example makes sure there are no buffer overflows in the tty flip buffer as the data is being added.

But how it is done in 2.6.17 linux kernel? I did check this "overflow code" in new tty driver's code. This code looks like just removed. But somehow overflow in the tty buffer must be kept.

Well there was a problem in 2.6.16, which was fixed by 2.6.18, although I am not sure if it was done by 2.6.17. It would loose characters due to buffer overflow and not properly checking under high load. I grabbed a few patches from the git tree that were added after 2.6.16 to fix the tty problems I was having.

--
Len Sorensen

author
#3 lore raw

Thanx for your respond.

Could you please inform me what patches exactly you have grabbed?

Quoted 27 lines · Mockern
Quoted 7 lines

When data is received from the hardware, it needs to be placed into the tty device's flip buffer. This can be done with the following bit of code:

for (i = 0; i < data_size; ++i) {
        if (tty->flip.count >= TTY_FLIPBUF_SIZE)
                tty_flip_buffer_push(tty);
        tty_insert_flip_char(tty, data[i], 0);
}
Quoted 5 lines

tty_flip_buffer_push(tty);

This example makes sure there are no buffer overflows in the tty flip buffer as the data is being added.

But how it is done in 2.6.17 linux kernel? I did check this "overflow code" in new tty driver's code. This code looks like just removed. But somehow overflow in the tty buffer must be kept.

Well there was a problem in 2.6.16, which was fixed by 2.6.18, although I am not sure if it was done by 2.6.17. It would loose characters due to buffer overflow and not properly checking under high load. I grabbed a few patches from the git tree that were added after 2.6.16 to fix the tty problems I was having.

--
Len Sorensen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 1 line
Сегодня удачный день, чтобы завести почту на Яндексе http://mail.yandex.ru
#4 lore raw
Quoted 3 lines · Mockern

Thanx for your respond.

Could you please inform me what patches exactly you have grabbed?

If you see the thread "Re: Strange problem with tty layer", which I just posted a final update too, it has the list of linux-2.6 git commits that I applied to 2.6.16 in order (some of them are probably in 2.6.17 already, while others might not be).

--
Len Sorensen

#5 lore raw
In reply to Mockern
Quoted 1 line

But how it is done in 2.6.17 linux kernel? I did check this "overflow code" in new tty driver's code. This code looks like just removed. But somehow overflow in the tty buffer must be kept.

The new tty layer manages memory allocation dynamically and handles overflows itself. Just throw data at it and the right thing will occur in current kernels.