Skip to contentSkip to conversation

clean up usage of FOO_RELEASE_NAME

PATCH New Fabio Massimo Di Nitto 2 participants 2 messages Aug 21, 2007 – Aug 22, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clean up usage of FOO_RELEASE_NAME

Hi guys,

just a minor cleanup patch:

lots of subsystems use SUBSYSTEM_RELEASE_NAME=RELEASE as defined in make/defines.mk.

The patch does:

cleanup all the subsystems to use RELEASE_VERSION from defines.mk cleanup all Makefiles to not define SUBSYSTEM_RELEASE_VERSION. update configure to generate proper entries in defines.mk

as side effect:

fix rgmanager/src/utils/ to be consistent with RELEASE_VERSION (it used to have PACKAGE_VERSION)
fix gfs2/fsck/ that was using GFS_RELEASE_NAME instead of GFS2_RELEASE_NAME.

Note those are all cosmetic changes. Nothing was really fixed here if not to make everything consistent.

Please apply or ACK and I will apply.

Fabio

PS and yes i was really bothered this morning :P

Signature · 5 lines
I'm going to make him an offer he can't refuse.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cleanup-release.diff
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070821/fe4345c9/attachment.ksh>
#1 lore raw

PATCH 1/1 clean up usage of FOO_RELEASE_NAME

Quoted 15 lines · Fabio Massimo Di Nitto

Hi guys,

just a minor cleanup patch:

lots of subsystems use SUBSYSTEM_RELEASE_NAME=RELEASE as defined in make/defines.mk.

The patch does:

cleanup all the subsystems to use RELEASE_VERSION from defines.mk cleanup all Makefiles to not define SUBSYSTEM_RELEASE_VERSION. update configure to generate proper entries in defines.mk

as side effect:

Quoted 8 lines

fix rgmanager/src/utils/ to be consistent with RELEASE_VERSION (it used to have PACKAGE_VERSION)
fix gfs2/fsck/ that was using GFS_RELEASE_NAME instead of GFS2_RELEASE_NAME.

Note those are all cosmetic changes. Nothing was really fixed here if not to make everything consistent.

Please apply or ACK and I will apply.

ACK for the rgmanager parts at least.

-- Lon

Signature · 1 line
Lon Hohberger - Software Engineer - Red Hat, Inc.