Skip to contentSkip to conversation

Avoid an integer divide in rt_garbage_collect()

INET Applied Eric Dumazet 2 participants 2 messages Dec 21, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Since 'goal' is a signed int, compiler may emit an integer divide to compute goal/2.

Using a right shift is OK here and less expensive.

net/ipv4/route.c +2 -2
index e35076e..10915bb 100644
@@ -851,14 +851,14 @@ static int rt_garbage_collect(void)
 			equilibrium = ipv4_dst_ops.gc_thresh;
 		goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium;
 		if (goal > 0) {
-			equilibrium += min_t(unsigned int, goal / 2, rt_hash_mask + 1);
+			equilibrium += min_t(unsigned int, goal >> 1, rt_hash_mask + 1);
 			goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium;
 		}
 	} else {
 		/* We are in dangerous area. Try to reduce cache really
 		 * aggressively.
 		 */
-		goal = max_t(unsigned int, goal / 2, rt_hash_mask + 1);
+		goal = max_t(unsigned int, goal >> 1, rt_hash_mask + 1);
 		equilibrium = atomic_read(&ipv4_dst_ops.entries) - goal;
 	}