Avoid an integer divide in rt_garbage_collect()
Subsystems (3)
Since 'goal' is a signed int, compiler may emit an integer divide to compute goal/2.
Using a right shift is OK here and less expensive.
Signed-off-by Eric Dumazet <[email protected]>
net/ipv4/route.c +2 -2
@@ -851,14 +851,14 @@ static int rt_garbage_collect(void) equilibrium = ipv4_dst_ops.gc_thresh; goal =atomic_read (&ipv4_dst_ops.entries) - equilibrium;if (goal >0 ) { - equilibrium += min_t(unsigned int, goal / 2, rt_hash_mask + 1); + equilibrium += min_t(unsigned int, goal >> 1, rt_hash_mask + 1); goal =atomic_read (&ipv4_dst_ops.entries) - equilibrium; } }else {/* We are in dangerous area. Try to reduce cache really * aggressively. */ - goal = max_t(unsigned int, goal / 2, rt_hash_mask + 1); + goal = max_t(unsigned int, goal >> 1, rt_hash_mask + 1); equilibrium =atomic_read (&ipv4_dst_ops.entries) - goal; }
From: Eric Dumazet <[email protected]>
Date: Fri, 21 Dec 2007 09:20:50 +0100
Quoted 6 lines
Since 'goal' is a signed int, compiler may emit an integer divide to compute goal/2.
Using a right shift is OK here and less expensive.
Signed-off-by Eric Dumazet <[email protected]>
Applied, thanks.