Skip to contentSkip to conversation

hda: STAC927x power management

PATCH Applied Matthew Ranostay 2 participants 2 messages Feb 20, 2008 – Feb 21, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hda: STAC927x power management

Fix issue on STAC927x codecs that first DAC was getting powered down even if was being used.

---

pci/hda/patch_sigmatel.c +2 -1
diff -r 30701aaf404c pci/hda/patch_sigmatel.c
@@ -2893,7 +2893,8 @@ static void stac92xx_power_down(struct h
 	/* power down inactive DACs */
 	hda_nid_t *dac;
 	for (dac = spec->dac_list; *dac; dac++)
-		if (!is_in_dac_nids(spec, *dac))
+		if (!is_in_dac_nids(spec, *dac) &&
+			spec->multiout.hp_nid != *dac)
 			snd_hda_codec_write_cache(codec, *dac, 0,
 					AC_VERB_SET_POWER_STATE, AC_PWRST_D3);
 }
Applied
#1 lore raw

At Wed, 20 Feb 2008 17:00:39 -0500,

Quoted 4 lines · Matthew Ranostay

Fix issue on STAC927x codecs that first DAC was getting powered down even if was being used.

Thanks, applied now to HG tree.
I guess we can use check_in_dac_nids() instead?

Takashi

Quoted 15 lines

---
diff -r 30701aaf404c pci/hda/patch_sigmatel.c

pci/hda/patch_sigmatel.c +2 -1
@@ -2893,7 +2893,8 @@ static void stac92xx_power_down(struct h
 	/* power down inactive DACs */
 	hda_nid_t *dac;
 	for (dac = spec->dac_list; *dac; dac++)
-		if (!is_in_dac_nids(spec, *dac))
+		if (!is_in_dac_nids(spec, *dac) &&
+			spec->multiout.hp_nid != *dac)
 			snd_hda_codec_write_cache(codec, *dac, 0,
 					AC_VERB_SET_POWER_STATE, AC_PWRST_D3);
 }