block large commands support continue

blk_get_request and queue_flush initializes rq->cmd (rq_init does) so the users don't need to do that.

Signed-off-by FUJITA Tomonori <[email protected]>

Signed-off-by Boaz Harrosh <[email protected]>

Cc Geert Uytterhoeven <[email protected]>

Cc James Bottomley <[email protected]>

---
 block/scsi_ioctl.c          |    3 ---
 drivers/block/pktcdvd.c     |    2 --
 drivers/block/ps3disk.c     |    1 -
 drivers/cdrom/cdrom.c       |    1 -
 drivers/md/dm-emc.c         |    2 --
 drivers/md/dm-mpath-hp-sw.c |    1 -
 drivers/md/dm-mpath-rdac.c  |    1 -
 drivers/scsi/sd.c           |    1 -
 8 files changed, 0 insertions(+), 12 deletions(-)

block/scsi_ioctl.c +0 -3

index a2c3a93..ffa3720 100644
@@ -217,8 +217,6 @@ EXPORT_SYMBOL_GPL(blk_verify_command);
 static int blk_fill_sghdr_rq(struct request_queue *q, struct request *rq,
 			     struct sg_io_hdr *hdr, int has_write_perm)
 {
-	memset(rq->cmd, 0, BLK_MAX_CDB); /* ATAPI hates garbage after CDB */
-
 	if (copy_from_user(rq->cmd, hdr->cmdp, hdr->cmd_len))
 		return -EFAULT;
 	if (blk_verify_command(rq->cmd, has_write_perm))

@@ -531,7 +529,6 @@ static int __blk_send_generic(struct request_queue *q, struct gendisk *bd_disk,
 	rq->data_len = 0;
 	rq->extra_len = 0;
 	rq->timeout = BLK_DEFAULT_SG_TIMEOUT;
-	memset(rq->cmd, 0, sizeof(rq->cmd));
 	rq->cmd[0] = cmd;
 	rq->cmd[4] = data;
 	rq->cmd_len = 6;

drivers/block/pktcdvd.c +0 -2

index 18feb1c..3b806c9 100644
@@ -776,8 +776,6 @@ static int pkt_generic_packet(struct pktcdvd_device *pd, struct packet_command *
 
 	rq->cmd_len = COMMAND_SIZE(cgc->cmd[0]);
 	memcpy(rq->cmd, cgc->cmd, CDROM_PACKET_SIZE);
-	if (sizeof(rq->cmd) > CDROM_PACKET_SIZE)
-		memset(rq->cmd + CDROM_PACKET_SIZE, 0, sizeof(rq->cmd) - CDROM_PACKET_SIZE);
 
 	rq->timeout = 60*HZ;
 	rq->cmd_type = REQ_TYPE_BLOCK_PC;

drivers/block/ps3disk.c +0 -1

index 7483f94..9c32b75 100644
@@ -406,7 +406,6 @@ static void ps3disk_prepare_flush(struct request_queue *q, struct request *req)
 
 	dev_dbg(&dev->sbd.core, "%s:%u\n", __func__, __LINE__);
 
-	memset(req->cmd, 0, sizeof(req->cmd));
 	req->cmd_type = REQ_TYPE_FLUSH;
 }
 

drivers/cdrom/cdrom.c +0 -1

index ac38290..69f26eb 100644
@@ -2194,7 +2194,6 @@ static int cdrom_read_cdda_bpc(struct cdrom_device_info *cdi, __u8 __user *ubuf,
 		if (ret)
 			break;
 
-		memset(rq->cmd, 0, sizeof(rq->cmd));
 		rq->cmd[0] = GPCMD_READ_CD;
 		rq->cmd[1] = 1 << 2;
 		rq->cmd[2] = (lba >> 24) & 0xff;

drivers/md/dm-emc.c +0 -2

index 6b91b9a..3ea5ad4 100644
@@ -110,8 +110,6 @@ static struct request *get_failover_req(struct emc_handler *h,
 	memset(rq->sense, 0, SCSI_SENSE_BUFFERSIZE);
 	rq->sense_len = 0;
 
-	memset(&rq->cmd, 0, BLK_MAX_CDB);
-
 	rq->timeout = EMC_FAILOVER_TIMEOUT;
 	rq->cmd_type = REQ_TYPE_BLOCK_PC;
 	rq->cmd_flags |= REQ_FAILFAST | REQ_NOMERGE;

drivers/md/dm-mpath-hp-sw.c +0 -1

index 204bf42..b63a0ab 100644
@@ -137,7 +137,6 @@ static struct request *hp_sw_get_request(struct dm_path *path)
 	req->sense = h->sense;
 	memset(req->sense, 0, SCSI_SENSE_BUFFERSIZE);
 
-	memset(&req->cmd, 0, BLK_MAX_CDB);
 	req->cmd[0] = START_STOP;
 	req->cmd[4] = 1;
 	req->cmd_len = COMMAND_SIZE(req->cmd[0]);

drivers/md/dm-mpath-rdac.c +0 -1

index e04eb5c..95e7773 100644
@@ -284,7 +284,6 @@ static struct request *get_rdac_req(struct rdac_handler *h,
 		return NULL;
 	}
 
- 	memset(&rq->cmd, 0, BLK_MAX_CDB);
 	rq->sense = h->sense;
 	memset(rq->sense, 0, SCSI_SENSE_BUFFERSIZE);
 	rq->sense_len = 0;

drivers/scsi/sd.c +0 -0

index 3cea17d..01cefbb 100644

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

[PATCH 5/5] block: add large command support
Now that all initialization goes through one place Tomos large command support is trivial.

Bart. This is mostly ide changes, so please if you can test it. I do not have any legacy IDE devices here at the office, it is all new sata stuff.

I hope we can put this, and later the scsi stuff, on some tree that can be tested at -mm and hopefully be ready for 2.6.27

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 38 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Quoted 2 lines

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

block/blk-barrier.c +1 -6

index 55c5f1f..722140a 100644
@@ -143,10 +143,8 @@ static void queue_flush(struct request_queue *q, unsigned which)
 		end_io = post_flush_end_io;
 	}
 
-	rq->cmd_flags = REQ_HARDBARRIER;
 	rq_init(q, rq);
-	rq->elevator_private = NULL;
-	rq->elevator_private2 = NULL;
+	rq->cmd_flags = REQ_HARDBARRIER;
 	rq->rq_disk = q->bar_rq.rq_disk;
 	rq->end_io = end_io;
 	q->prepare_flush_fn(q, rq);

@@ -167,14 +165,11 @@ static inline struct request *start_ordered(struct request_queue *q,
 	blkdev_dequeue_request(rq);
 	q->orig_bar_rq = rq;
 	rq = &q->bar_rq;
-	rq->cmd_flags = 0;
 	rq_init(q, rq);
 	if (bio_data_dir(q->orig_bar_rq->bio) == WRITE)
 		rq->cmd_flags |= REQ_RW;
 	if (q->ordered & QUEUE_ORDERED_FUA)
 		rq->cmd_flags |= REQ_FUA;
-	rq->elevator_private = NULL;
-	rq->elevator_private2 = NULL;
 	init_request_from_bio(rq, q->orig_bar_rq->bio);
 	rq->end_io = bar_end_io;
 

block/blk-core.c +4 -26

index 2a438a9..e447799 100644
@@ -107,40 +107,18 @@ struct backing_dev_info *blk_get_backing_dev_info(struct block_device *bdev)
 }
 EXPORT_SYMBOL(blk_get_backing_dev_info);
 
-/*
- * We can't just memset() the structure, since the allocation path
- * already stored some information in the request.
- */
 void rq_init(struct request_queue *q, struct request *rq)
 {
+	memset(rq, 0, sizeof(*rq));
+
 	INIT_LIST_HEAD(&rq->queuelist);
 	INIT_LIST_HEAD(&rq->donelist);
 	rq->q = q;
 	rq->sector = rq->hard_sector = (sector_t) -1;
-	rq->nr_sectors = rq->hard_nr_sectors = 0;
-	rq->current_nr_sectors = rq->hard_cur_sectors = 0;
-	rq->bio = rq->biotail = NULL;
 	INIT_HLIST_NODE(&rq->hash);
 	RB_CLEAR_NODE(&rq->rb_node);
-	rq->rq_disk = NULL;
-	rq->nr_phys_segments = 0;
-	rq->nr_hw_segments = 0;
-	rq->ioprio = 0;
-	rq->special = NULL;
-	rq->buffer = NULL;
 	rq->tag = -1;
-	rq->errors = 0;
 	rq->ref_count = 1;
-	rq->cmd_len = 0;
-	memset(rq->cmd, 0, sizeof(rq->cmd));
-	rq->data_len = 0;
-	rq->extra_len = 0;
-	rq->sense_len = 0;
-	rq->data = NULL;
-	rq->sense = NULL;
-	rq->end_io = NULL;
-	rq->end_io_data = NULL;
-	rq->next_rq = NULL;
 }
 
 static void req_bio_endio(struct request *rq, struct bio *bio,

@@ -607,6 +585,8 @@ blk_alloc_request(struct request_queue *q, int rw, int priv, gfp_t gfp_mask)
 	if (!rq)
 		return NULL;
 
+	rq_init(q, rq);
+
 	/*
 	 * first three bits are identical in rq->cmd_flags and bio->bi_rw,
 	 * see bio.h and blkdev.h

@@ -789,8 +769,6 @@ rq_starved:
 	if (ioc_batching(q, ioc))
 		ioc->nr_batch_requests--;
 
-	rq_init(q, rq);
-
 	blk_add_trace_generic(q, bio, rw, BLK_TA_GETRQ);
 out:
 	return rq;

Quoted 44 lines · FUJITA Tomonori

Quoted 40 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 4 lines

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Quoted 45 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 44 lines · FUJITA Tomonori

Quoted 40 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 6 lines

Quoted 4 lines

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Quoted 61 lines · FUJITA Tomonori

Quoted 45 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 44 lines · FUJITA Tomonori

Quoted 40 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 6 lines

Quoted 4 lines

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

Quoted 2 lines

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Sorry, with the moved rq_init() it should work, didn't look closely enough.

Quoted 65 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 63 lines · FUJITA Tomonori

Quoted 45 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 44 lines · FUJITA Tomonori

Quoted 40 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 6 lines

Quoted 4 lines

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Quoted 2 lines

Sorry, with the moved rq_init() it should work, didn't look closely enough.

No problem.

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Quoted 71 lines · FUJITA Tomonori

Quoted 67 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 55 lines · FUJITA Tomonori

Quoted 45 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 44 lines · FUJITA Tomonori

Quoted 40 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 6 lines

Quoted 4 lines

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Quoted 8 lines

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Sorry, with the moved rq_init() it should work, didn't look closely enough.

Quoted 4 lines

No problem.

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Please do - I actually already merged it, but do resend with a full description and signed-off etc.

Quoted 74 lines · On Fri, 25 Apr 2008 11:31:41 +0200 Jens Axboe <[email protected]> wrote:

Quoted 73 lines · FUJITA Tomonori

Quoted 62 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 61 lines · FUJITA Tomonori

Quoted 45 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 44 lines · FUJITA Tomonori

Quoted 40 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 6 lines

Quoted 4 lines

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

Quoted 5 lines

Quoted 2 lines

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Sorry, with the moved rq_init() it should work, didn't look closely enough.

No problem.

Quoted 5 lines

Quoted 2 lines

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Please do - I actually already merged it, but do resend with a full description and signed-off etc.

I just stole your description and added my signed-off.

Will you merge the large command support for 2.6.26? Or only this clean-up patch?

Quoted 83 lines · FUJITA Tomonori

Quoted 79 lines · On Fri, 25 Apr 2008 11:31:41 +0200 Jens Axboe <[email protected]> wrote:

Quoted 68 lines · FUJITA Tomonori

Quoted 65 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 63 lines · FUJITA Tomonori

Quoted 45 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 44 lines · FUJITA Tomonori

Quoted 40 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 7 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

Quoted 6 lines

Quoted 4 lines

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Quoted 7 lines

Quoted 2 lines

Sorry, with the moved rq_init() it should work, didn't look closely enough.

No problem.

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Please do - I actually already merged it, but do resend with a full description and signed-off etc.

Quoted 1 line

I just stole your description and added my signed-off.

OK, will update it.

Quoted 2 lines

Will you merge the large command support for 2.6.26? Or only this clean-up patch?

It's both, we can merge large command support for 2.6.26.

Quoted 62 lines · On Fri, 25 Apr 2008 11:31:41 +0200 Jens Axboe <[email protected]> wrote:

Quoted 61 lines · FUJITA Tomonori

Quoted 58 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 57 lines · FUJITA Tomonori

Quoted 39 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 38 lines · FUJITA Tomonori

Quoted 35 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 6 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Quoted 7 lines

Quoted 6 lines

Quoted 2 lines

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Quoted 8 lines

Quoted 6 lines

Quoted 2 lines

Sorry, with the moved rq_init() it should work, didn't look closely enough.

No problem.

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Please do - I actually already merged it, but do resend with a full description and signed-off etc.

I just stole your description and added my signed-off.

Will you merge the large command support for 2.6.26? Or only this clean-up patch?

=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] block: make rq_init() do a full memset()

This requires moving rq_init() from get_request() to blk_alloc_request(). The upside is that we can now require an rq_init() from any path that wishes to hand the request to the block layer.

rq_init() will be exported for the code that uses struct request without blk_get_request.

This is a preparation for large command support, which needs to initialize struct request in a proper way (that is, just doing a memset() will not work).

Signed-off-by FUJITA Tomonori <[email protected]>

Signed-off-by Jens Axboe <[email protected]>

---

Quoted 97 lines · FUJITA Tomonori

Quoted 62 lines · On Fri, 25 Apr 2008 11:31:41 +0200 Jens Axboe <[email protected]> wrote:

Quoted 61 lines · FUJITA Tomonori

Quoted 58 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 57 lines · FUJITA Tomonori

Quoted 39 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 38 lines · FUJITA Tomonori

Quoted 35 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 6 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Quoted 7 lines

Quoted 6 lines

Quoted 2 lines

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Quoted 8 lines

Quoted 6 lines

Quoted 2 lines

Sorry, with the moved rq_init() it should work, didn't look closely enough.

No problem.

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Please do - I actually already merged it, but do resend with a full description and signed-off etc.

I just stole your description and added my signed-off.

Will you merge the large command support for 2.6.26? Or only this clean-up patch?

=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] block: make rq_init() do a full memset()

This requires moving rq_init() from get_request() to blk_alloc_request(). The upside is that we can now require an rq_init() from any path that wishes to hand the request to the block layer.

rq_init() will be exported for the code that uses struct request without blk_get_request.

This is a preparation for large command support, which needs to initialize struct request in a proper way (that is, just doing a memset() will not work).

Signed-off-by FUJITA Tomonori <[email protected]>

Signed-off-by Jens Axboe <[email protected]>

---

<snip>

Sorry for the late response. Those hebrew holidays on they way of Linux coding ;-).

I don't mind as long as these things get accepted. But how is that any different then the patch I sent?
[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
It does exactly 100% the same move of rq_init to blk_alloc_request and the memset and all, Have you looked at the patches at all? I feel like a mute person ;-(

If you are going to export the rq_init function then I think the name is very wrong. And you have not exported it?

Quoted 97 lines · FUJITA Tomonori

Quoted 62 lines · On Fri, 25 Apr 2008 11:31:41 +0200 Jens Axboe <[email protected]> wrote:

Quoted 61 lines · FUJITA Tomonori

Quoted 58 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 57 lines · FUJITA Tomonori

Quoted 39 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 38 lines · FUJITA Tomonori

Quoted 35 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 6 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Quoted 7 lines

Quoted 6 lines

Quoted 2 lines

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Quoted 8 lines

Quoted 6 lines

Quoted 2 lines

Sorry, with the moved rq_init() it should work, didn't look closely enough.

No problem.

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Please do - I actually already merged it, but do resend with a full description and signed-off etc.

I just stole your description and added my signed-off.

Will you merge the large command support for 2.6.26? Or only this clean-up patch?

=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] block: make rq_init() do a full memset()

This requires moving rq_init() from get_request() to blk_alloc_request(). The upside is that we can now require an rq_init() from any path that wishes to hand the request to the block layer.

rq_init() will be exported for the code that uses struct request without blk_get_request.

This is a preparation for large command support, which needs to initialize struct request in a proper way (that is, just doing a memset() will not work).

Signed-off-by FUJITA Tomonori <[email protected]>

Signed-off-by Jens Axboe <[email protected]>

---

<snip>

Sorry for the late response. Those hebrew holidays on they way of Linux coding ;-).

I don't mind as long as these things get accepted. But how is that any different then the patch I sent?
[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
It does exactly 100% the same move of rq_init to blk_alloc_request and the memset and all, Have you looked at the patches at all? I feel like a mute person ;-(

If you are going to export the rq_init function then I think the name is very wrong. And you have not exported it?

Quoted 99 lines · On Sun, 27 Apr 2008 11:26:20 +0300 Boaz Harrosh <[email protected]> wrote:

Quoted 96 lines · FUJITA Tomonori

Quoted 62 lines · On Fri, 25 Apr 2008 11:31:41 +0200 Jens Axboe <[email protected]> wrote:

Quoted 61 lines · FUJITA Tomonori

Quoted 58 lines · On Fri, 25 Apr 2008 11:22:04 +0200 Jens Axboe <[email protected]> wrote:

Quoted 57 lines · FUJITA Tomonori

Quoted 39 lines · On Thu, 24 Apr 2008 12:49:30 +0200 Jens Axboe <[email protected]> wrote:

Quoted 38 lines · FUJITA Tomonori

Quoted 35 lines · On Thu, 24 Apr 2008 13:31:21 +0900 FUJITA Tomonori…

Quoted 6 lines · On Wed, 23 Apr 2008 17:50:42 +0300 Boaz Harrosh <[email protected]> wrote:

The support for large commands was dropped from the for-2.6.26 branch and will probably not get accepted into next kernel.

I have tried to take all comments from Jens and Bart. and incorporate it into a new patchset. This is basically Tomo's patchset but with proposed changes.

Have you seen the patchset to remove request on the stack?

http://marc.info/?l=linux-ide&m=120882410712466&w=2

Quoted 12 lines

They are based on current linux-block/master. They will probably conflict with latest patch sent by Tomo for the blk_get_request(). Once those patches get accepted at some git tree, (Where will that be?), I will rebase these on top of them. Please CC me of any progress.

[PATCH 1/5] block: no need to initialize rq->cmd
This is 2 of Tomo's patches squashed together as they are small and do the same. Tomo is this OK?

[PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB
Tomos patch rebased to here

Quoted 7 lines

[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
[PATCH 4/5] block: Use new blk_init_rq
These patches are basically what Jens and Bart has suggested, that with a small code change to blk-core.c we can memset at rq_init() and only set none zero members. We can also export that initializer and use it all over the ide tree where ever requests don't come from a request queue. (OK also at scsi_error.c)

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

Quoted 7 lines

Quoted 6 lines

Quoted 2 lines

Hmm, would it be better to modify the block layer to let rq_init just memset() the request structure?

I think, if we move rq_init to blk_alloc_request from get_request, rq_init can just memset() the structure.

Then we can export rq_init and rq_init works for everyone.

Wont work, see the io scheduler set_request() functions.

Sorry, can you be more specific?

Only cfq uses set_request for now. cfq_set_request uses rq->cmd_flags and stores information at rq->elevator_private and rq->elevator_private2.

The patch does memset() the request structure and sets up rq->cmd_flags, and then elv_set_request. Doesn't it work?

Quoted 8 lines

Quoted 6 lines

Quoted 2 lines

Sorry, with the moved rq_init() it should work, didn't look closely enough.

No problem.

So are you ok with the patch? If so, I'll re-send it with a proper description and the signed-off.

Please do - I actually already merged it, but do resend with a full description and signed-off etc.

I just stole your description and added my signed-off.

Will you merge the large command support for 2.6.26? Or only this clean-up patch?

=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] block: make rq_init() do a full memset()

This requires moving rq_init() from get_request() to blk_alloc_request(). The upside is that we can now require an rq_init() from any path that wishes to hand the request to the block layer.

rq_init() will be exported for the code that uses struct request without blk_get_request.

This is a preparation for large command support, which needs to initialize struct request in a proper way (that is, just doing a memset() will not work).

Signed-off-by FUJITA Tomonori <[email protected]>

Signed-off-by Jens Axboe <[email protected]>

---

<snip>

Quoted 8 lines

Sorry for the late response. Those hebrew holidays on they way of Linux coding ;-).

I don't mind as long as these things get accepted. But how is that any different then the patch I sent?
[PATCH 3/5] block: Export rq_init, rename to blk_init_rq
It does exactly 100% the same move of rq_init to blk_alloc_request and the memset and all, Have you looked at the patches at all? I feel like a mute person ;-(

No, it's not same at all. Please look at the patchset again. Your interface is:

+void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)

I don't like that. It's hacky. You needed that hacky inferface because you didn't fix the root problem, rq_init was not able to do a full memset().

I fixed the root problem with this patch:

http://marc.info/?l=linux-scsi&m=120901807514386&w=2

Then, we have the same interface as before:

+void blk_rq_init(struct request_queue *q, struct request *rq)

Quoted 3 lines

If you are going to export the rq_init function then I think the name is very wrong. And you have not exported it?

It was renamed blk_rq_init since we have lots of blk_rq_* functions.