Skip to contentSkip to conversation

virtio_pci module refcount?

DISCUSSION Michael Tokarev 1 participant 1 message Dec 3, 2008 KVM

lore
Share & tools
lore
#0 lore raw

Hello.

Yesterday I experimented with kvm guests (the "hangs" issue), and by a chance rmmod'ed the "wrong" module - it was virtio_pci. Which resulted in an immediate OOPs and hang, like this:

WARNING: at drivers/base/core.c:122 device_release+0x5f/0x70()
Device 'virtio1' does not have a release() function, it is broken and must be
fixed.
Modules linked in: ext3 jbd mbcache acpiphp dock pci_hotplug virtio_net

virtio_blk virtio_pci(-) virtio_ring virtio

Pid: 361, comm: rmmod Tainted: G S 2.6.27-i686smp #2.6.27.7

 [<c012b81f>] warn_slowpath+0x6f/0xa0
 [<c0110030>] prepare_set+0x30/0x80
 [<c012067e>] __wake_up+0x3e/0x60
 [<c01d1d25>] release_sysfs_dirent+0x45/0xb0
 ...

It looks like virtio_pci module should either use proper refcounting as other modules, or really should be unloadable...

Thanks!

/mjt