Skip to contentSkip to conversation

init FEC @ MPC5200

U-Boot Andre Schwarz 2 participants 3 messages Dec 10, 2008

lore
Share & tools
lore
#0 lore raw

Ben,

after cloning the latest u-boot git I can see that you've added this inside the mvBC-P board setup :

int board_eth_init(bd_t *bis)
{
cpu_eth_init(bis); /* Built in FEC comes first */ return pci_eth_init(bis);
}

Are you aware that there's no PHY connected and the ETH-Pins are used otherwise ?

CONFIG_MPC5xxx_FEC is _not_ defined.

Can you tell me where "cpu_eth_init(bis)" is actually pointing to ?

regards,
Andr?

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

#1 lore raw
Quoted 11 lines · Andre Schwarz

Ben,

after cloning the latest u-boot git I can see that you've added this inside the mvBC-P board setup :

int board_eth_init(bd_t *bis)
{
cpu_eth_init(bis); /* Built in FEC comes first */ return pci_eth_init(bis);
}

Quoted 10 lines

Are you aware that there's no PHY connected and the ETH-Pins are used otherwise ?

CONFIG_MPC5xxx_FEC is _not_ defined.

Can you tell me where "cpu_eth_init(bis)" is actually pointing to ?

Since CONFIG_MPC5xxx_FEC isn't defined, the default weak cpu_eth_init() function in net/eth.c should get called, which does essentially nothing. I assumed that since you #undef'd the FEC controller in your board header file (instead of leaving it out completely), that it was perhaps optional, and so kept the call to cpu_eth_init() as shown above.

Are you seeing a problem with this?

Quoted 6 lines

regards,
Andr?

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

regards,
Ben

#2 lore raw
Quoted 22 lines · Ben Warren
Quoted 11 lines · Andre Schwarz

Ben,

after cloning the latest u-boot git I can see that you've added this inside the mvBC-P board setup :

int board_eth_init(bd_t *bis)
{
cpu_eth_init(bis); /* Built in FEC comes first */ return pci_eth_init(bis);
}

Quoted 10 lines

Are you aware that there's no PHY connected and the ETH-Pins are used otherwise ?

CONFIG_MPC5xxx_FEC is _not_ defined.

Can you tell me where "cpu_eth_init(bis)" is actually pointing to ?

Quoted 6 lines

Since CONFIG_MPC5xxx_FEC isn't defined, the default weak cpu_eth_init() function in net/eth.c should get called, which does essentially nothing. I assumed that since you #undef'd the FEC controller in your board header file (instead of leaving it out completely), that it was perhaps optional, and so kept the call to cpu_eth_init() as shown above.

ok - missed that.

Quoted 2 lines

Are you seeing a problem with this?

no - just wanted to know.

Thanks for the hint,
Andr?

Quoted 9 lines
Quoted 7 lines

regards,
Andr?

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler -
Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

regards,
Ben

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner