Skip to contentSkip to conversation

82xx, mgcoge: corrected wrong flash sizes

PATCH New Heiko Schocher 2 participants 3 messages Jan 28, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 12/31 82xx, mgcoge: corrected wrong flash sizes

flash size of mgcoge corrected
boot to 4M (was 32)
cfg to 32M (was 64)

---
 include/configs/mgcoge.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/mgcoge.h +2 -2
index a754f0b..f307382 100644
@@ -99,14 +99,14 @@
 
 #define CONFIG_SYS_SDRAM_BASE		0x00000000
 #define CONFIG_SYS_FLASH_BASE		0xFE000000
-#define CONFIG_SYS_FLASH_SIZE		32
+#define CONFIG_SYS_FLASH_SIZE		4
 #define CONFIG_SYS_FLASH_CFI
 #define CONFIG_FLASH_CFI_DRIVER
 #define CONFIG_SYS_MAX_FLASH_BANKS	2	/* max num of flash banks	*/
 #define CONFIG_SYS_MAX_FLASH_SECT	512	/* max num of sects on one chip */
 
 #define CONFIG_SYS_FLASH_BASE_1	0x50000000
-#define CONFIG_SYS_FLASH_SIZE_1	64
+#define CONFIG_SYS_FLASH_SIZE_1	32
 
 #define CONFIG_SYS_FLASH_BANKS_LIST { CONFIG_SYS_FLASH_BASE, CONFIG_SYS_FLASH_BASE_1 }
 
Signature · 5 lines
1.6.0.6

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

PATCH 12/31 82xx, mgcoge: corrected wrong flash sizes

Dear Heiko Schocher,

Quoted 15 lines · In message <[email protected]> you wrote:

flash size of mgcoge corrected
boot to 4M (was 32)
cfg to 32M (was 64)

---
 include/configs/mgcoge.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/mgcoge.h +0 -0
index a754f0b..f307382 100644

include/configs/mgcoge.h line 102

Quoted 5 lines
include/configs/mgcoge.h +1 -1
@@ -99,14 +99,14 @@
 
 #define CONFIG_SYS_SDRAM_BASE		0x00000000
 #define CONFIG_SYS_FLASH_BASE		0xFE000000
-#define CONFIG_SYS_FLASH_SIZE		32
+#define CONFIG_SYS_FLASH_SIZE		4

That's broken. The flash size should never be defined. Why don;t you use auto-detection as U-Boot was designed for?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You know, after a woman's raised a family and so on,  she  wants  to
start living her own life."   "Whose life she's _been_ living, then?"
                                  - Terry Pratchett, _Witches Abroad_
#2 lore raw

PATCH 12/31 82xx, mgcoge: corrected wrong flash sizes

Hello Wolfgang,

Quoted 17 lines · Wolfgang Denk
Quoted 16 lines · In message <[email protected]> you wrote:

flash size of mgcoge corrected
boot to 4M (was 32)
cfg to 32M (was 64)

---
 include/configs/mgcoge.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/mgcoge.h +0 -0
index a754f0b..f307382 100644
@@ -99,14 +99,14 @@
 
Quoted 7 lines

include/configs/mgcoge.h line 102

Quoted 4 lines
include/configs/mgcoge.h +1 -1
 #define CONFIG_SYS_SDRAM_BASE		0x00000000
 #define CONFIG_SYS_FLASH_BASE		0xFE000000
-#define CONFIG_SYS_FLASH_SIZE		32
+#define CONFIG_SYS_FLASH_SIZE		4

That's broken. The flash size should never be defined. Why don;t you use auto-detection as U-Boot was designed for?

I use the CFI driver ... have to check for what this defines are used (Hopefully they are no more used).

Argh... i used it.

I change this.

thanks
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany