Skip to contentSkip to conversation

OSS: missing parentheses?

PATCH In review Roel Kluin 2 participants 2 messages Feb 18, 2009 Sound

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 OSS: missing parentheses?

Please review. --------------------------->8-------------8<------------------------------ Add missing parentheses

---

sound/oss/pas2_card.c +1 -3
index 25f3a22..7f377ec 100644
@@ -156,9 +156,7 @@ static int __init config_pas_hw(struct address_info *hw_config)
 						 * 0x80
 						 */ , 0xB88);
 
-	pas_write(0x80
-		  | joystick?0x40:0
-		  ,0xF388);
+	pas_write(0x80 | (joystick ? 0x40 : 0), 0xF388);
 
 	if (pas_irq < 0 || pas_irq > 15)
 	{
#1 lore raw

At Wed, 18 Feb 2009 10:15:00 +0100,

Quoted 12 lines · Roel Kluin

Please review. --------------------------->8-------------8<------------------------------ Add missing parentheses

---

sound/oss/pas2_card.c +0 -0
index 25f3a22..7f377ec 100644

sound/oss/pas2_card.c static int __init config_pas_hw(struct address_info *hw_config) · line 159

Quoted 7 lines
sound/oss/pas2_card.c +1 -3
@@ -156,9 +156,7 @@ static int __init config_pas_hw(struct address_info *hw_config)
 						 * 0x80
 						 */ , 0xB88);
 
-	pas_write(0x80
-		  | joystick?0x40:0
-		  ,0xF388);
+	pas_write(0x80 | (joystick ? 0x40 : 0), 0xF388);

Yes, obviously a bug. Applied now.
Thanks!

Takashi