Skip to contentSkip to conversation

Add imls utility command

PATCH Superseded Marco 2 participants 3 messages Apr 28, 2009 – May 16, 2009

lore
Share & tools
lore

Marco

author
#0 lore raw

PATCH v6 1/1 Add imls utility command

From: Marco Stornelli <[email protected]>

This patch adds, under tools folder, a new command called imls. Its goal is the same of UBoot's imls but it can be used as Linux shell command. It reads from raw mtd partition and prints the list of the stored images.

---

Changes from v5:
- Swapped 'c' with 's' option

 tools/imls/Makefile |  106 ++++++++++++++++++++
 tools/imls/README   |   57 +++++++++++
 tools/imls/imls.c   |  270 +++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 433 insertions(+), 0 deletions(-)
 create mode 100644 tools/imls/Makefile
 create mode 100644 tools/imls/README
 create mode 100644 tools/imls/imls.c
tools/imls/Makefile new file +106 -0
new file mode 100644
index 0000000..d654658
@@ -0,0 +1,106 @@
+#
+# (C) Copyright 2009 Marco Stornelli <[email protected]>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+HOST_CFLAGS = -Wall -pedantic
+
+# Generated executable files
+BIN_FILES-y += imls
+
+# Source files which exist outside the tools/imls directory
+EXT_OBJ_FILES-y += lib_generic/crc32.o
+EXT_OBJ_FILES-y += lib_generic/md5.o
+EXT_OBJ_FILES-y += lib_generic/sha1.o
+EXT_OBJ_FILES-y += common/image.o
+
+# Source files located in the tools/imls directory
+OBJ_FILES-y += imls.o
+
+# Flattened device tree objects
+LIBFDT_OBJ_FILES-y += fdt.o
+LIBFDT_OBJ_FILES-y += fdt_ro.o
+LIBFDT_OBJ_FILES-y += fdt_rw.o
+LIBFDT_OBJ_FILES-y += fdt_strerror.o
+LIBFDT_OBJ_FILES-y += fdt_wip.o
+
+# now $(obj) is defined
+SRCS	+= $(addprefix $(SRCTREE)/,$(EXT_OBJ_FILES-y:.o=.c))
+SRCS	+= $(addprefix $(SRCTREE)/tools/,$(OBJ_FILES-y:.o=.c))
+SRCS	+= $(addprefix $(SRCTREE)/libfdt/,$(LIBFDT_OBJ_FILES-y:.o=.c))
+BINS	:= $(addprefix $(obj),$(sort $(BIN_FILES-y)))
+LIBFDT_OBJS	:= $(addprefix $(obj),$(LIBFDT_OBJ_FILES-y))
+
+#
+# Use native tools and options
+# Define __KERNEL_STRICT_NAMES to prevent typedef overlaps
+#
+CPPFLAGS   = -idirafter $(SRCTREE)/include \
+		-idirafter $(OBJTREE)/include2 \
+		-idirafter $(OBJTREE)/include \
+	        -I $(SRCTREE)/libfdt \
+		-I $(SRCTREE)/tools \
+		-DUSE_HOSTCC -D__KERNEL_STRICT_NAMES
+CFLAGS     = $(HOST_CFLAGS) $(CPPFLAGS) -O
+
+# No -pedantic switch to avoid libfdt compilation warnings
+FIT_CFLAGS = -Wall $(CPPFLAGS) -O
+
+CC	   = $(CROSS_COMPILER)gcc
+STRIP	   = $(CROSS_COMPILER)strip
+
+ifeq ($(MTD_VERSION),old)
+CPPFLAGS += -DMTD_OLD
+endif
+
+all:	$(BINS)
+
+$(obj)imls:	$(obj)imls.o $(obj)crc32.o $(obj)image.o $(obj)md5.o \
+		$(obj)sha1.o $(LIBFDT_OBJS)
+	$(CC) $(CFLAGS) -o $@ $^
+	$(STRIP) $@
+
+# Some files complain if compiled with -pedantic, use FIT_CFLAGS
+$(obj)image.o: $(SRCTREE)/common/image.c
+	$(CC) -g $(FIT_CFLAGS) -c -o $@ $<
+
+$(obj)imls.o: imls.c
+	$(CC) -g $(FIT_CFLAGS) -c -o $@ $<
+
+# Some of the tool objects need to be accessed from outside the tools/imls directory
+$(obj)%.o: $(SRCTREE)/common/%.c
+	$(CC) -g $(FIT_CFLAGS) -c -o $@ $<
+
+$(obj)%.o: $(SRCTREE)/lib_generic/%.c
+	$(CC) -g $(CFLAGS) -c -o $@ $<
+
+$(obj)%.o: $(SRCTREE)/libfdt/%.c
+	$(CC) -g $(FIT_CFLAGS) -c -o $@ $<
+
+clean:
+	rm -rf *.o imls
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
tools/imls/README new file +57 -0

57 lines not on this page · raw message

tools/imls/imls.c new file +270 -0

270 lines not on this page · raw message

#1 lore raw

PATCH v6 1/1 Add imls utility command

Dear Marco,

Quoted 13 lines · In message <[email protected]> you wrote:

From: Marco Stornelli <[email protected]>

This patch adds, under tools folder, a new command called imls. Its goal is the same of UBoot's imls but it can be used as Linux shell command. It reads from raw mtd partition and prints the list of the stored images.

---

Changes from v5:
- Swapped 'c' with 's' option

Quoted 7 lines
 tools/imls/Makefile |  106 ++++++++++++++++++++
 tools/imls/README   |   57 +++++++++++
 tools/imls/imls.c   |  270 +++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 433 insertions(+), 0 deletions(-)
 create mode 100644 tools/imls/Makefile
 create mode 100644 tools/imls/README
 create mode 100644 tools/imls/imls.c

Applie, thanks, but:

/home/wd/git/u-boot/work/.git/rebase-apply/patch:269: trailing whitespace.

                                if (--argc <= 0) 
/home/wd/git/u-boot/work/.git/rebase-apply/patch:313: trailing whitespace.
                fprintf(stderr, "%s: Unsupported flash type %u\n", 
/home/wd/git/u-boot/work/.git/rebase-apply/patch:370: trailing whitespace.
        }

/home/wd/git/u-boot/work/.git/rebase-apply/patch:437: trailing whitespace.

warning: 4 lines applied after fixing whitespace errors.

Please pay attention to the coding style!

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
Command, n.:
            Statement presented by a human and accepted by a computer
in such a manner as to make the human feel as if he is in control.
author
#2 lore raw

PATCH v6 1/1 Add imls utility command

Wolfgang Denk ha scritto:

Quoted 24 lines

Dear Marco,

Quoted 10 lines · In message <[email protected]> you wrote:

From: Marco Stornelli <[email protected]>

This patch adds, under tools folder, a new command called imls. Its goal is the same of UBoot's imls but it can be used as Linux shell command. It reads from raw mtd partition and prints the list of the stored images.

---

Applie, thanks, but:

/home/wd/git/u-boot/work/.git/rebase-apply/patch:269: trailing whitespace.

                                if (--argc <= 0) 
/home/wd/git/u-boot/work/.git/rebase-apply/patch:313: trailing whitespace.
                fprintf(stderr, "%s: Unsupported flash type %u\n", 
/home/wd/git/u-boot/work/.git/rebase-apply/patch:370: trailing whitespace.
        }

/home/wd/git/u-boot/work/.git/rebase-apply/patch:437: trailing whitespace.

Quoted 9 lines

warning: 4 lines applied after fixing whitespace errors.

Please pay attention to the coding style!

Best regards,

Wolfgang Denk

Thank you very much Wolfgang.

Regards,

Marco