xfstests 206: test for overflow in growfs size calculation
PATCH 1/1 xfstests 206: test for overflow in growfs size calculation
Test trim of last small AG for large filesystem resizes
As reported at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
this trimming may cause an overflow in the new size calculation.
Patch to fix it, and testcase at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193
---
206 new file +82 -0
@@ -0,0 +1,82 @@ +#! /bin/sh +# FS QA Test No. 206 +# +# Test trim of last small AG for large filesystem resizes +# +# As reported at +# http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187 +# this trimming may cause an overflow in the new size calculation. +# Patch and testcase at +# http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193 +# +#----------------------------------------------------------------------- +# Copyright (c) 2009 Eric Sandeen. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# +# creator [email protected] + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + umount $tmpdir + rmdir $tmpdir + rm -f $tmp + rm -f $tmpfile +} + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# real QA test starts here + +# Modify as appropriate. +_supported_fs xfs +_supported_os IRIX Linux + +tmpfile=$TEST_DIR/fsfile.$$ +tmpdir=$TEST_DIR/tmpdir.$$ + +mkdir -p $tmpdir || _fail "!!! failed to create temp mount dir" + +echo "=== xfs_io ===" +xfs_io -f -c "truncate 19998630180864" $tmpfile \ + || _fail "!!! failed to truncate loopback file to correct size" + +echo "=== mkfs.xfs ===" +mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b -llazy-count=0 $tmpfile \ + | sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" + +mount -o loop $tmpfile $tmpdir || _fail "!!! failed to loopback mount" + +echo "=== xfs_growfs ===" +xfs_growfs $tmpdir \ + | sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" \ + | grep -v "data blocks changed" + +# _cleanup cleans up + +# success, all done +status=0 +exit
206.out new file +20 -0
@@ -0,0 +1,20 @@ +QA output created by 206 +=== xfs_io === +=== mkfs.xfs === +meta-data=FILE isize=256 agcount=52, agsize=76288719 blks + = sectsz=512 attr=2 +data = bsize=4096 blocks=3905982455, imaxpct=5 + = sunit=0 swidth=0 blks +naming =version 2 bsize=4096 ascii-ci=0 +log =internal log bsize=4096 blocks=32768, version=2 + = sectsz=512 sunit=0 blks, lazy-count=0 +realtime =none extsz=4096 blocks=0, rtextents=0 +=== xfs_growfs === +meta-data=FILE isize=256 agcount=52, agsize=76288719 blks + = sectsz=512 attr=2 +data = bsize=4096 blocks=3905982455, imaxpct=5 + = sunit=0 swidth=0 blks +naming =version 2 bsize=4096 ascii-ci=0 +log =internal bsize=4096 blocks=32768, version=2 + = sectsz=512 sunit=0 blks, lazy-count=0 +realtime =none extsz=4096 blocks=0, rtextents=0
group +1 -0
@@ -310,3 +310,4 @@ atime 203 ioctl auto 204 metadata rw auto 205 metadata rw auto +206 growfs auto quick
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
PATCH v2 1/1 xfstests 206: test for overflow in growfs size calculation
Test trim of last small AG for large filesystem resizes
As reported at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
this trimming may cause an overflow in the new size calculation.
Patch to fix it, and testcase at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193
V2: now with proper expected (resized) output!
---
206 new file +85 -0
@@ -0,0 +1,85 @@ +#! /bin/sh +# FS QA Test No. 206 +# +# Test trim of last small AG for large filesystem resizes +# +# As reported at +# http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187 +# this trimming may cause an overflow in the new size calculation. +# Patch and testcase at +# http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193 +# +#----------------------------------------------------------------------- +# Copyright (c) 2009 Eric Sandeen. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# +# creator [email protected] + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + umount $tmpdir + rmdir $tmpdir + rm -f $tmp + rm -f $tmpfile +} + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# real QA test starts here + +# Modify as appropriate. +_supported_fs xfs +_supported_os IRIX Linux + +tmpfile=$TEST_DIR/fsfile.$$ +tmpdir=$TEST_DIR/tmpdir.$$ + +mkdir -p $tmpdir || _fail "!!! failed to create temp mount dir" + +echo "=== xfs_io ===" +xfs_io -f -c "truncate 19998630180864" $tmpfile \ + || _fail "!!! failed to truncate loopback file to correct size" + +echo "=== mkfs.xfs ===" +mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b -llazy-count=0 $tmpfile \ + | sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" + +mount -o loop $tmpfile $tmpdir || _fail "!!! failed to loopback mount" + +echo "=== xfs_growfs ===" +xfs_growfs $tmpdir \ + | sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" + +echo "=== xfs_info ===" +xfs_info $tmpdir \ + | sed -e "s,^meta-data=.*isize,meta-data=FILE isize,g" + +# _cleanup cleans up + +# success, all done +status=0 +exit
206.out new file +30 -0
@@ -0,0 +1,30 @@ +QA output created by 206 +=== xfs_io === +=== mkfs.xfs === +meta-data=FILE isize=256 agcount=52, agsize=76288719 blks + = sectsz=512 attr=2 +data = bsize=4096 blocks=3905982455, imaxpct=5 + = sunit=0 swidth=0 blks +naming =version 2 bsize=4096 ascii-ci=0 +log =internal log bsize=4096 blocks=32768, version=2 + = sectsz=512 sunit=0 blks, lazy-count=0 +realtime =none extsz=4096 blocks=0, rtextents=0 +=== xfs_growfs === +meta-data=FILE isize=256 agcount=52, agsize=76288719 blks + = sectsz=512 attr=2 +data = bsize=4096 blocks=3905982455, imaxpct=5 + = sunit=0 swidth=0 blks +naming =version 2 bsize=4096 ascii-ci=0 +log =internal bsize=4096 blocks=32768, version=2 + = sectsz=512 sunit=0 blks, lazy-count=0 +realtime =none extsz=4096 blocks=0, rtextents=0 +data blocks changed from 3905982455 to 4882478016 +=== xfs_info === +meta-data=FILE isize=256 agcount=64, agsize=76288719 blks + = sectsz=512 attr=2 +data = bsize=4096 blocks=4882478016, imaxpct=5 + = sunit=0 swidth=0 blks +naming =version 2 bsize=4096 ascii-ci=0 +log =internal bsize=4096 blocks=32768, version=2 + = sectsz=512 sunit=0 blks, lazy-count=0 +realtime =none extsz=4096 blocks=0, rtextents=0
group +1 -0
@@ -310,3 +310,4 @@ atime 203 ioctl auto 204 metadata rw auto 205 metadata rw auto +206 auto growfs quick
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 10 lines · Eric Sandeen
Test trim of last small AG for large filesystem resizes
As reported at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
this trimming may cause an overflow in the new size calculation.Patch to fix it, and testcase at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193V2: now with proper expected (resized) output!
This fails for me in really weird ways (Debian -testing, i386):
206.out.bad renamed from 206.out +8 -20
@@ -1,30 +1,18 @@ QA output created by 206 === xfs_io === +ftruncate: File too large === mkfs.xfs === +existing superblock read failed: Success +mkfs.xfs: pwrite64 failed: Invalid argument meta-data=FILE isize=256 agcount=52, agsize=76288719 blks = sectsz=512 attr=2 data = bsize=4096 blocks=3905982455, imaxpct=5 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0 -log =internal log bsize=4096 blocks=32768, version=2 - = sectsz=512 sunit=0 blks, lazy-count=0 -realtime =none extsz=4096 blocks=0, rtextents=0 -=== xfs_growfs === -meta-data=FILE isize=256 agcount=52, agsize=76288719 blks - = sectsz=512 attr=2 -data = bsize=4096 blocks=3905982455, imaxpct=5 - = sunit=0 swidth=0 blks -naming =version 2 bsize=4096 ascii-ci=0 -log =internal bsize=4096 blocks=32768, version=2 - = sectsz=512 sunit=0 blks, lazy-count=0 -realtime =none extsz=4096 blocks=0, rtextents=0 -data blocks changed from 3905982455 to 4882478016 -=== xfs_info === -meta-data=FILE isize=256 agcount=64, agsize=76288719 blks - = sectsz=512 attr=2 -data = bsize=4096 blocks=4882478016, imaxpct=5 - = sunit=0 swidth=0 blks -naming =version 2 bsize=4096 ascii-ci=0 -log =internal bsize=4096 blocks=32768, version=2 +log =internal log bsize=4096 blocks=521728, version=2 = sectsz=512 sunit=0 blks, lazy-count=0 realtime =none extsz=4096 blocks=0, rtextents=0 +mount: /dev/loop0: can't read superblock +!!! failed to loopback mount +(see 206.full for details) +umount: /mnt/test/tmpdir.4994: not mounted
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 18 lines · Christoph Hellwig
Quoted 10 lines · Eric Sandeen
Test trim of last small AG for large filesystem resizes
As reported at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
this trimming may cause an overflow in the new size calculation.Patch to fix it, and testcase at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193V2: now with proper expected (resized) output!
This fails for me in really weird ways (Debian -testing, i386):
206.out.bad line 3
Quoted 3 lines
206.out.bad renamed from 206.out +1
-0@@ -1,30 +1,18 @@ QA output created by 206 === xfs_io === +ftruncate: File too large
hm, 32-bit. crud. Should probably just restrict the test to 64-bit systems, since we need a file > 16T.
What's weirder is that xfs_io shoulda caused an error and caused the test to bail, I think.
As for the rest of it, I need better error handling I guess :)
-Eric
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs