arm, i2c: added support for the TWSI I2C Interface
added support for the Hardware I2C TWSI Interface on kirkwood SOCs, based on the Linux driver, without IRQ support.
Tested on a ARM926EJS (CPU Core Version FEROCEON_88FR131 SOC Family: KIRKWOOD, KW88F6281) based suen3 board
--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 453 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/mv64xxx-i2c.c
drivers/i2c/Makefile +1 -0
@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += omap1510_i2c.o COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o +COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.o COBJS-$(CONFIG_S3C44B0_I2C) += s3c44b0_i2c.o COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.o
drivers/i2c/mv64xxx-i2c.c new file +452 -0
452 lines not on this page · raw message
Signature · 5 lines
1.6.0.6 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 13 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 1:31 PM
To: Jean-Christophe PLAGNIOL-VILLARD; Prafulla Wadaskar
Cc: U-Boot user list
Subject: arm, i2c: added support for the TWSI I2C Interfaceadded support for the Hardware I2C TWSI Interface on kirkwood SOCs, based on the Linux driver, without IRQ support.
Quoted 7 lines
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC Family: KIRKWOOD, KW88F6281) based suen3 boardSigned-off-by Heiko Schocher <[email protected]>--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452
Can you rename this?
Quoted 9 lines
+++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 453 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/mv64xxx-i2c.cdrivers/i2c/Makefile +0
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) +=
Quoted 5 lines
omap1510_i2c.o
COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o
+COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.o
Put this in order
drivers/i2c/mv64xxx-i2c.c line 3
Quoted 12 lines
COBJS-$(CONFIG_S3C44B0_I2C) += s3c44b0_i2c.o
COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o
COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.odrivers/i2c/mv64xxx-i2c.c new file +3
-0@@ -0,0 +1,452 @@ +/* +* Driver for the i2c controller on the Marvell line of host bridges +* (e.g, gt642[46]0, mv643[46]0, mv644[46]0, and Orion SoC family).
Pls add kirkwood too..
Quoted 29 lines
drivers/i2c/mv64xxx-i2c.c new file +6
-0+* +* Based on: +* Author: Mark A. Greer <[email protected]> +* +* 2005 (c) MontaVista, Software, Inc. This file is licensed under +* the terms of the GNU General Public License version 2. This program
+ * is licensed "as is" without any warranty of any kind, whether express
+ * or implied.
+ *
+ * ported from Linux to u-boot
+ * (C) Copyright 2009
+ * Heiko Schocher, DENX Software Engineering, hs at denx.de.
+ *
+ */drivers/i2c/mv64xxx-i2c.c new file +9
-0+#include <common.h> +#include <i2c.h> +#include <asm/arch/kirkwood.h> +#include <asm/errno.h> +#include <asm/io.h> + +DECLARE_GLOBAL_DATA_PTR ; + +static unsigned int i2c_bus_num __attribute__ ((section(".data"))) = 0;
drivers/i2c/mv64xxx-i2c.c new file +2
-0+#if defined(CONFIG_I2C_MUX ) +static unsigned int i2c_bus_num_mux __attribute__ ((section("data"))) = 0;
drivers/i2c/mv64xxx-i2c.c line 33
Quoted 5 lines
drivers/i2c/mv64xxx-i2c.c new file +5
-0+#endif + +/* Register defines */ +#define MV64XXX_I2C_REG_SLAVE_ADDR 0x00 +#define MV64XXX_I2C_REG_DATA 0x04
MV64XX does not sound generic supported SoCs,
Can you choose better name? like TWSI.
I will go through in details latter on
Regards..
Prafulla . .
Hello Prafulla,
Quoted 11 lines · Prafulla Wadaskar
Quoted 11 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 1:31 PM
To: Jean-Christophe PLAGNIOL-VILLARD; Prafulla Wadaskar
Cc: U-Boot user list
Subject: arm, i2c: added support for the TWSI I2C Interfaceadded support for the Hardware I2C TWSI Interface on kirkwood SOCs, based on the Linux driver, without IRQ support.
Quoted 8 lines
Quoted 7 lines
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC Family: KIRKWOOD, KW88F6281) based suen3 boardSigned-off-by Heiko Schocher <[email protected]>--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452Can you rename this?
Of course, what name do you prefer?
Quoted 4 lines
Quoted 4 lines
+++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 453 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/mv64xxx-i2c.c
Quoted 11 lines
Quoted 10 lines
drivers/i2c/Makefile +0
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) +=omap1510_i2c.o
COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o
+COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.oPut this in order
What do you mean?
Quoted 5 lines
Quoted 5 lines
COBJS-$(CONFIG_S3C44B0_I2C) += s3c44b0_i2c.o
COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o
COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.odrivers/i2c/mv64xxx-i2c.c new file +0
-0
Quoted 8 lines
drivers/i2c/mv64xxx-i2c.c line 3
Quoted 7 lines
index 0000000..6ba2782
drivers/i2c/mv64xxx-i2c.c new file +3
-0@@ -0,0 +1,452 @@ +/* +* Driver for the i2c controller on the Marvell line of host bridges +* (e.g, gt642[46]0, mv643[46]0, mv644[46]0, and Orion SoC family). Pls add kirkwood too..
OK.
Quoted 28 lines
Quoted 28 lines
drivers/i2c/mv64xxx-i2c.c new file +6
-0+* +* Based on: +* Author: Mark A. Greer <[email protected]> +* +* 2005 (c) MontaVista, Software, Inc. This file is licensed under +* the terms of the GNU General Public License version 2. This program
+ * is licensed "as is" without any warranty of any kind, whether express
+ * or implied.
+ *
+ * ported from Linux to u-boot
+ * (C) Copyright 2009
+ * Heiko Schocher, DENX Software Engineering, hs at denx.de.
+ *
+ */drivers/i2c/mv64xxx-i2c.c new file +9
-0+#include <common.h> +#include <i2c.h> +#include <asm/arch/kirkwood.h> +#include <asm/errno.h> +#include <asm/io.h> + +DECLARE_GLOBAL_DATA_PTR ; + +static unsigned int i2c_bus_num __attribute__ ((section(".data"))) = 0;
drivers/i2c/mv64xxx-i2c.c new file +2
-0+#if defined(CONFIG_I2C_MUX ) +static unsigned int i2c_bus_num_mux __attribute__ ((section
Quoted 8 lines
drivers/i2c/mv64xxx-i2c.c line 33
Quoted 6 lines
("data"))) = 0;
drivers/i2c/mv64xxx-i2c.c new file +5
-0+#endif + +/* Register defines */ +#define MV64XXX_I2C_REG_SLAVE_ADDR 0x00 +#define MV64XXX_I2C_REG_DATA 0x04MV64XX does not sound generic supported SoCs,
Can you choose better name? like TWSI.
Ah, OK. Used the names from the Linux driver. So I think above define for selecting this drivers should be something like that:
CONFIG_DRIVER_I2C_TWSI ... (I vote for using CONFIG_DRIVER_I2C_ for new drivers and maybe I find some time renaming the existing drivers to this format...)
and replace MV64xxx with TWSI ... right?
Quoted 1 line
I will go through in details latter on
OK, thanks in advance.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 26 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 3:34 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot user list
Subject: Re: arm, i2c: added support for the TWSI I2C InterfaceHello Prafulla,
Quoted 14 lines · Prafulla Wadaskar
Quoted 14 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 1:31 PM
To: Jean-Christophe PLAGNIOL-VILLARD; Prafulla Wadaskar
Cc: U-Boot user list
Subject: arm, i2c: added support for the TWSI I2C Interfaceadded support for the Hardware I2C TWSI Interface on kirkwood SOCs, based on the Linux driver, without IRQ support.
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC Family: KIRKWOOD, KW88F6281) based suen3 board
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Signed-off-by Heiko Schocher <[email protected]>--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452Can you rename this?
Of course, what name do you prefer?
I will prefer a name kirkwood_i2c.c
Quoted 17 lines
Quoted 5 lines
Quoted 5 lines
+++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 453 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/mv64xxx-i2c.cQuoted 11 lines
Quoted 10 lines
drivers/i2c/Makefile +0
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) +=omap1510_i2c.o
COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o
+COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.oPut this in order
Quoted 1 line
What do you mean?
Arrange them in alphabetical order, insert this line between "l" "m"
Regards..
Prafulla . .
Hello Prafulla,
Quoted 24 lines · Prafulla Wadaskar
Quoted 24 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 3:34 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot user list
Subject: Re: arm, i2c: added support for the TWSI I2C InterfaceHello Prafulla,
Quoted 14 lines · Prafulla Wadaskar
Quoted 14 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 1:31 PM
To: Jean-Christophe PLAGNIOL-VILLARD; Prafulla Wadaskar
Cc: U-Boot user list
Subject: arm, i2c: added support for the TWSI I2C Interfaceadded support for the Hardware I2C TWSI Interface on kirkwood SOCs, based on the Linux driver, without IRQ support.
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC Family: KIRKWOOD, KW88F6281) based suen3 board
Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
Signed-off-by Heiko Schocher <[email protected]>--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452Can you rename this?
Of course, what name do you prefer?
I will prefer a name
kirkwood_i2c.c
Hmm.. I thought twsi_i2c.c ...
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 9 lines
+++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 453 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/mv64xxx-i2c.cdrivers/i2c/Makefile +0
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) +=Quoted 5 lines
omap1510_i2c.o
COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o
+COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.oPut this in order
Quoted 2 lines
Quoted 1 line
What do you mean?
Arrange them in alphabetical order, insert this line between "l" "m"
I think the "alphabetical order" is for the CONFIG_ defines ... so I used the right place for it ... but, if I rename this define in CONFIG_DRIVER_I2C_TWSI, it gets another place (between
COBJS-$(CONFIG_I2C_MXC) += mxc_i2c.o
+COBJS-$(CONFIG_DRIVER_I2C_TWSI) += twsi_i2c.o
COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += omap1510_i2c.o)
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 40 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 3:47 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot user list
Subject: Re: arm, i2c: added support for the TWSI I2C InterfaceHello Prafulla,
Quoted 10 lines · Prafulla Wadaskar
Quoted 10 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 3:34 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot user list
Subject: Re: arm, i2c: added support for the TWSI I2C InterfaceHello Prafulla,
Prafulla Wadaskar wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 1:31 PM
To: Jean-Christophe PLAGNIOL-VILLARD; Prafulla Wadaskar
Cc: U-Boot user list
Subject: arm, i2c: added support for the TWSI I2C Interfaceadded support for the Hardware I2C TWSI Interface on
kirkwood SOCs,
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
based on the Linux driver, without IRQ support.
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC
Family: KIRKWOOD, KW88F6281) based suen3 boardSigned-off-by Heiko Schocher <[email protected]>--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Can you rename this?
Of course, what name do you prefer?
I will prefer a name
kirkwood_i2c.cHmm.. I thought
twsi_i2c.c...
#include <asm/arch/Kirkwood.h> in your file indicate it is kirkwood low level driver
If you wish twsi_i2c.c is more generic name, but in that case you need to abstract arch specific support well.
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 10 lines
+++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 453 insertions(+), 0 deletions(-) create mode100644
drivers/i2c/mv64xxx-i2c.cdrivers/i2c/Makefile index renamed from drivers/i2c/Makefile +0
-0ef32f13..ce30111 100644
drivers/i2c/Makefile +0
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) +=Quoted 5 lines
omap1510_i2c.o
COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o
+COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.oPut this in order
Quoted 8 lines
Quoted 2 lines
Quoted 1 line
What do you mean?
Arrange them in alphabetical order, insert this line between "l" "m"
I think the "alphabetical order" is for the
CONFIG_defines ... so I used the right place for it ... but, if I rename this define inCONFIG_DRIVER_I2C_TWSI, it gets another place (between
COBJS-$(CONFIG_I2C_MXC) += mxc_i2c.o
+COBJS-$(CONFIG_DRIVER_I2C_TWSI) += twsi_i2c.o
Also this could be CONFIG_I2C_KIRKWOOD or CONFIG_I2C_TWSI or CONFIG_TWSI_I2C
Regards..
Prafulla . .
Quoted 8 lines
COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += omap1510_i2c.o)
bye
HeikoSignature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hello Prafulla,
Quoted 38 lines · Prafulla Wadaskar
Quoted 38 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 3:47 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot user list
Subject: Re: arm, i2c: added support for the TWSI I2C InterfaceHello Prafulla,
Quoted 10 lines · Prafulla Wadaskar
Quoted 10 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 3:34 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; U-Boot user list
Subject: Re: arm, i2c: added support for the TWSI I2C InterfaceHello Prafulla,
Prafulla Wadaskar wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Thursday, July 16, 2009 1:31 PM
To: Jean-Christophe PLAGNIOL-VILLARD; Prafulla Wadaskar
Cc: U-Boot user list
Subject: arm, i2c: added support for the TWSI I2C Interfaceadded support for the Hardware I2C TWSI Interface on
kirkwood SOCs,
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
based on the Linux driver, without IRQ support.
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC
Family: KIRKWOOD, KW88F6281) based suen3 boardSigned-off-by Heiko Schocher <[email protected]>--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452
Quoted 6 lines
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Can you rename this?
Of course, what name do you prefer?
I will prefer a name
kirkwood_i2c.cHmm.. I thought
twsi_i2c.c...#include <
asm/arch/Kirkwood.h> in your file indicate it is kirkwood low level driver
If you wishtwsi_i2c.cis more generic name, but in that case you need to abstract arch specific support well.
I have no idea, how generic this driver is, so I vote for naming it in the first step as kirkwood_i2c.c as you suggested. (Because I could not test it on another plattform)
If someone use it on another plattforms, we can do this step later.
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 9 lines
+++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 453 insertions(+), 0 deletions(-) create mode100644
drivers/i2c/mv64xxx-i2c.cdrivers/i2c/Makefile index renamed from drivers/i2c/Makefile +0
-0ef32f13..ce30111 100644
drivers/i2c/Makefile +0
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) +=Quoted 5 lines
omap1510_i2c.o
COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o
+COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.oPut this in order
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
Quoted 1 line
What do you mean?
Arrange them in alphabetical order, insert this line between "l" "m"
I think the "alphabetical order" is for the
CONFIG_defines ... so I used the right place for it ... but, if I rename this define inCONFIG_DRIVER_I2C_TWSI, it gets another place (between
COBJS-$(CONFIG_I2C_MXC) += mxc_i2c.o
+COBJS-$(CONFIG_DRIVER_I2C_TWSI) += twsi_i2c.oAlso this could be
CONFIG_I2C_KIRKWOODorCONFIG_I2C_TWSIorCONFIG_TWSI_I2C
Yep KIRKWOOD is what I prefer actual.
thanks
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 8 lines · Heiko Schocher
added support for the Hardware I2C TWSI Interface on kirkwood SOCs, based on the Linux driver, without IRQ support.
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC Family: KIRKWOOD, KW88F6281) based suen3 boardSigned-off-by Heiko Schocher <[email protected]>
could apply the following CONFIG name convention cleanup before please
Quoted 42 lines
--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 453 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/mv64xxx-i2c.cdrivers/i2c/Makefile +1
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += omap1510_i2c.o COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o +COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.o COBJS-$(CONFIG_S3C44B0_I2C) += s3c44b0_i2c.o COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.odrivers/i2c/mv64xxx-i2c.c new file +18
-0@@ -0,0 +1,452 @@ +/* +* Driver for the i2c controller on the Marvell line of host bridges +* (e.g, gt642[46]0, mv643[46]0, mv644[46]0, and Orion SoC family). +* +* Based on: +* Author: Mark A. Greer <[email protected]> +* +* 2005 (c) MontaVista, Software, Inc. This file is licensed under +* the terms of the GNU General Public License version 2. This program +* is licensed "as is" without any warranty of any kind, whether express +* or implied. +* +* ported from Linux to u-boot +* (C) Copyright 2009 +* Heiko Schocher, DENX Software Engineering, hs at denx.de. +* +*/ +#include <common.h>
drivers/i2c/mv64xxx-i2c.c line 28
Quoted 10 lines
drivers/i2c/mv64xxx-i2c.c new file +10
-0+#include <i2c.h> +#include <asm/arch/kirkwood.h> +#include <asm/errno.h> +#include <asm/io.h> + +DECLARE_GLOBAL_DATA_PTR ; + +static unsigned int i2c_bus_num __attribute__ ((section (".data"))) = 0; +#if defined(CONFIG_I2C_MUX ) +static unsigned int i2c_bus_num_mux __attribute__ ((section ("data"))) = 0;
.data
drivers/i2c/mv64xxx-i2c.c line 29
Quoted 1 line
drivers/i2c/mv64xxx-i2c.c new file +1
-0+#endif
no need of put it in section .data on arm
Quoted 1 line
drivers/i2c/mv64xxx-i2c.c new file +1
-0+
<snip>
drivers/i2c/mv64xxx-i2c.c line 385
Quoted 5 lines
drivers/i2c/mv64xxx-i2c.c new file +5
-0+ +void +i2c_init (int speed,int slaveadd) +{ +mv64xxx_i2c_hw_init ();
impossible to specify a speed?
or update it at runtime?
Quoted 2 lines
+}
Best Regards,
J.
PATCH 1/1 i2c: use for CONFIGs a common naming convention CONFIG_I2C
In reply to Heiko Schocherinstead have different naming convention CONFIG_I2C, CONFIG_xxxx_I2C use the same CONFIG_I2C
---
due to ML limit size
you can find the patch here
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commitdiff_plain;h=debabbd27578e142d8361f8e266b89bb18c938d4;hp=dcf728a6afc3e5b6031c520f9393e860b732b2ea
or generate yourself with this commands
git grep -l CONFIG_BFIN_TWI_I2C | xargs sed -i -e "s:CONFIG_BFIN_TWI_I2C:CONFIG_I2C_BFIN_TWI:g" git grep -l CONFIG_DRIVER_DAVINCI_I2C | xargs sed -i -e "s:CONFIG_DRIVER_DAVINCI_I2C:CONFIG_I2C_DAVINCI:g" git grep -l CONFIG_FSL_I2C | xargs sed -i -e "s:CONFIG_FSL_I2C:CONFIG_I2C_FSL:g"
git grep -l CONFIG_DRIVER_OMAP1510_I2C | xargs sed -i -e "s:CONFIG_DRIVER_OMAP1510_I2C:CONFIG_I2C_OMAP1510:g" git grep -l CONFIG_DRIVER_OMAP24XX_I2C | xargs sed -i -e "s:CONFIG_DRIVER_OMAP24XX_I2C:CONFIG_I2C_OMAP24XX:g" git grep -l CONFIG_DRIVER_OMAP34XX_I2C | xargs sed -i -e "s:CONFIG_DRIVER_OMAP34XX_I2C:CONFIG_I2C_OMAP34XX:g"
git grep -l CONFIG_DRIVER_S3C24X0_I2C | xargs sed -i -e "s:CONFIG_DRIVER_S3C24X0_I2C:CONFIG_I2C_S3C24X0:g" git grep -l CONFIG_SOFT_I2C | xargs sed -i -e "s:CONFIG_SOFT_I2C:CONFIG_I2C_SOFT:g"
git grep -l CONFIG_HARD_I2C | xargs sed -i -e "s:CONFIG_HARD_I2C:CONFIG_I2C_HARD:g"
git grep -l CONFIG_TSI108_I2C | xargs sed -i -e "s:CONFIG_TSI108_I2C:CONFIG_I2C_TSI108:g"
Best Regards,
J.
README | 18 +++++++++--------- board/atc/atc.c | 4 ++-- board/cm5200/cm5200.c | 4 ++-- board/cmc_pu2/load_sernum_ethaddr.c | 4 ++-- board/cpu86/cpu86.c | 4 ++-- board/cpu87/cpu87.c | 4 ++-- board/fads/fads.h | 2 +- board/freescale/mpc8349itx/mpc8349itx.c | 2 +- board/freescale/mpc8349itx/pci.c | 2 +- board/ids8247/ids8247.c | 4 ++-- board/keymile/common/common.c | 8 ++++---- board/keymile/mgcoge/mgcoge.c | 4 ++-- board/m501sk/eeprom.c | 2 +- board/muas3001/muas3001.c | 2 +- board/omap3/common/power.c | 2 +- board/omap3/evm/evm.c | 2 +- board/pm826/pm826.c | 4 ++-- board/pm828/pm828.c | 4 ++-- board/sacsng/ioconfig.h | 4 ++-- board/sandburst/common/ppc440gx_i2c.h | 4 ++-- board/sbc8260/sbc8260.c | 4 ++-- board/siemens/SCM/scm.c | 4 ++-- board/tqc/tqm8260/tqm8260.c | 4 ++-- board/tqc/tqm8272/tqm8272.c | 4 ++-- board/trab/trab.c | 4 ++-- common/cmd_eeprom.c | 4 ++-- common/devices.c | 4 ++-- cpu/arm920t/at91rm9200/i2c.c | 4 ++-- cpu/arm926ejs/davinci/dm355.c | 2 +- cpu/arm926ejs/davinci/dm644x.c | 2 +- cpu/arm_cortexa8/omap3/clock.c | 2 +- cpu/mcf5227x/cpu_init.c | 2 +- cpu/mcf5227x/speed.c | 2 +- cpu/mcf523x/cpu_init.c | 2 +- cpu/mcf523x/speed.c | 2 +- cpu/mcf52x2/cpu_init.c | 4 ++-- cpu/mcf52x2/speed.c | 2 +- cpu/mcf532x/cpu_init.c | 4 ++-- cpu/mcf532x/speed.c | 2 +- cpu/mcf5445x/cpu_init.c | 2 +- cpu/mcf5445x/speed.c | 2 +- cpu/mcf547x_8x/cpu_init.c | 2 +- cpu/mcf547x_8x/speed.c | 2 +- cpu/mpc512x/i2c.c | 4 ++-- cpu/mpc5xxx/i2c.c | 4 ++-- cpu/mpc8220/i2c.c | 4 ++-- cpu/mpc824x/drivers/i2c/i2c.c | 4 ++-- cpu/mpc8260/commproc.c | 2 +- cpu/mpc8260/i2c.c | 4 ++-- cpu/mpc8xx/i2c.c | 4 ++-- cpu/ppc4xx/i2c.c | 4 ++-- cpu/pxa/i2c.c | 4 ++-- doc/README.m52277evb | 6 +++--- doc/README.m53017evb | 6 +++--- doc/README.m5373evb | 6 +++--- doc/README.m54455evb | 6 +++--- doc/README.m5475evb | 6 +++--- drivers/i2c/Makefile | 18 +++++++++--------- drivers/i2c/fsl_i2c.c | 4 ++-- drivers/i2c/mxc_i2c.c | 4 ++-- drivers/i2c/s3c24x0_i2c.c | 4 ++-- drivers/i2c/soft_i2c.c | 2 +- include/asm-m68k/global_data.h | 2 +- include/configs/A3000.h | 4 ++-- include/configs/APC405.h | 2 +- include/configs/ASH405.h | 2 +- include/configs/ATUM8548.h | 6 +++--- include/configs/Alaska8220.h | 2 +- include/configs/B2.h | 2 +- include/configs/BC3450.h | 2 +- include/configs/CANBT.h | 2 +- include/configs/CATcenter.h | 2 +- include/configs/CMS700.h | 2 +- include/configs/CPC45.h | 2 +- include/configs/CPCI2DP.h | 2 +- include/configs/CPCI405.h | 2 +- include/configs/CPCI4052.h | 2 +- include/configs/CPCI405AB.h | 2 +- include/configs/CPCI405DT.h | 2 +- include/configs/CPCIISER4.h | 2 +- include/configs/CPU86.h | 2 +- include/configs/CPU87.h | 2 +- include/configs/CRAYL1.h | 2 +- include/configs/DASA_SIM.h | 2 +- include/configs/DP405.h | 2 +- include/configs/DU405.h | 2 +- include/configs/DU440.h | 4 ++-- include/configs/ERIC.h | 2 +- include/configs/EXBITGEN.h | 2 +- include/configs/FADS823.h | 2 +- include/configs/G2000.h | 2 +- include/configs/GEN860T.h | 8 ++++---- include/configs/GENIETV.h | 2 +- include/configs/HH405.h | 2 +- include/configs/HIDDEN_DRAGON.h | 8 ++++---- include/configs/HMI10.h | 4 ++-- include/configs/HUB405.h | 2 +- include/configs/IAD210.h | 4 ++-- include/configs/ICU862.h | 4 ++-- include/configs/IDS8247.h | 4 ++-- include/configs/IP860.h | 4 ++-- include/configs/IPHASE4539.h | 8 ++++---- include/configs/IceCube.h | 2 +- include/configs/JSE.h | 4 ++-- include/configs/KAREF.h | 4 ++-- include/configs/KUP4K.h | 8 ++++---- include/configs/KUP4X.h | 8 ++++---- include/configs/M52277EVB.h | 6 +++--- include/configs/M5235EVB.h | 6 +++--- include/configs/M5253DEMO.h | 4 ++-- include/configs/M5271EVB.h | 6 +++--- include/configs/M5275EVB.h | 6 +++--- include/configs/M53017EVB.h | 6 +++--- include/configs/M5329EVB.h | 6 +++--- include/configs/M5373EVB.h | 6 +++--- include/configs/M54451EVB.h | 6 +++--- include/configs/M54455EVB.h | 6 +++--- include/configs/M5475EVB.h | 6 +++--- include/configs/M5485EVB.h | 6 +++--- include/configs/METROBOX.h | 4 ++-- include/configs/MHPC.h | 4 ++-- include/configs/MIP405.h | 2 +- include/configs/MPC8260ADS.h | 2 +- include/configs/MPC8266ADS.h | 2 +- include/configs/MPC8313ERDB.h | 4 ++-- include/configs/MPC8315ERDB.h | 4 ++-- include/configs/MPC8323ERDB.h | 6 +++--- include/configs/MPC832XEMDS.h | 6 +++--- include/configs/MPC8349EMDS.h | 6 +++--- include/configs/MPC8349ITX.h | 12 ++++++------ include/configs/MPC8360EMDS.h | 6 +++--- include/configs/MPC8360ERDK.h | 6 +++--- include/configs/MPC837XEMDS.h | 6 +++--- include/configs/MPC837XERDB.h | 6 +++--- include/configs/MPC8536DS.h | 6 +++--- include/configs/MPC8540ADS.h | 6 +++--- include/configs/MPC8540EVAL.h | 6 +++--- include/configs/MPC8541CDS.h | 6 +++--- include/configs/MPC8544DS.h | 6 +++--- include/configs/MPC8548CDS.h | 6 +++--- include/configs/MPC8555CDS.h | 6 +++--- include/configs/MPC8560ADS.h | 6 +++--- include/configs/MPC8568MDS.h | 6 +++--- include/configs/MPC8569MDS.h | 6 +++--- include/configs/MPC8572DS.h | 6 +++--- include/configs/MPC8610HPCD.h | 6 +++--- include/configs/MPC8641HPCN.h | 6 +++--- include/configs/MVBLM7.h | 6 +++--- include/configs/NC650.h | 4 ++-- include/configs/OCRTC.h | 2 +- include/configs/ORSG.h | 2 +- include/configs/OXC.h | 2 +- include/configs/P2020DS.h | 6 +++--- include/configs/PCI405.h | 2 +- include/configs/PIP405.h | 2 +- include/configs/PLU405.h | 2 +- include/configs/PM520.h | 2 +- include/configs/PM826.h | 4 ++-- include/configs/PM828.h | 4 ++-- include/configs/PM854.h | 6 +++--- include/configs/PM856.h | 6 +++--- include/configs/PMC405.h | 2 +- include/configs/PMC440.h | 4 ++-- include/configs/PPChameleonEVB.h | 2 +- include/configs/R360MPI.h | 2 +- include/configs/RBC823.h | 2 +- include/configs/RPXClassic.h | 4 ++-- include/configs/RPXsuper.h | 2 +- include/configs/RRvision.h | 8 ++++---- include/configs/SBC8540.h | 6 +++--- include/configs/SCM.h | 4 ++-- include/configs/SIMPC8313.h | 4 ++-- include/configs/SMN42.h | 8 ++++---- include/configs/SX1.h | 4 ++-- include/configs/SXNI855T.h | 2 +- include/configs/Sandpoint8240.h | 8 ++++---- include/configs/Sandpoint8245.h | 8 ++++---- include/configs/TASREG.h | 4 ++-- include/configs/TB5200.h | 2 +- include/configs/TK885D.h | 8 ++++---- include/configs/TOP5200.h | 8 ++++---- include/configs/TOP860.h | 4 ++-- include/configs/TQM5200.h | 2 +- include/configs/TQM8260.h | 4 ++-- include/configs/TQM8272.h | 8 ++++---- include/configs/TQM834x.h | 6 +++--- include/configs/TQM855M.h | 8 ++++---- include/configs/TQM85xx.h | 6 +++--- include/configs/TQM866M.h | 8 ++++---- include/configs/TQM885D.h | 8 ++++---- include/configs/Total5200.h | 2 +- include/configs/VCMA9.h | 4 ++-- include/configs/VOH405.h | 2 +- include/configs/VOM405.h | 2 +- include/configs/W7OLMC.h | 2 +- include/configs/W7OLMG.h | 2 +- include/configs/WUH405.h | 2 +- include/configs/XPEDITE1K.h | 4 ++-- include/configs/XPEDITE5170.h | 4 ++-- include/configs/XPEDITE5200.h | 4 ++-- include/configs/XPEDITE5370.h | 4 ++-- include/configs/Yukon8220.h | 2 +- include/configs/aev.h | 2 +- include/configs/alpr.h | 4 ++-- include/configs/amcc-common.h | 2 +- include/configs/aria.h | 4 ++-- include/configs/at91rm9200ek.h | 4 ++-- include/configs/barco.h | 8 ++++---- include/configs/bf518f-ezbrd.h | 4 ++-- include/configs/bf526-ezbrd.h | 4 ++-- include/configs/bf527-ezkit.h | 4 ++-- include/configs/bf533-ezkit.h | 4 ++-- include/configs/bf533-stamp.h | 4 ++-- include/configs/bf537-minotaur.h | 4 ++-- include/configs/bf537-pnav.h | 4 ++-- include/configs/bf537-srv1.h | 4 ++-- include/configs/bf537-stamp.h | 4 ++-- include/configs/bf538f-ezkit.h | 4 ++-- include/configs/bf548-ezkit.h | 4 ++-- include/configs/bf561-ezkit.h | 4 ++-- include/configs/bfin_adi_common.h | 2 +- include/configs/blackstamp.h | 4 ++-- include/configs/cm-bf527.h | 4 ++-- include/configs/cm-bf537e.h | 4 ++-- include/configs/cm-bf548.h | 4 ++-- include/configs/cm5200.h | 2 +- include/configs/cmc_pu2.h | 6 +++--- include/configs/cogent_mpc8xx.h | 2 +- include/configs/cpci5200.h | 2 +- include/configs/csb272.h | 2 +- include/configs/csb472.h | 2 +- include/configs/davinci_dm355evm.h | 4 ++-- include/configs/davinci_dvevm.h | 4 ++-- include/configs/davinci_schmoogie.h | 4 ++-- include/configs/davinci_sffsdr.h | 4 ++-- include/configs/davinci_sonata.h | 4 ++-- include/configs/debris.h | 8 ++++---- include/configs/delta.h | 2 +- include/configs/digsy_mtc.h | 2 +- include/configs/eXalion.h | 4 ++-- include/configs/ep8248.h | 2 +- include/configs/ep8260.h | 8 ++++---- include/configs/ep82xxm.h | 2 +- include/configs/hmi1001.h | 2 +- include/configs/hymod.h | 2 +- include/configs/ibf-dsp561.h | 4 ++-- include/configs/imx31_phycore.h | 2 +- include/configs/innokom.h | 2 +- include/configs/jupiter.h | 2 +- include/configs/kb9202.h | 2 +- include/configs/km8xx.h | 4 ++-- include/configs/kmeter1.h | 6 +++--- include/configs/korat.h | 4 ++-- include/configs/kvme080.h | 2 +- include/configs/lwmon.h | 8 ++++---- include/configs/lwmon5.h | 4 ++-- include/configs/m501sk.h | 2 +- include/configs/mcc200.h | 2 +- include/configs/mecp5123.h | 4 ++-- include/configs/mecp5200.h | 2 +- include/configs/mgcoge.h | 4 ++-- include/configs/motionpro.h | 2 +- include/configs/mp2usb.h | 8 ++++---- include/configs/mpc5121ads.h | 4 ++-- include/configs/mpc7448hpc2.h | 2 +- include/configs/muas3001.h | 2 +- include/configs/mucmc52.h | 2 +- include/configs/netstal-common.h | 2 +- include/configs/netstar.h | 4 ++-- include/configs/o2dnt.h | 2 +- include/configs/omap2420h4.h | 4 ++-- include/configs/omap3_beagle.h | 2 +- include/configs/omap3_evm.h | 2 +- include/configs/omap3_overo.h | 2 +- include/configs/omap3_pandora.h | 2 +- include/configs/omap3_zoom1.h | 2 +- include/configs/omap3_zoom2.h | 2 +- include/configs/p3p440.h | 4 ++-- include/configs/pcm030.h | 2 +- include/configs/pcs440ep.h | 4 ++-- include/configs/pcu_e.h | 2 +- include/configs/pdnb3.h | 4 ++-- include/configs/pf5200.h | 2 +- include/configs/quad100hd.h | 4 ++-- include/configs/rmu.h | 4 ++-- include/configs/rsdproto.h | 2 +- include/configs/sacsng.h | 8 ++++---- include/configs/sbc405.h | 4 ++-- include/configs/sbc8260.h | 8 ++++---- include/configs/sbc8349.h | 6 +++--- include/configs/sbc8548.h | 6 +++--- include/configs/sbc8560.h | 6 +++--- include/configs/sbc8641d.h | 6 +++--- include/configs/sc3.h | 4 ++-- include/configs/smmaco4.h | 2 +- include/configs/socrates.h | 6 +++--- include/configs/sorcery.h | 2 +- include/configs/spc1920.h | 8 ++++---- include/configs/spieval.h | 2 +- include/configs/stxgp3.h | 6 +++--- include/configs/stxssa.h | 6 +++--- include/configs/tcm-bf537.h | 4 ++-- include/configs/trab.h | 6 +++--- include/configs/uc100.h | 8 ++++---- include/configs/uc101.h | 2 +- include/configs/utx8245.h | 4 ++-- include/configs/v38b.h | 2 +- include/configs/vct.h | 6 +++--- include/configs/voiceblue.h | 4 ++-- include/configs/xm250.h | 2 +- include/configs/zeus.h | 4 ++-- lib_arm/board.c | 8 ++++---- lib_m68k/board.c | 8 ++++---- lib_ppc/board.c | 8 ++++---- 314 files changed, 636 insertions(+), 636 deletions(-)
Best Regards,
J.
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 7 lines · In message <[email protected]> you wrote:
drivers/i2c/mv64xxx-i2c.c line 28
Quoted 4 lines
drivers/i2c/mv64xxx-i2c.c new file +3
-0+static unsigned int i2c_bus_num __attribute__ ((section (".data"))) = 0; +#if defined(CONFIG_I2C_MUX ) +static unsigned int i2c_bus_num_mux __attribute__ ((section ("data"))) = 0;.data
Quoted 1 line
+#endif
no need of put it in section .data on arm
What makes you think so? I disagree. You don't have initialized BSS in the early stages, so you are in the same situation as other architectures.
And even if it was really not necessary, it doesn't hurt either.
Heiko, please do NOT change this.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "I used to think that the brain was the most wonderful organ in my body. Then I realized who was telling me this." - Emo Phillips
PATCH 1/1 i2c: use for CONFIGs a common naming convention CONFIG_I2C
In reply to Jean-Christophe PLAGNIOL-VILLARDDear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 4 lines · In message <[email protected]> you wrote:
instead have different naming convention
CONFIG_I2C,CONFIG_xxxx_I2Cuse the sameCONFIG_I2CSigned-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Please change the subject to:
"I2C: use CONFIG_I2C_* as common prefix for I2C related names"
Thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Go to Heaven for the climate, Hell for the company." - Mark Twain
Hello Jean-Christophe,
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines · Heiko Schocher
added support for the Hardware I2C TWSI Interface on kirkwood SOCs, based on the Linux driver, without IRQ support.
Tested on a ARM926EJS (CPU Core Version
FEROCEON_88FR131SOC Family: KIRKWOOD, KW88F6281) based suen3 boardSigned-off-by Heiko Schocher <[email protected]>could apply the following CONFIG name convention cleanup before please
I don;t understand you here. You have a "CONFIG name convention cleanup" patch somewhere? Is this somewhere discussed, how this should look like? (I think, a "CONFIG_DRIVER_I2C_xxx" would be good)
Quoted 53 lines
Quoted 42 lines
--- drivers/i2c/Makefile | 1 + drivers/i2c/mv64xxx-i2c.c | 452 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 453 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/mv64xxx-i2c.cdrivers/i2c/Makefile +1
-0@@ -33,6 +33,7 @@ COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += omap1510_i2c.o COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += omap24xx_i2c.o COBJS-$(CONFIG_DRIVER_S3C24X0_I2C) += s3c24x0_i2c.o +COBJS-$(CONFIG_I2C_MV64xxx) += mv64xxx-i2c.o COBJS-$(CONFIG_S3C44B0_I2C) += s3c44b0_i2c.o COBJS-$(CONFIG_SOFT_I2C) += soft_i2c.o COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.odrivers/i2c/mv64xxx-i2c.c new file +18
-0@@ -0,0 +1,452 @@ +/* +* Driver for the i2c controller on the Marvell line of host bridges +* (e.g, gt642[46]0, mv643[46]0, mv644[46]0, and Orion SoC family). +* +* Based on: +* Author: Mark A. Greer <[email protected]> +* +* 2005 (c) MontaVista, Software, Inc. This file is licensed under +* the terms of the GNU General Public License version 2. This program +* is licensed "as is" without any warranty of any kind, whether express +* or implied. +* +* ported from Linux to u-boot +* (C) Copyright 2009 +* Heiko Schocher, DENX Software Engineering, hs at denx.de. +* +*/ +#include <common.h> drivers/i2c/mv64xxx-i2c.c line 28
Quoted 10 lines
drivers/i2c/mv64xxx-i2c.c new file +10
-0+#include <i2c.h> +#include <asm/arch/kirkwood.h> +#include <asm/errno.h> +#include <asm/io.h> + +DECLARE_GLOBAL_DATA_PTR ; + +static unsigned int i2c_bus_num __attribute__ ((section (".data"))) = 0; +#if defined(CONFIG_I2C_MUX ) +static unsigned int i2c_bus_num_mux __attribute__ ((section ("data"))) = 0;.data
Quoted 2 lines
drivers/i2c/mv64xxx-i2c.c line 29
Quoted 1 line
drivers/i2c/mv64xxx-i2c.c new file +1
-0+#endif no need of put it in section .data on arm
Hmm.. I am not an arm expert ...
Quoted 9 lines
Quoted 1 line
drivers/i2c/mv64xxx-i2c.c new file +1
-0+<snip>
drivers/i2c/mv64xxx-i2c.c line 385
Quoted 5 lines
drivers/i2c/mv64xxx-i2c.c new file +5
-0+ +void +i2c_init (int speed,int slaveadd) +{ +mv64xxx_i2c_hw_init ();impossible to specify a speed?
or update it at runtime?
This is configurable through the CONFIG_I2C_MV64xxx_FREQ_M and CONFIG_I2C_MV64xxx_FREQ_N defines. Hmm... I ported this more or less directly from Linux. But you are right, I looked in the CPU manual, it should be easy to calculate this two values, so I change this.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Dear Heiko Schocher,
Quoted 4 lines · In message <[email protected]> you wrote:
I don;t understand you here. You have a "CONFIG name convention cleanup" patch somewhere? Is this somewhere discussed, how this should look like? (I think, a "
CONFIG_DRIVER_I2C_xxx" would be good)
It never has been discussed or even mentioned before.
Jean-Christophe, I recommend you accept Heiko's patch as is (as it was submitted before your patch), and then just regenerate your patch (which is trivial for you to do as you have the script ready).
Quoted 8 lines
Quoted 6 lines
drivers/i2c/mv64xxx-i2c.c line 28
Quoted 3 lines
drivers/i2c/mv64xxx-i2c.c new file +3
-0+static unsigned int i2c_bus_num __attribute__ ((section (".data"))) = 0; +#if defined(CONFIG_I2C_MUX ) +static unsigned int i2c_bus_num_mux __attribute__ ((section ("data"))) = 0;.data
Quoted 1 line
+#endif
no need of put it in section .data on arm
Hmm.. I am not an arm expert ...
I disagree with Jean-Christophe here. Do not change this code.
Quoted 7 lines
Quoted 6 lines
drivers/i2c/mv64xxx-i2c.c line 385
Quoted 4 lines
drivers/i2c/mv64xxx-i2c.c new file +4
-0+void +i2c_init (int speed,int slaveadd) +{ +mv64xxx_i2c_hw_init ();impossible to specify a speed?
or update it at runtime?
Quoted 5 lines
This is configurable through the
CONFIG_I2C_MV64xxx_FREQ_MandCONFIG_I2C_MV64xxx_FREQ_Ndefines. Hmm... I ported this more or less directly from Linux. But you are right, I looked in the CPU manual, it should be easy to calculate this two values, so I change this.
Thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de How much net work could a network work, if a network could net work?
Hello Wolfgang,
Quoted 10 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:
I don;t understand you here. You have a "CONFIG name convention cleanup" patch somewhere? Is this somewhere discussed, how this should look like? (I think, a "
CONFIG_DRIVER_I2C_xxx" would be good)It never has been discussed or even mentioned before.
Jean-Christophe, I recommend you accept Heiko's patch as is (as it was submitted before your patch), and then just regenerate your patch (which is trivial for you to do as you have the script ready).
Hmm.. I have to fix some comments, which Prafulla suggested, also to integrate the speed settings ...
So I don;t know, if this patch should go in mainline as it is ... I think it is easier, if we integrate Jean-Christophes renaming patch (the reposted version with correct subject ;-) and then I can easy adapt "my" patch ...
Quoted 9 lines
Quoted 7 lines
Quoted 6 lines
drivers/i2c/mv64xxx-i2c.c line 28
Quoted 3 lines
drivers/i2c/mv64xxx-i2c.c new file +3
-0+static unsigned int i2c_bus_num __attribute__ ((section (".data"))) = 0; +#if defined(CONFIG_I2C_MUX ) +static unsigned int i2c_bus_num_mux __attribute__ ((section ("data"))) = 0;.data
Quoted 1 line
+#endif
no need of put it in section .data on arm
Hmm.. I am not an arm expert ...
I disagree with Jean-Christophe here. Do not change this code.
Ok. If Jean-Christophe accept it ...
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Dear Heiko Schocher,
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Jean-Christophe, I recommend you accept Heiko's patch as is (as it was submitted before your patch), and then just regenerate your patch (which is trivial for you to do as you have the script ready).
Quoted 7 lines
Hmm.. I have to fix some comments, which Prafulla suggested, also to integrate the speed settings ...
So I don;t know, if this patch should go in mainline as it is ... I think it is easier, if we integrate Jean-Christophes renaming patch (the reposted version with correct subject ;-) and then I can easy adapt "my" patch ...
Jean-Christophes renaming patch is at the very end of a prtty long queue. I would not wait that long.
Quoted 3 lines
Quoted 1 line
I disagree with Jean-Christophe here. Do not change this code.
Ok. If Jean-Christophe accept it ...
I asked him to accept it.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Fascinating is a word I use for the unexpected. -- Spock, "The Squire of Gothos", stardate 2124.5
Hello Wolfgang,
Quoted 9 lines · Wolfgang Denk
Dear Heiko Schocher,
Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 3 lines
Jean-Christophe, I recommend you accept Heiko's patch as is (as it was submitted before your patch), and then just regenerate your patch (which is trivial for you to do as you have the script ready).
Hmm.. I have to fix some comments, which Prafulla suggested, also to integrate the speed settings ...
Quoted 7 lines
Quoted 4 lines
So I don;t know, if this patch should go in mainline as it is ... I think it is easier, if we integrate Jean-Christophes renaming patch (the reposted version with correct subject ;-) and then I can easy adapt "my" patch ...
Jean-Christophes renaming patch is at the very end of a prtty long queue. I would not wait that long.
Ok. So I try to add the comments from Prafulla and Jean-Christophe and post a new version.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH v3 1/1 arm, i2c: added support for the TWSI I2C Interface
In reply to Jean-Christophe PLAGNIOL-VILLARD---
- changes since v1:
added comments from Prafulla Wadaskar
- changes since v2
added comments from Jean-Christophe
- added speed setting
drivers/i2c/Makefile | 1 + drivers/i2c/kirkwood_i2c.c | 484 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 485 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/kirkwood_i2c.c
drivers/i2c/Makefile +1 -0
@@ -28,6 +28,7 @@ LIB := $(obj)libi2c.a COBJS-$(CONFIG_BFIN_TWI_I2C) += bfin-twi_i2c.o COBJS-$(CONFIG_DRIVER_DAVINCI_I2C) += davinci_i2c.o COBJS-$(CONFIG_FSL_I2C) += fsl_i2c.o +COBJS-$(CONFIG_I2C_KIRKWOOD) += kirkwood_i2c.o COBJS-$(CONFIG_I2C_MXC) += mxc_i2c.o COBJS-$(CONFIG_DRIVER_OMAP1510_I2C) += omap1510_i2c.o COBJS-$(CONFIG_DRIVER_OMAP24XX_I2C) += omap24xx_i2c.o
drivers/i2c/kirkwood_i2c.c new file +484 -0
484 lines not on this page · raw message
Signature · 5 lines
1.6.0.GIT -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH v3 1/1 arm, i2c: added support for the TWSI I2C Interface
Quoted 8 lines · Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>---
- changes since v1:
added comments from Prafulla Wadaskar
- changes since v2
added comments from Jean-Christophe
- added speed setting
Quoted 5 lines
drivers/i2c/Makefile | 1 + drivers/i2c/kirkwood_i2c.c | 484 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 485 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/kirkwood_i2c.c
ok for me
Prafulla I guess it's ok for you too
Best Regards,
J.
PATCH v3 1/1 arm, i2c: added support for the TWSI I2C Interface
Quoted 19 lines
-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Thursday, July 23, 2009 3:17 AM
To: Heiko Schocher
Cc: Prafulla Wadaskar; U-Boot user list; Wolfgang Denk
Subject: Re: [PATCH v3] arm, i2c: added support for the TWSI I2C InterfaceQuoted 8 lines · Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>---
- changes since v1:
added comments from Prafulla Wadaskar
- changes since v2
added comments from Jean-Christophe
- added speed setting
Quoted 8 lines
Quoted 6 lines
drivers/i2c/Makefile | 1 + drivers/i2c/kirkwood_i2c.c | 484 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 485 insertions(+), 0 deletions(-) create mode100644
drivers/i2c/kirkwood_i2c.cok for me
Prafulla I guess it's ok for you too
Dear Jean,
Yes, it's okay for me too.
Regards..
Prafulla . .
Quoted 4 lines
Best Regards,
J.
Heiko Schocher
AppliedPATCH v3 1/1 arm, i2c: added support for the TWSI I2C Interface
In reply to Heiko SchocherHello Heiko,
Quoted 8 lines · Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>---
- changes since v1:
added comments from Prafulla Wadaskar
- changes since v2
added comments from Jean-Christophe
- added speed setting
Quoted 4 lines
drivers/i2c/Makefile | 1 + drivers/i2c/kirkwood_i2c.c | 484 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 485 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/kirkwood_i2c.c
Applied.
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany