Skip to contentSkip to conversation

libata: cosmetic updates

PATCH In review Tejun Heo 3 participants 3 messages Jul 21, 2009 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/2 libata: cosmetic updates

We're about to add more SATA_* and ATA_ACPI_FILTER_* constants. Reformat them in preparation.

---
 drivers/ata/libata-acpi.c |   12 ++++++------
 include/linux/ata.h       |    4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)
drivers/ata/libata-acpi.c +6 -6
Index: ata/drivers/ata/libata-acpi.c
===================================================================
@@ -21,13 +21,13 @@
 #include <acpi/acpi_bus.h>
 
 enum {
-	ATA_ACPI_FILTER_SETXFER	= 1 << 0,
-	ATA_ACPI_FILTER_LOCK	= 1 << 1,
-	ATA_ACPI_FILTER_DIPM	= 1 << 2,
+	ATA_ACPI_FILTER_SETXFER		= 1 << 0,
+	ATA_ACPI_FILTER_LOCK		= 1 << 1,
+	ATA_ACPI_FILTER_DIPM		= 1 << 2,
 
-	ATA_ACPI_FILTER_DEFAULT	= ATA_ACPI_FILTER_SETXFER |
-				  ATA_ACPI_FILTER_LOCK |
-				  ATA_ACPI_FILTER_DIPM,
+	ATA_ACPI_FILTER_DEFAULT		= ATA_ACPI_FILTER_SETXFER |
+					  ATA_ACPI_FILTER_LOCK |
+					  ATA_ACPI_FILTER_DIPM,
 };
 
 static unsigned int ata_acpi_gtf_filter = ATA_ACPI_FILTER_DEFAULT;
include/linux/ata.h +2 -2
Index: ata/include/linux/ata.h
===================================================================
@@ -304,8 +304,8 @@ enum {
 	SETFEATURES_SATA_DISABLE = 0x90, /* Disable use of SATA feature */
 
 	/* SETFEATURE Sector counts for SATA features */
-	SATA_AN			= 0x05,  /* Asynchronous Notification */
-	SATA_DIPM		= 0x03,  /* Device Initiated Power Management */
+	SATA_DIPM		= 0x03,	/* Device Initiated Power Management */
+	SATA_AN			= 0x05,	/* Asynchronous Notification */
 
 	/* feature values for SET_MAX */
 	ATA_SET_MAX_ADDR	= 0x00,
#1 lore raw
Quoted 4 lines · Tejun Heo

We're about to add more SATA_* and ATA_ACPI_FILTER_* constants. Reformat them in preparation.

I was about to send the second patch which filters out the offending commands by default but now that I think more about it I think it would be better to specifically blacklist the machine. So, please don't commit the first patch. I'll re-post later along with updated patch.

Thanks.

Signature · 1 line
tejun
#2 lore raw
Quoted 11 lines · Tejun Heo
Quoted 4 lines · Tejun Heo

We're about to add more SATA_* and ATA_ACPI_FILTER_* constants. Reformat them in preparation.

I was about to send the second patch which filters out the offending commands by default but now that I think more about it I think it would be better to specifically blacklist the machine. So, please don't commit the first patch. I'll re-post later along with updated patch.

Will do...