Skip to contentSkip to conversation

ARM: OMAP3: cm-t35: add EHCI support

PATCH In review Mike Rapoport 3 participants 3 messages Oct 14, 2009 – Oct 23, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP3: cm-t35: add EHCI support

This patch adds support for EHCI on CM-T35.
It depends on basic CM-T35 board support ([1]) and EHCI updates in the linux-omap tree.

[1] http://thread.gmane.org/gmane.linux.ports.arm.omap/24938
---

---
 arch/arm/mach-omap2/board-cm-t35.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-cm-t35.c +17 -0
index 94c1f35..1465892 100644
@@ -352,6 +352,17 @@ static struct twl4030_hsmmc_info mmc[] = {
 	{}	/* Terminator */
 };
 
+static struct ehci_hcd_omap_platform_data ehci_pdata = {
+	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
+	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
+	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
+
+	.phy_reset  = true,
+	.reset_gpio_port[0]  = -EINVAL,
+	.reset_gpio_port[1]  = -EINVAL,
+	.reset_gpio_port[2]  = -EINVAL
+};
+
 static int cm_t35_twl_gpio_setup(struct device *dev, unsigned gpio,
 				 unsigned ngpio)
 {
@@ -377,6 +388,12 @@ static int cm_t35_twl_gpio_setup(struct device *dev, unsigned gpio,
 	cm_t35_vmmc1_supply.dev = mmc[0].dev;
 	cm_t35_vsim_supply.dev = mmc[0].dev;
 
+	/* setup USB with proper PHY reset GPIOs */
+	ehci_pdata.reset_gpio_port[0] = gpio + 6;
+	ehci_pdata.reset_gpio_port[1] = gpio + 7;
+
+	usb_ehci_init(&ehci_pdata);
+
 	return 0;
 }
 
Signature · 6 lines
1.6.0.6


-- 
Sincerely yours,
Mike.
maintainer
#1 lore raw

PATCH 1/1 ARM: OMAP3: cm-t35: add EHCI support

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: ehci

Initial commit ID (Likely to change): 6a0dc193cf2e6055ffd9b1c34fa9f99e5836aabf

PatchWorks
http://patchwork.kernel.org/patch/53620/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=6a0dc193cf2e6055ffd9b1c34fa9f99e5836aabf

#2 lore raw
In reply to Mike Rapoport
Quoted 17 lines

This patch adds support for EHCI on CM-T35.
It depends on basic CM-T35 board support ([1]) and EHCI updates in the linux-omap tree.

[1] http://thread.gmane.org/gmane.linux.ports.arm.omap/24938
---

---
 arch/arm/mach-omap2/board-cm-t35.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-cm-t35.c +0 -0
index 94c1f35..1465892 100644

arch/arm/mach-omap2/board-cm-t35.c static struct twl4030_hsmmc_info mmc[] = { · line 359

Quoted 8 lines
arch/arm/mach-omap2/board-cm-t35.c +5 -0
@@ -352,6 +352,17 @@ static struct twl4030_hsmmc_info mmc[] = {
 	{}	/* Terminator */
 };
 
+static struct ehci_hcd_omap_platform_data ehci_pdata = {
+	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
+	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
+	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
+

I haven't been following l-o for a while - I just got back. Is there a link to some documentation for this board (I'm just curious about the EHCI connections)?

Are you using Port1 and Port2 both? What PHY is connected to the ports?

arch/arm/mach-omap2/board-cm-t35.c static struct twl4030_hsmmc_info mmc[] = { · line 363

Quoted 4 lines
arch/arm/mach-omap2/board-cm-t35.c +4 -0
+	.phy_reset  = true,
+	.reset_gpio_port[0]  = -EINVAL,
+	.reset_gpio_port[1]  = -EINVAL,
+	.reset_gpio_port[2]  = -EINVAL

You set these reset gpios below.
I guess you don't need to initialize them here.

- Anand

Quoted 27 lines
arch/arm/mach-omap2/board-cm-t35.c +8 -0
+};
+
 static int cm_t35_twl_gpio_setup(struct device *dev, unsigned gpio,
 				 unsigned ngpio)
 {
@@ -377,6 +388,12 @@ static int cm_t35_twl_gpio_setup(struct device *dev, unsigned gpio,
 	cm_t35_vmmc1_supply.dev = mmc[0].dev;
 	cm_t35_vsim_supply.dev = mmc[0].dev;
 
+	/* setup USB with proper PHY reset GPIOs */
+	ehci_pdata.reset_gpio_port[0] = gpio + 6;
+	ehci_pdata.reset_gpio_port[1] = gpio + 7;
+
+	usb_ehci_init(&ehci_pdata);
+
 	return 0;
 }
 
Signature · 6 lines
1.6.0.6


-- 
Sincerely yours,
Mike.