: libxenlight, domain resume
PATCH 9/14 : libxenlight, domain resume
Added libxenlight implementation for resume domain. This brings back a domain from the shutdown state after save, enabling checkpointing.
# HG changeset patch
# User Andres Lagar-Cavilla <[email protected]> # Date 1259261993 18000
# Node ID 4f6a83e7b25f8fb3dbdd683934b37a9807f47977 # Parent d8aa40229a93d66c097f058c77402a1180bbac94 Added libxenlight implementation for resume domain. This brings back a domain from the shutdown state after save, enabling checkpointing.
libxl.c +17 -0
@@ -251,6 +251,23 @@ int libxl_domain_restore(struct libxl_ctreturn 0 ; } +int libxl_domain_resume (struct libxl_ctx *ctx,uint32_t domid) +{ +if (xc_domain_resume (ctx->xch, domid,1 )) { +XL_LOG_ERRNO (ctx,XL_LOG_ERROR , +"xc_domain_resume failed for domain %u" , + domid); +return ERROR_FAIL ; + } +if (xs_resume_domain (ctx->xsh, domid)) { +XL_LOG_ERRNO (ctx,XL_LOG_ERROR , +"xs_resume_domain failed for domain %u" , + domid); +return ERROR_FAIL ; + } +return 0 ; +} +struct libxl_dominfo *libxl_domain_list (struct libxl_ctx *ctx,int *nb_domain) {struct libxl_dominfo *ptr;
libxl.h +1 -0
@@ -257,6 +257,7 @@ int libxl_domain_restore(struct libxl_ct uint32_t domid, int fd);int libxl_domain_suspend (struct libxl_ctx *ctx,libxl_domain_suspend_info *info,uint32_t domid,int fd); +int libxl_domain_resume (struct libxl_ctx *ctx,uint32_t domid);int libxl_domain_shutdown (struct libxl_ctx *ctx,uint32_t domid,int req);int libxl_domain_destroy (struct libxl_ctx *ctx,uint32_t domid,int force);
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 3 lines · Andres Lagar-Cavilla
Added libxenlight implementation for resume domain. This brings back a domain from the shutdown state after save, enabling checkpointing.
(I haven't looks at resume stuff for age ..)
I think this only works if the domain is cooperative, if it isn't you need to a callback in the middle of the calls to do devices related unplugging/plugging.
If that still true, I would prefer to have a
"if (pv)" around the code since pv are always suppose to be cooperative
Signature · 1 line
Vincent
I know little of hvm. I believe the *right* approach is to parse an elf note of the guest kernel. The hvm "kernel" is the hvmloader, so that would render hvm non-cooperative. The caller will have to provide the kernel path though, since we forget about it.
Andres
Quoted 15 lines · Vincent Hanquez
Quoted 4 lines · Andres Lagar-Cavilla
Added libxenlight implementation for resume domain. This brings back a domain from the shutdown state after save, enabling checkpointing.
(I haven't looks at resume stuff for age ..)
I think this only works if the domain is cooperative, if it isn't you need to a callback in the middle of the calls to do devices related unplugging/plugging.
If that still true, I would prefer to have a "if (pv)" around the code since pv are always suppose to be cooperative