Skip to contentSkip to conversation

wl1251: timeout one too soon in wl1251_boot_run_firmware()

PATCH In review Roel Kluin 2 participants 2 messages Dec 26, 2009 – Dec 27, 2009 Networking drivers (wireless)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 wl1251: timeout one too soon in wl1251_boot_run_firmware()

`loop' reaches INIT_LOOP + 1 after the loop. so if ACX_INTR_INIT_COMPLETE occurs in the last iteration the write occurs but also the error out as if a timeout occurred. This is probably very unlikely to ever occur.

---
 drivers/net/wireless/wl12xx/wl1251_boot.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/wl12xx/wl1251_boot.c +1 -1
index 2e733e7..28a8086 100644
@@ -256,7 +256,7 @@ int wl1251_boot_run_firmware(struct wl1251 *wl)
 		}
 	}
 
-	if (loop >= INIT_LOOP) {
+	if (loop > INIT_LOOP) {
 		wl1251_error("timeout waiting for the hardware to "
 			     "complete initialization");
 		return -EIO;
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Roel Kluin

`loop' reaches INIT_LOOP + 1 after the loop. so if ACX_INTR_INIT_COMPLETE occurs in the last iteration the write occurs but also the error out as if a timeout occurred. This is probably very unlikely to ever occur.

Thank you for fixing this.

Quoted 1 line

I think John can take this. As Roel mentioned, this is nothing critical and, if needed, can wait until 2.6.34.

Signature · 1 line
Kalle Valo