wl1251: timeout one too soon in wl1251_boot_run_firmware()
PATCH 1/1 wl1251: timeout one too soon in wl1251_boot_run_firmware()
`loop' reaches INIT_LOOP + 1 after the loop. so if ACX_INTR_INIT_COMPLETE occurs in the last iteration the write occurs but also the error out as if a timeout occurred. This is probably very unlikely to ever occur.
Signed-off-by Roel Kluin <[email protected]>
--- drivers/net/wireless/wl12xx/wl1251_boot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/wl12xx/wl1251_boot.c +1 -1
@@ -256,7 +256,7 @@ int wl1251_boot_run_firmware(struct wl1251 *wl) } } -if (loop >=INIT_LOOP ) { +if (loop >INIT_LOOP ) {wl1251_error ("timeout waiting for the hardware to " "complete initialization" );return -EIO ;
Quoted 3 lines · Roel Kluin
`loop' reaches
INIT_LOOP+ 1 after the loop. so ifACX_INTR_INIT_COMPLETEoccurs in the last iteration the write occurs but also the error out as if a timeout occurred. This is probably very unlikely to ever occur.
Thank you for fixing this.
Quoted 1 line
Signed-off-by Roel Kluin <[email protected]>
Acked-by Kalle Valo <[email protected]>
I think John can take this. As Roel mentioned, this is nothing critical and, if needed, can wait until 2.6.34.
Signature · 1 line
Kalle Valo