cpuset: alloc nodemask_t at heap not stack - fix
PATCH v2 2/2 cpuset: alloc nodemask_t at heap not stack - fix
Changes from V1 to V2:
- remove unnecessary checking.
fix memory leak
Signed-off-by Miao Xie <[email protected]>
---
Against the following patch in mmotm-2010-03-11-13-13:
cpuset-alloc-nodemask_t-at-heap-not-stack.patch
--- kernel/cpuset.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/cpuset.c +2 -1
@@ -1401,7 +1401,7 @@ static void cpuset_attach(struct cgroup_subsys *ss, struct cgroup *cont,NODEMASK_ALLOC (nodemask_t, to,GFP_KERNEL );if (from ==NULL || to ==NULL ) -return ; + goto alloc_fail;if (cs == &top_cpuset) {cpumask_copy (cpus_attach, cpu_possible_mask);
@@ -1432,6 +1432,7 @@ static void cpuset_attach(struct cgroup_subsys *ss, struct cgroup *cont,mmput (mm); } +alloc_fail:NODEMASK_FREE (from);NODEMASK_FREE (to); }
Signature · 1 line
1.6.5.2