s5pc1xx: Add support for Samsung Goni board

PATCH Superseded Minkyu Kang 3 participants 6 messages May 31, 2010 – Jun 2, 2010

Subsystems (2)

Kbuild Arm/actions semi architecture

lore

Share & tools

lore

Minkyu Kang

author

2010-05-31 00:59 UTC #0 lore raw

PATCH v2 1/1 s5pc1xx: Add support for Samsung Goni board

This patch adds support for the Samsung Goni board (S5PC110 SoC)

Signed-off-by Minkyu Kang <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
v2: remove workaround code, rebase the patch

 MAINTAINERS                        |    1 +
 MAKEALL                            |    1 +
 Makefile                           |    3 +
 board/samsung/goni/Makefile        |   54 ++++
 board/samsung/goni/config.mk       |   16 +
 board/samsung/goni/goni.c          |   55 ++++
 board/samsung/goni/lowlevel_init.S |  585 ++++++++++++++++++++++++++++++++++++
 board/samsung/goni/mem_setup.S     |  265 ++++++++++++++++
 board/samsung/goni/onenand.c       |   36 +++
 include/configs/s5p_goni.h         |  241 +++++++++++++++
 10 files changed, 1257 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/goni/Makefile
 create mode 100644 board/samsung/goni/config.mk
 create mode 100644 board/samsung/goni/goni.c
 create mode 100644 board/samsung/goni/lowlevel_init.S
 create mode 100644 board/samsung/goni/mem_setup.S
 create mode 100644 board/samsung/goni/onenand.c
 create mode 100644 include/configs/s5p_goni.h

MAINTAINERS +1 -0

index 5cbc845..69a1357 100644
@@ -628,6 +628,7 @@ Simon Kagstrom <[email protected]>
 
 Minkyu Kang <[email protected]>
 
+	s5p_goni	ARM CORTEX-A8 (S5PC110 SoC)
 	SMDKC100	ARM CORTEX-A8 (S5PC100 SoC)
 
 Nishant Kamat <[email protected]>

MAKEALL +1 -0

index bb09627..3723c46 100755
@@ -650,6 +650,7 @@ LIST_ARM_CORTEX_A8="		\
 	omap3_sdp3430		\
 	omap3_zoom1		\
 	omap3_zoom2		\
+	s5p_goni		\
 	smdkc100		\
 "

Makefile +3 -0

index 686e6fb..9174b24 100644
@@ -3179,6 +3179,9 @@ omap3_zoom1_config :	unconfig
 omap3_zoom2_config :	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
 
+s5p_goni_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 goni samsung s5pc1xx
+
 smdkc100_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx

board/samsung/goni/Makefile new file +54 -0

54 lines not on this page · raw message

board/samsung/goni/config.mk new file +16 -0

new file mode 100644
index 0000000..2da9ca1
@@ -0,0 +1,16 @@
+#
+# Copyright (C) 2008 # Samsung Elecgtronics
+# Kyungmin Park <[email protected]>
+#
+
+# On S5PC100 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x38000000 to 0x40000000 (128MiB)
+#
+# On S5PC110 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x40000000 to 0x50000000 (256MiB)
+#
+TEXT_BASE = 0x34800000

board/samsung/goni/goni.c new file +55 -0

55 lines not on this page · raw message

board/samsung/goni/lowlevel_init.S new file +585 -0

585 lines not on this page · raw message

board/samsung/goni/mem_setup.S new file +265 -0

265 lines not on this page · raw message

board/samsung/goni/onenand.c new file +36 -0

new file mode 100644
index 0000000..8d3769b
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2008-2009 Samsung Electronics
+ * Kyungmin Park <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/onenand.h>
+#include <linux/mtd/samsung_onenand.h>
+#include <onenand_uboot.h>
+
+void onenand_board_init(struct mtd_info *mtd)
+{
+	struct onenand_chip *this = mtd->priv;
+
+	this->base = (void *)CONFIG_SYS_ONENAND_BASE;
+	this->options |= ONENAND_RUNTIME_BADBLOCK_CHECK;
+}

include/configs/s5p_goni.h new file +241 -0

241 lines not on this page · raw message

Signature · 1 line

1.6.3.3

Wolfgang Denk

2010-05-31 10:38 UTC #1 lore raw

PATCH v2 1/1 s5pc1xx: Add support for Samsung Goni board

Dear Minkyu Kang,

Quoted 8 lines · In message <[email protected]> you wrote:

This patch adds support for the Samsung Goni board (S5PC110 SoC)
Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

MAINTAINERS Simon Kagstrom <[email protected]> · line 634

Quoted 7 lines

MAINTAINERS +1 -0

@@ -628,6 +628,7 @@ Simon Kagstrom <[email protected]>
 
 Minkyu Kang <[email protected]>
 
+	s5p_goni	ARM CORTEX-A8 (S5PC110 SoC)
 	SMDKC100	ARM CORTEX-A8 (S5PC100 SoC)
 
 Nishant Kamat <[email protected]>

Please keep lists sorted (kang > Kamat).

...

MAINTAINERS

Quoted 4 lines

MAINTAINERS +4 -0

+#ifdef CONFIG_DISPLAY_BOARDINFO
+int checkboard(void)
+{
+	printf("Board:\tGoni\n");

Please consider using puts() when you don't do any print formatting.

board/samsung/goni/lowlevel_init.S line 2

Quoted 6 lines

index 0000000..4b72992
board/samsung/goni/lowlevel_init.S new file +2 -0
@@ -0,0 +1,585 @@
+/*
+ * Memory Setup stuff - taken from blob memsetup.S

Is it really necessary to code all this in assembler?

board/samsung/goni/lowlevel_init.S line 534

Quoted 4 lines

board/samsung/goni/lowlevel_init.S new file +4 -0
+/*
+ * uart_asm_init: Initialize UART's pins
+ */
+uart_asm_init:

For example, why cannot this be part of the UART driver and written in C instead?

Quoted 3 lines

index 0000000..6239444
include/configs/s5p_goni.h new file +0 -0

...

Quoted 6 lines

include/configs/s5p_goni.h new file +6 -0

+#undef CONFIG_CMD_BOOTD
+#undef CONFIG_CMD_CONSOLE
+#undef CONFIG_CMD_ECHO
+#undef CONFIG_CMD_FPGA
+#undef CONFIG_CMD_ITEST
+#undef CONFIG_CMD_FLASH

include/configs/s5p_goni.h line 95

Quoted 10 lines

include/configs/s5p_goni.h new file +10 -0

+#undef CONFIG_CMD_IMLS
+#undef CONFIG_CMD_LOADB
+#undef CONFIG_CMD_LOADS
+#undef CONFIG_CMD_NAND
+#undef CONFIG_CMD_MISC
+#undef CONFIG_CMD_NFS
+#undef CONFIG_CMD_SOURCE
+#undef CONFIG_CMD_XIMG
+#undef CONFIG_CMD_NET
+#undef CONFIG_XYZMODEM

Many of these commands are pretty useful to the end user. Is there a special reason for disabling these here? It seems you are not especially restricted in terms of resources, so I don't understand why you disable these.

Quoted 5 lines

+/*-----------------------------------------------------------------------
+ * Stack sizes
+ *
+ * The stack sizes are set up in start.S using the settings below
+ */

Incorrect multiline comment style; please fix globally.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...and the fully armed nuclear warheads, are, of  course,  merely  a
courtesy detail."

Minkyu Kang

2010-05-31 12:24 UTC #2 lore raw

PATCH v2 1/1 s5pc1xx: Add support for Samsung Goni board

Dear Wolfgang,

Quoted 12 lines · Wolfgang Denk

Dear Minkyu Kang,
Quoted 9 lines · In message <[email protected]> you wrote:
This patch adds support for the Samsung Goni board (S5PC110 SoC)
Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
MAINTAINERS +0 -0
@@ -628,6 +628,7 @@ Simon Kagstrom <[email protected]>
 

Quoted 8 lines

Quoted 6 lines
?Minkyu Kang <[email protected]>
+ ? ? s5p_goni ? ? ? ?ARM CORTEX-A8 (S5PC110 SoC)
? ? ? SMDKC100 ? ? ? ?ARM CORTEX-A8 (S5PC100 SoC)
?Nishant Kamat <[email protected]>
Please keep lists sorted (kang > Kamat).

I'll fix it.

Quoted 8 lines

...
MAINTAINERS
Quoted 4 lines
MAINTAINERS +4 -0
+#ifdef CONFIG_DISPLAY_BOARDINFO
+int checkboard(void)
+{
+ ? ? printf("Board:\tGoni\n");
Please consider using puts() when you don't do any print formatting.

OK.

Quoted 10 lines

board/samsung/goni/lowlevel_init.S line 2
Quoted 7 lines
index 0000000..4b72992
board/samsung/goni/lowlevel_init.S new file +2 -0
@@ -0,0 +1,585 @@
+/*
+ * Memory Setup stuff - taken from blob memsetup.S
Is it really necessary to code all this in assembler?

Quoted 7 lines

board/samsung/goni/lowlevel_init.S line 534
Quoted 4 lines
board/samsung/goni/lowlevel_init.S new file +4 -0
+/*
+ * uart_asm_init: Initialize UART's pins
+ */
+uart_asm_init:
For example, why cannot this be part of the UART driver and written in C instead?

UART setting is possible to write the C code,
but sometimes it is useful for debugging before jump the C codes.

Quoted 17 lines

Quoted 3 lines

index 0000000..6239444
include/configs/s5p_goni.h new file +0 -0

...

Quoted 13 lines

include/configs/s5p_goni.h new file +13 -0

+#undef CONFIG_CMD_BOOTD
+#undef CONFIG_CMD_CONSOLE
+#undef CONFIG_CMD_ECHO
+#undef CONFIG_CMD_FPGA
+#undef CONFIG_CMD_ITEST
+#undef CONFIG_CMD_FLASH
+#undef CONFIG_CMD_IMLS
+#undef CONFIG_CMD_LOADB
+#undef CONFIG_CMD_LOADS
+#undef CONFIG_CMD_NAND
+#undef CONFIG_CMD_MISC
+#undef CONFIG_CMD_NFS
+#undef CONFIG_CMD_SOURCE

Quoted 8 lines

include/configs/s5p_goni.h line 95
Quoted 3 lines
include/configs/s5p_goni.h new file +3 -0
+#undef CONFIG_CMD_XIMG
+#undef CONFIG_CMD_NET
+#undef CONFIG_XYZMODEM
Many of these commands are pretty useful to the end user. Is there a special reason for disabling these here? It seems you are not especially restricted in terms of resources, so I don't understand why you disable these.

Goni doesn't have NOR flash, NAND flash and Network device. So, I disabled about flash, nand and network commands. Others are for reducing image size. (about 10KiB) Anyway, I'll enable some useful commands.

Quoted 8 lines

Quoted 6 lines
+/*-----------------------------------------------------------------------
+ * Stack sizes
+ *
+ * The stack sizes are set up in start.S using the settings below
+ */
Incorrect multiline comment style; please fix globally.

OK.

Quoted 6 lines

Best regards,
Wolfgang Denk

Quoted 11 lines

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "...and the fully armed nuclear warheads, are, of ?course, ?merely ?a courtesy detail."
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks.
Minkyu Kang

Signature · 2 lines

from. prom.
www.promsoft.net

Wolfgang Denk

2010-05-31 12:40 UTC #3 lore raw

PATCH v2 1/1 s5pc1xx: Add support for Samsung Goni board

Dear Minkyu Kang,

Quoted 1 line · In message <[email protected]> you…

...

Quoted 26 lines

Quoted 17 lines
Quoted 3 lines
index 0000000..6239444
include/configs/s5p_goni.h new file +0 -0
...
Quoted 13 lines
include/configs/s5p_goni.h new file +13 -0
+#undef CONFIG_CMD_BOOTD
+#undef CONFIG_CMD_CONSOLE
+#undef CONFIG_CMD_ECHO
+#undef CONFIG_CMD_FPGA
+#undef CONFIG_CMD_ITEST
+#undef CONFIG_CMD_FLASH
+#undef CONFIG_CMD_IMLS
+#undef CONFIG_CMD_LOADB
+#undef CONFIG_CMD_LOADS
+#undef CONFIG_CMD_NAND
+#undef CONFIG_CMD_MISC
+#undef CONFIG_CMD_NFS
+#undef CONFIG_CMD_SOURCE
Quoted 8 lines
include/configs/s5p_goni.h line 95
Quoted 3 lines
include/configs/s5p_goni.h new file +3 -0
+#undef CONFIG_CMD_XIMG
+#undef CONFIG_CMD_NET
+#undef CONFIG_XYZMODEM
Many of these commands are pretty useful to the end user. Is there a special reason for disabling these here? It seems you are not especially restricted in terms of resources, so I don't understand why you disable these.

Quoted 4 lines

Goni doesn't have NOR flash, NAND flash and Network device. So, I disabled about flash, nand and network commands. Others are for reducing image size. (about 10KiB) Anyway, I'll enable some useful commands.

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Speculation is always more interesting than facts.
                                    - Terry Pratchett, _Making_Money_

Minkyu Kang

author

2010-05-31 13:09 UTC #4 lore raw

PATCH v3 1/1 s5pc1xx: Add support for Samsung Goni board

This patch adds support for the Samsung Goni board (S5PC110 SoC)

Signed-off-by Minkyu Kang <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
v3: sort the Maintainer list, enable commands, fix comments
v2: remove workaround code, rebase the patch

 MAINTAINERS                        |    9 +-
 MAKEALL                            |    1 +
 Makefile                           |    3 +
 board/samsung/goni/Makefile        |   54 ++++
 board/samsung/goni/config.mk       |   16 +
 board/samsung/goni/goni.c          |   55 ++++
 board/samsung/goni/lowlevel_init.S |  585 ++++++++++++++++++++++++++++++++++++
 board/samsung/goni/mem_setup.S     |  265 ++++++++++++++++
 board/samsung/goni/onenand.c       |   36 +++
 include/configs/s5p_goni.h         |  217 +++++++++++++
 10 files changed, 1237 insertions(+), 4 deletions(-)
 create mode 100644 board/samsung/goni/Makefile
 create mode 100644 board/samsung/goni/config.mk
 create mode 100644 board/samsung/goni/goni.c
 create mode 100644 board/samsung/goni/lowlevel_init.S
 create mode 100644 board/samsung/goni/mem_setup.S
 create mode 100644 board/samsung/goni/onenand.c
 create mode 100644 include/configs/s5p_goni.h

MAINTAINERS +5 -4

index 5cbc845..c690697 100644
@@ -626,14 +626,15 @@ Simon Kagstrom <[email protected]>
 
        openrd_base     ARM926EJS (Kirkwood SoC)
 
-Minkyu Kang <[email protected]>
-
-	SMDKC100	ARM CORTEX-A8 (S5PC100 SoC)
-
 Nishant Kamat <[email protected]>
 
 	omap1610h2	ARM926EJS
 
+Minkyu Kang <[email protected]>
+
+	s5p_goni	ARM CORTEX-A8 (S5PC110 SoC)
+	SMDKC100	ARM CORTEX-A8 (S5PC100 SoC)
+
 Frederik Kriewitz <[email protected]>
 
 	devkit8000	ARM CORTEX-A8 (OMAP3530 SoC)

MAKEALL +1 -0

index bb09627..3723c46 100755
@@ -650,6 +650,7 @@ LIST_ARM_CORTEX_A8="		\
 	omap3_sdp3430		\
 	omap3_zoom1		\
 	omap3_zoom2		\
+	s5p_goni		\
 	smdkc100		\
 "

Makefile +3 -0

index 686e6fb..9174b24 100644
@@ -3179,6 +3179,9 @@ omap3_zoom1_config :	unconfig
 omap3_zoom2_config :	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
 
+s5p_goni_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 goni samsung s5pc1xx
+
 smdkc100_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx

board/samsung/goni/Makefile new file +54 -0

54 lines not on this page · raw message

board/samsung/goni/config.mk new file +16 -0

new file mode 100644
index 0000000..2da9ca1
@@ -0,0 +1,16 @@
+#
+# Copyright (C) 2008 # Samsung Elecgtronics
+# Kyungmin Park <[email protected]>
+#
+
+# On S5PC100 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x38000000 to 0x40000000 (128MiB)
+#
+# On S5PC110 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x40000000 to 0x50000000 (256MiB)
+#
+TEXT_BASE = 0x34800000

board/samsung/goni/goni.c new file +55 -0

55 lines not on this page · raw message

board/samsung/goni/lowlevel_init.S new file +585 -0

585 lines not on this page · raw message

board/samsung/goni/mem_setup.S new file +265 -0

265 lines not on this page · raw message

board/samsung/goni/onenand.c new file +36 -0

new file mode 100644
index 0000000..8d3769b
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2008-2009 Samsung Electronics
+ * Kyungmin Park <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/onenand.h>
+#include <linux/mtd/samsung_onenand.h>
+#include <onenand_uboot.h>
+
+void onenand_board_init(struct mtd_info *mtd)
+{
+	struct onenand_chip *this = mtd->priv;
+
+	this->base = (void *)CONFIG_SYS_ONENAND_BASE;
+	this->options |= ONENAND_RUNTIME_BADBLOCK_CHECK;
+}

include/configs/s5p_goni.h new file +217 -0

217 lines not on this page · raw message

Signature · 1 line

1.6.3.3

Minkyu Kang

2010-06-02 23:49 UTC #5 lore raw

PATCH v3 1/1 s5pc1xx: Add support for Samsung Goni board

Quoted 18 lines · Minkyu Kang

This patch adds support for the Samsung Goni board (S5PC110 SoC)
Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
v3: sort the Maintainer list, enable commands, fix comments
v2: remove workaround code, rebase the patch
?MAINTAINERS ? ? ? ? ? ? ? ? ? ? ? ?| ? ?9 +-
?MAKEALL ? ? ? ? ? ? ? ? ? ? ? ? ? ?| ? ?1 +
?Makefile ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ?3 +
?board/samsung/goni/Makefile ? ? ? ?| ? 54 ++++
?board/samsung/goni/config.mk ? ? ? | ? 16 +
?board/samsung/goni/goni.c ? ? ? ? ?| ? 55 ++++
?board/samsung/goni/lowlevel_init.S | ?585 ++++++++++++++++++++++++++++++++++++
?board/samsung/goni/mem_setup.S ? ? | ?265 ++++++++++++++++
?board/samsung/goni/onenand.c ? ? ? | ? 36 +++
?include/configs/s5p_goni.h ? ? ? ? | ?217 +++++++++++++

Quoted 9 lines

?10 files changed, 1237 insertions(+), 4 deletions(-) ?create mode 100644 board/samsung/goni/Makefile ?create mode 100644 board/samsung/goni/config.mk ?create mode 100644 board/samsung/goni/goni.c ?create mode 100644 board/samsung/goni/lowlevel_init.S ?create mode 100644 board/samsung/goni/mem_setup.S ?create mode 100644 board/samsung/goni/onenand.c ?create mode 100644 include/configs/s5p_goni.h

Applied to u-boot-samsung.

Minkyu Kang

Signature · 2 lines

from. prom.
www.promsoft.net