Skip to contentSkip to conversation

pch_gbe driver: The wrong of initializer entry

PATCH Applied Toshiharu Okada 2 participants 4 messages Nov 22, 2010 – Nov 29, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 pch_gbe driver: The wrong of initializer entry

The wrong of initializer entry was modified.

---
 drivers/net/pch_gbe/pch_gbe_param.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/pch_gbe/pch_gbe_param.c +4 -4
index 2510146..ef0996a 100644
@@ -434,8 +434,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
 			.err  = "using default of "
 				__MODULE_STRING(PCH_GBE_DEFAULT_TXD),
 			.def  = PCH_GBE_DEFAULT_TXD,
-			.arg  = { .r = { .min = PCH_GBE_MIN_TXD } },
-			.arg  = { .r = { .max = PCH_GBE_MAX_TXD } }
+			.arg  = { .r = { .min = PCH_GBE_MIN_TXD,
+					 .max = PCH_GBE_MAX_TXD } }
 		};
 		struct pch_gbe_tx_ring *tx_ring = adapter->tx_ring;
 		tx_ring->count = TxDescriptors;
@@ -450,8 +450,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
 			.err  = "using default of "
 				__MODULE_STRING(PCH_GBE_DEFAULT_RXD),
 			.def  = PCH_GBE_DEFAULT_RXD,
-			.arg  = { .r = { .min = PCH_GBE_MIN_RXD } },
-			.arg  = { .r = { .max = PCH_GBE_MAX_RXD } }
+			.arg  = { .r = { .min = PCH_GBE_MIN_RXD,
+					 .max = PCH_GBE_MAX_RXD } }
 		};
 		struct pch_gbe_rx_ring *rx_ring = adapter->rx_ring;
 		rx_ring->count = RxDescriptors;
Signature · 1 line
1.6.2.5
#2 lore raw

Hi David Miller

Date: Sat, 27 Nov 2010 17:41:03 -0800 (PST)
From: "David Miller" <[email protected]>

Quoted 7 lines
Quoted 4 lines

The wrong of initializer entry was modified.

How about you give some credit to David Alan Gilbert who made you aware of this issue?

Credit?
Does this mean that I add "Singed of by: Dr. David Alan Gilbert <[email protected]>" ?
Is my understanding correct?

Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)

maintainer
#3 lore raw

From: "Toshiharu Okada" <[email protected]>
Date: Mon, 29 Nov 2010 14:06:23 +0900

Quoted 10 lines

Hi David Miller

Date: Sat, 27 Nov 2010 17:41:03 -0800 (PST)
From: "David Miller" <[email protected]>

Quoted 5 lines
Quoted 4 lines

The wrong of initializer entry was modified.

Quoted 7 lines
Quoted 2 lines

How about you give some credit to David Alan Gilbert who made you aware of this issue?

Credit?
Does this mean that I add "Singed of by: Dr. David Alan Gilbert <[email protected]>" ?
Is my understanding correct?

You should use "Reported-by: ..."