Skip to contentSkip to conversation

fatfs: fix utf8 iocharset warning message

PATCH New Mihai Moldovan 1 participant 1 message Jul 25, 2011 VFAT/FAT/msdos filesystem

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fatfs: fix utf8 iocharset warning message

The fat_msg function already formats the given message and appends a newline to it - we don't need to do this in the passed message string as well, or will end up with a blank line printed in the kernel log ring buffer.

Also change the loglevel from error to warning.

---
 fs/fat/inode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/fat/inode.c +0 -0
index 5942fec..6dbab1b 100644
@@ -1188,9 +1188,9 @@ static int parse_options(struct super_block *sb,

char *options, int is_vfat,
out:
/* UTF-8 doesn't provide FAT semantics */
if (!strcmp(opts->iocharset, "utf8")) {
- fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"
+ fat_msg(sb, KERN_WARNING, "utf8 is not a recommended IO charset"
" for FAT filesystems, filesystem will be "
- "case sensitive!\n");
+ "case sensitive!");
}

/* If user doesn't specify allow_utime, it's initialized from dmask. */

Signature · 1 line
1.7.6