Skip to contentSkip to conversation

NULL base_name for hwaddr env lookup

U-Boot stany MARCEL 2 participants 3 messages Sep 5, 2011

lore
Share & tools
lore
#0 lore raw

in net/eth.c there is this function call with test:

if (eth_write_hwaddr(dev, NULL, eth_number))

If I understand correctly this test will always be true as NULL is used.

I think it should be "eth" instead of NULL.

Am I wrong ?

If not I can submit a patch.

Regards,

Stany

#1 lore raw
Quoted 12 lines · stany MARCEL

in net/eth.c there is this function call with test:

?if (eth_write_hwaddr(dev, NULL, eth_number))

If I understand correctly this test will always be true as NULL is used.

I think it should be "eth" instead of NULL.

Am I wrong ?

If not I can submit a patch.

Quoted 8 lines

Regards,

Stany
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Ok it's corrected by a commit few minutes ago.

#2 lore raw
In reply to stany MARCEL

Hello MARCEL,

Quoted 9 lines · stany MARCEL

in net/eth.c there is this function call with test:

if (eth_write_hwaddr(dev, NULL, eth_number))

If I understand correctly this test will always be true as NULL is used.

I think it should be "eth" instead of NULL.

Am I wrong ?

No.

Quoted 1 line

If not I can submit a patch.

See fix for this issue here:

http://patchwork.ozlabs.org/patch/112361/

bye,
Heiko