Skip to contentSkip to conversation

NTFS: remove references to long gone super operations

PATCH In review Fernando Luis Vazquez Cao 2 participants 3 messages Jul 4, 2012

Subsystems (2)
VFS NTFS filesystem
lore
Share & tools
lore

Fernando Luis Vazquez Cao

author
#0 lore raw

PATCH 1/1 NTFS: remove references to long gone super operations

Subject: NTFS: remove references to long gone super operations

From: Fernando Luis Vazquez Cao <[email protected]>

->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove refereces to them in the NTFS code. Noticed while cleaning up the fsfreeze mess.

Signed-off-by Fernando Luis Vazquez Cao <[email protected]>

---

fs/ntfs/super.c +0 -5
diff -urNp linux-3.5-rc5-orig/fs/ntfs/super.c linux-3.5-rc5/fs/ntfs/super.c
@@ -2670,14 +2670,9 @@ static const struct super_operations ntf
 	//					   NOTE: The inode lock is
 	//					   held. See fs/inode.c::
 	//					   generic_drop_inode(). */
-	//.delete_inode	= NULL,			/* VFS: Delete inode from disk.
-	//					   Called when i_count becomes
-	//					   0 and i_nlink is also 0. */
 	//.write_super	= NULL,			/* Flush dirty super block to
 	//					   disk. */
 	//.sync_fs	= NULL,			/* ? */
-	//.write_super_lockfs	= NULL,		/* ? */
-	//.unlockfs	= NULL,			/* ? */
 #endif /* NTFS_RW */
 	.put_super	= ntfs_put_super,	/* Syscall: umount. */
 	.statfs		= ntfs_statfs,		/* Syscall: statfs */

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Linux-NTFS-Dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-ntfs-dev

#1 lore raw
Quoted 9 lines · Fernando Luis Vazquez Cao

Subject: NTFS: remove references to long gone super operations

From: Fernando Luis Vazquez Cao <[email protected]>

->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove refereces to them in the NTFS code. Noticed while cleaning up the fsfreeze mess.

How about removing all the long comments about unimplemented operations? No major filesystem does this and there's no real point either.

author
#2 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 7 lines · Fernando Luis Vazquez Cao

Subject: NTFS: remove references to long gone super operations

From: Fernando Luis Vazquez Cao <[email protected]>

->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove refereces to them in the NTFS code. Noticed while cleaning up the fsfreeze mess.

How about removing all the long comments about unimplemented operations? No major filesystem does this and there's no real point either.

Good point. Updated patch attached.

Subject: NTFS: remove references to long gone super operations and unimplemented methods

From: Fernando Luis Vazquez Cao <[email protected]>

->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove refereces to them in the NTFS code. Remove unnecessary comments about unimplemented methods while at it (suggested by Christoph Hellwig).

Noticed while cleaning up the fsfreeze mess.

Signed-off-by Fernando Luis Vazquez Cao <[email protected]>

---

fs/ntfs/super.c +0 -17
diff -urNp linux-3.5-rc5-orig/fs/ntfs/super.c linux-3.5-rc5/fs/ntfs/super.c
@@ -2660,31 +2660,14 @@ static const struct super_operations ntf
 	.alloc_inode	= ntfs_alloc_big_inode,	  /* VFS: Allocate new inode. */
 	.destroy_inode	= ntfs_destroy_big_inode, /* VFS: Deallocate inode. */
 #ifdef NTFS_RW
-	//.dirty_inode	= NULL,			/* VFS: Called from
-	//					   __mark_inode_dirty(). */
 	.write_inode	= ntfs_write_inode,	/* VFS: Write dirty inode to
 						   disk. */
-	//.drop_inode	= NULL,			/* VFS: Called just after the
-	//					   inode reference count has
-	//					   been decreased to zero.
-	//					   NOTE: The inode lock is
-	//					   held. See fs/inode.c::
-	//					   generic_drop_inode(). */
-	//.delete_inode	= NULL,			/* VFS: Delete inode from disk.
-	//					   Called when i_count becomes
-	//					   0 and i_nlink is also 0. */
-	//.write_super	= NULL,			/* Flush dirty super block to
-	//					   disk. */
-	//.sync_fs	= NULL,			/* ? */
-	//.write_super_lockfs	= NULL,		/* ? */
-	//.unlockfs	= NULL,			/* ? */
 #endif /* NTFS_RW */
 	.put_super	= ntfs_put_super,	/* Syscall: umount. */
 	.statfs		= ntfs_statfs,		/* Syscall: statfs */
 	.remount_fs	= ntfs_remount,		/* Syscall: mount -o remount. */
 	.evict_inode	= ntfs_evict_big_inode,	/* VFS: Called when an inode is
 						   removed from memory. */
-	//.umount_begin	= NULL,			/* Forced umount. */
 	.show_options	= ntfs_show_options,	/* Show mount options in
 						   proc. */
 };