Skip to contentSkip to conversation

randconfig errors

DISCUSSION Rob Herring 10 participants 16 messages Feb 15, 2013 – Feb 22, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

Rob

/var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/kernel/arch_timer.c:55:11: error: 'ENXIO' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:118:19: error: redefinition of 'soc_is_omap' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:184:1: error: redefinition of 'is_omap24xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:185:1: error: redefinition of 'is_omap34xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:186:1: error: redefinition of 'is_omap44xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:187:1: error: redefinition of 'is_am35xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:188:1: error: redefinition of 'is_omap54xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:189:1: error: redefinition of 'is_am33xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:191:1: error: redefinition of 'is_ti81xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:193:1: error: redefinition of 'is_omap242x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:194:1: error: redefinition of 'is_omap243x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:195:1: error: redefinition of 'is_omap343x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:196:1: error: redefinition of 'is_omap363x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:197:1: error: redefinition of 'is_omap443x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:198:1: error: redefinition of 'is_omap446x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:199:1: error: redefinition of 'is_omap447x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:200:1: error: redefinition of 'is_omap543x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:202:1: error: redefinition of 'is_ti816x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:203:1: error: redefinition of 'is_ti814x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:204:1: error: redefinition of 'is_am335x' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:283:1: error: redefinition of 'is_omap2420' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:284:1: error: redefinition of 'is_omap2422' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:285:1: error: redefinition of 'is_omap2423' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:286:1: error: redefinition of 'is_omap2430' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:287:1: error: redefinition of 'is_omap3430' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:456:1: error: redefinition of 'omap3_has_l2cache' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:457:1: error: redefinition of 'omap3_has_sgx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:458:1: error: redefinition of 'omap3_has_iva' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:459:1: error: redefinition of 'omap3_has_neon' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:460:1: error: redefinition of 'omap3_has_isp' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:461:1: error: redefinition of 'omap3_has_192mhz_clk' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:462:1: error: redefinition of 'omap3_has_io_wakeup' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:463:1: error: redefinition of 'omap3_has_sdrc' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:464:1: error: redefinition of 'omap3_has_io_chain_ctrl' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:475:1: error: redefinition of 'omap4_has_perf_silicon' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-aes.c:363:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-sham.c:1707:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/gpu/drm/drm_pci.c:485:2: error: implicit declaration of function 'pcie_capability_read_dword' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:21:5: error: redefinition of 'st_sensors_allocate_trigger' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:65:6: error: redefinition of 'st_sensors_deallocate_trigger' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:176:3: error: implicit declaration of function 'iio_push_to_buffers' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:106:36: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:109:21: error: variable 'inv_mpu_trigger_ops' has initializer but incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:110:2: error: unknown field 'owner' specified in initializer /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:111:2: error: unknown field 'set_trigger_state' specified in initializer /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:119:2: error: implicit declaration of function 'iio_trigger_alloc' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:126:38: error: 'iio_trigger_generic_data_rdy_poll' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:132:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:133:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:134:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:135:2: error: implicit declaration of function 'iio_trigger_register' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:145:2: error: implicit declaration of function 'iio_trigger_free' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:152:2: error: implicit declaration of function 'iio_trigger_unregister' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/industrialio-triggered-buffer.c:20:16: error: 'iio_sw_buffer_preenable' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/media/platform/davinci/vpss.c:28:27: fatal error: mach/hardware.h: No such file or directory /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/remoteproc/omap_remoteproc.c:31:26: fatal error: plat/mailbox.h: No such file or directory /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2712:47: error: 'CONFIG_SERIAL_8250_NR_UARTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2971:20: error: negative width in bit-field '<anonymous>' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:57:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/omap-serial.c:1185:14: error: 'struct uart_port' has no member named 'sysrq' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/usb/host/uhci-hcd.c:857:2: error: #error "missing bus glue for uhci-hcd" /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/security/integrity/ima/ima_policy.c:538:4: error: implicit declaration of function 'part_pack_uuid' [-Werror=implicit-function-declaration]

#1 lore raw
Quoted 3 lines · Rob Herring

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

I have seen some of these before with the allyesconfig builds. Investigating randconfig is on my list for next week.

Quoted 8 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/kernel/arch_timer.c:55:11: error: 'ENXIO' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:118:19: error: redefinition of 'soc_is_omap' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:184:1: error: redefinition of 'is_omap24xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:185:1: error: redefinition of 'is_omap34xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:186:1: error: redefinition of 'is_omap44xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:187:1: error: redefinition of 'is_am35xx'

Patch is queued in arm-soc now.

Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function)

I've seen this one with allyesconfig but have not tried to make a fix

Quoted 2 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-aes.c:363:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-sham.c:1707:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration]

These are waiting for a patch from Matt Porter, "[PATCH v7 07/10] dmaengine: add dma_request_slave_channel_compat()". Matt, what is your plan for this? I assume it's too late to get the entire series into 3.9, but you have Vinod's Ack on this one, and it should probably get merged early on because of the other subsystems that are not tracking their dependencies ;-)

Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/gpu/drm/drm_pci.c:485:2: error: implicit declaration of function 'pcie_capability_read_dword' [-Werror=implicit-function-declaration]

Should be fixed in today's -next.

Quoted 8 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:21:5: error: redefinition of 'st_sensors_allocate_trigger' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/common/st_sensors/st_sensors_trigger.c:65:6: error: redefinition of 'st_sensors_deallocate_trigger' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c:176:3: error: implicit declaration of function 'iio_push_to_buffers' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:106:36: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:109:21: error: variable 'inv_mpu_trigger_ops' has initializer but incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:110:2: error: unknown field 'owner' specified in initializer /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:111:2: error: unknown field 'set_trigger_state' specified in initializer /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:119:2: error: implicit declaration of function 'iio_trigger_alloc' [-Werror=implicit-function-declaration]

Quoted 8 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:126:38: error: 'iio_trigger_generic_data_rdy_poll' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:132:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:133:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:134:10: error: dereferencing pointer to incomplete type /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:135:2: error: implicit declaration of function 'iio_trigger_register' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:145:2: error: implicit declaration of function 'iio_trigger_free' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c:152:2: error: implicit declaration of function 'iio_trigger_unregister' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/iio/industrialio-triggered-buffer.c:20:16: error: 'iio_sw_buffer_preenable' undeclared here (not in a function)

I have not seen any of these so far.

Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/media/platform/davinci/vpss.c:28:27: fatal error: mach/hardware.h: No such file or directory

patch sent, waiting for Mauro

Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/remoteproc/omap_remoteproc.c:31:26: fatal error: plat/mailbox.h: No such file or directory

Fixed in arm-soc today

Quoted 4 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2712:47: error: 'CONFIG_SERIAL_8250_NR_UARTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:2971:20: error: negative width in bit-field '<anonymous>' /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/8250/8250.c:57:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/tty/serial/omap-serial.c:1185:14: error: 'struct uart_port' has no member named 'sysrq'

Haven't seen these ones.

Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/usb/host/uhci-hcd.c:857:2: error: #error "missing bus glue for uhci-hcd"

I have a plan to fix this, but not patch.

Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function)

This is already broken in v3.8-rc7 and earlier, I hope the fix makes it into 3.8.

Quoted 2 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34: error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function) /var/lib/jenkins/jobs/linux-randconfig/workspace/security/integrity/ima/ima_policy.c:538:4: error: implicit declaration of function 'part_pack_uuid' [-Werror=implicit-function-declaration]

I have not seen these two.

Thanks for the report.

Arnd

#5 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

/var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34:

Quoted 1 line

error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function)

This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS).
I'll queue a patch to fix the breakage...

        M.
Signature · 1 line
Fast, cheap, reliable. Pick two.
#6 lore raw
Quoted 9 lines · Marc Zyngier
Quoted 6 lines · Rob Herring

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

/var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34:

Quoted 5 lines
Quoted 1 line

error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function)

This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS).
I'll queue a patch to fix the breakage...

Looks like there's a few more, and what was brewing in kvm-next had some side effects.

Christoffer, I'll send the patches separately.

        M.
Signature · 1 line
Fast, cheap, reliable. Pick two.
#7 lore raw
Quoted 14 lines · Marc Zyngier
Quoted 9 lines · Marc Zyngier
Quoted 6 lines · Rob Herring

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

/var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34:

Quoted 2 lines
Quoted 1 line

error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function)

Quoted 9 lines
Quoted 3 lines

This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS).
I'll queue a patch to fix the breakage...

Looks like there's a few more, and what was brewing in kvm-next had some side effects.

Christoffer, I'll send the patches separately.

I was kind of hoping that the KVM guys would have pulled the KVM/ARM stuff into kvm/next and it could have been fixed up there.... The patches are really trivial though iirc.

#8 lore raw
Quoted 19 lines · Christoffer Dall
Quoted 18 lines · Marc Zyngier
Quoted 9 lines · Marc Zyngier
Quoted 6 lines · Rob Herring

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

/var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34:

Quoted 5 lines
Quoted 1 line

error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function)

This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS).
I'll queue a patch to fix the breakage...

Quoted 8 lines
Quoted 5 lines

Looks like there's a few more, and what was brewing in kvm-next had some side effects.

Christoffer, I'll send the patches separately.

I was kind of hoping that the KVM guys would have pulled the KVM/ARM stuff into kvm/next and it could have been fixed up there.... The patches are really trivial though iirc.

Indeed they are. Probably an oversight from the KVM guys. Sent them anyway...

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...
#9 lore raw
Quoted 23 lines · Marc Zyngier
Quoted 22 lines · Christoffer Dall
Quoted 21 lines · Marc Zyngier
Quoted 9 lines · Marc Zyngier
Quoted 6 lines · Rob Herring

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

/var/lib/jenkins/jobs/linux-randconfig/workspace/include/linux/kvm_host.h:333:34:

Quoted 5 lines
Quoted 1 line

error: 'KVM_USER_MEM_SLOTS' undeclared here (not in a function)

This one comes from bbacc0c (KVM: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS).
I'll queue a patch to fix the breakage...

Looks like there's a few more, and what was brewing in kvm-next had some side effects.

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

Christoffer, I'll send the patches separately.

I was kind of hoping that the KVM guys would have pulled the KVM/ARM stuff into kvm/next and it could have been fixed up there.... The patches are really trivial though iirc.

Indeed they are. Probably an oversight from the KVM guys. Sent them anyway...

I saw them, it all looks good.

I'm cc'ing the kvm list here just for info.

-Christoffer

#11 lore raw
In reply to a message not in the archive
Quoted 23 lines · Arnd Bergmann
Quoted 3 lines · Rob Herring

Errors from randconfig builds restricted to multi-platform configs on the current linux-next. I know I've seen a fix on the first one from Arnd, but have not investigated any of these.

I have seen some of these before with the allyesconfig builds. Investigating randconfig is on my list for next week.

Quoted 8 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/kernel/arch_timer.c:55:11: error: 'ENXIO' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:118:19: error: redefinition of 'soc_is_omap' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:184:1: error: redefinition of 'is_omap24xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:185:1: error: redefinition of 'is_omap34xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:186:1: error: redefinition of 'is_omap44xx' /var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-omap2/soc.h:187:1: error: redefinition of 'is_am35xx'

Patch is queued in arm-soc now.

Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function)

I've seen this one with allyesconfig but have not tried to make a fix

Quoted 8 lines
Quoted 2 lines

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-aes.c:363:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration] /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/crypto/omap-sham.c:1707:2: error: implicit declaration of function 'dma_request_slave_channel_compat' [-Werror=implicit-function-declaration]

These are waiting for a patch from Matt Porter, "[PATCH v7 07/10] dmaengine: add dma_request_slave_channel_compat()". Matt, what is your plan for this? I assume it's too late to get the entire series into 3.9, but you have Vinod's Ack on this one, and it should probably get merged early on because of the other subsystems that are not tracking their dependencies ;-)

Yeah, probably too late for the dmaengine edma series. I need to update to fix the first patch bisect issues and the DT portions lack an ack from Rob or Grant.

I'd be happy to see at least the compat() patch be picked up. Chris had to drop the omap_hsmmc dt dmaengine patches until that one is merged. I'm not sure whose tree that one should go through at this point...perhaps via Chris' tree now?

-Matt

#2 lore raw
In reply to Arnd Bergmann

Quoting Arnd Bergmann (2013-02-15 10:00:36)

Quoted 4 lines · Rob Herring
Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function)

I've seen this one with allyesconfig but have not tried to make a fix

Looks like this one was introduced by 7248001, "clk: vt8500: Fix device clock divisor calculations".

Looks like a copy/paste error where prate was used instead of parent_rate.

Tony can you test the below patch?

Regards,
Mike

Quoted 1 line

From efb8dbe114579b4f459b3810e83d79b11593436a Mon Sep 17 00:00:00 2001

From: Mike Turquette <[email protected]>
Date: Fri, 15 Feb 2013 12:03:51 -0800
Subject: [PATCH] clk: vt8500: copy-paste mistake in dclk_set_rate

Commit 7248001, "clk: vt8500: Fix device clock divisor calculations" introduced logic to improve divider selection while changing rates for the VT8500 dclk. However a copy-paste error results in using the wrong variable name in the .set_rate callback. Fixed by changing *prate to parent_rate. The .round_rate function is correct and remains unchanged.

Cc Tony Prisk <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Rob Herring <[email protected]>
---
 drivers/clk/clk-vt8500.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk-vt8500.c +2 -2
index b5538bb..c010861 100644
@@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 
 	divisor =  parent_rate / rate;
 
-	/* If prate / rate would be decimal, incr the divisor */
-	if (rate * divisor < *prate)
+	/* If parent_rate / rate would be decimal, incr the divisor */
+	if (rate * divisor < parent_rate)
 		divisor++;
 
 	if (divisor == cdev->div_mask + 1)
Signature · 1 line
1.7.10.4
#12 lore raw
In reply to Matt Porter
Quoted 4 lines · Matt Porter

I'd be happy to see at least the compat() patch be picked up. Chris had to drop the omap_hsmmc dt dmaengine patches until that one is merged. I'm not sure whose tree that one should go through at this point...perhaps via Chris' tree now?

It really should have been in the crypto tree before Mark's patches to use them, but if Chris is still considering the the hsmmc dt patches for 3.9, including them there is probably the best way forward.

I would expect him to say no them at this point though, and in that case, I think it should be either the slave-dma tree or the arm-soc tree.

Arnd

#13 lore raw

Hi,

Quoted 3 lines · Arnd Bergmann

I would expect him to say no them at this point though, and in that case, I think it should be either the slave-dma tree or the arm-soc tree.

Agreed, these should go in someone else's tree, thanks.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
#3 lore raw
In reply to Mike Turquette
Quoted 40 lines · Mike Turquette

Quoting Arnd Bergmann (2013-02-15 10:00:36)

Quoted 3 lines · Rob Herring
Quoted 1 line

/var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function)

I've seen this one with allyesconfig but have not tried to make a fix

Looks like this one was introduced by 7248001, "clk: vt8500: Fix device clock divisor calculations".

Looks like a copy/paste error where prate was used instead of parent_rate.

Tony can you test the below patch?

Regards,
Mike

Quoted 1 line

From efb8dbe114579b4f459b3810e83d79b11593436a Mon Sep 17 00:00:00 2001

From: Mike Turquette <[email protected]>
Date: Fri, 15 Feb 2013 12:03:51 -0800
Subject: [PATCH] clk: vt8500: copy-paste mistake in dclk_set_rate

Commit 7248001, "clk: vt8500: Fix device clock divisor calculations" introduced logic to improve divider selection while changing rates for the VT8500 dclk. However a copy-paste error results in using the wrong variable name in the .set_rate callback. Fixed by changing *prate to parent_rate. The .round_rate function is correct and remains unchanged.

Cc Tony Prisk <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Rob Herring <[email protected]>
---
  drivers/clk/clk-vt8500.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk-vt8500.c +0 -0
index b5538bb..c010861 100644

drivers/clk/clk-vt8500.c static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, · line 163

Quoted 10 lines
drivers/clk/clk-vt8500.c +2 -2
@@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 
  	divisor =  parent_rate / rate;
 
-	/* If prate / rate would be decimal, incr the divisor */
-	if (rate * divisor < *prate)
+	/* If parent_rate / rate would be decimal, incr the divisor */
+	if (rate * divisor < parent_rate)
  		divisor++;
 
  	if (divisor == cdev->div_mask + 1)

What about just

         divisor = (parent_rate + rate - 1) / rate;
#14 lore raw
In reply to Arnd Bergmann
Quoted 6 lines · Arnd Bergmann
Quoted 4 lines · Matt Porter

I'd be happy to see at least the compat() patch be picked up. Chris had to drop the omap_hsmmc dt dmaengine patches until that one is merged. I'm not sure whose tree that one should go through at this point...perhaps via Chris' tree now?

Quoted 7 lines

It really should have been in the crypto tree before Mark's patches to use them, but if Chris is still considering the the hsmmc dt patches for 3.9, including them there is probably the best way forward.

I would expect him to say no them at this point though, and in that case, I think it should be either the slave-dma tree or the arm-soc tree.

Do you want me to add the compat() patch? I had acked it sometime back

I was hoping to send the PULL request in a day or two... Pls let me know...

--
~Vinod

#15 lore raw
Quoted 10 lines · Vinod Koul
Quoted 7 lines

It really should have been in the crypto tree before Mark's patches to use them, but if Chris is still considering the the hsmmc dt patches for 3.9, including them there is probably the best way forward.

I would expect him to say no them at this point though, and in that case, I think it should be either the slave-dma tree or the arm-soc tree.

Do you want me to add the compat() patch? I had acked it sometime back

I was hoping to send the PULL request in a day or two... Pls let me know...

The patch is clearly needed in 3.9, so one of us should add it. It feels more appropriate for you to do it since it only touches the dma-slave header files. If you don't want to add more late patches to your branch, I can also put it into the arm-soc fixes queue, you decide.

Arnd

#16 lore raw
In reply to Rob Herring
Quoted 1 line · Rob Herring

/var/lib/jenkins/jobs/linux-randconfig/workspace/arch/arm/mach-imx/mach-imx6q.c:248:2: error: implicit declaration of function 'of_init_opp_table' [-Werror=implicit-function-declaration]

Thanks, Rob. I will get it fixed.

Shawn

#4 lore raw
In reply to Troy Kisky
Quoted 28 lines · Troy Kisky
Quoted 28 lines

Commit 7248001, "clk: vt8500: Fix device clock divisor calculations" introduced logic to improve divider selection while changing rates for the VT8500 dclk. However a copy-paste error results in using the wrong variable name in the .set_rate callback. Fixed by changing *prate to parent_rate. The .round_rate function is correct and remains unchanged.

Cc Tony Prisk <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Rob Herring <[email protected]>
---
  drivers/clk/clk-vt8500.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk-vt8500.c +2 -2
index b5538bb..c010861 100644
@@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 
      divisor =  parent_rate / rate;
 
-     /* If prate / rate would be decimal, incr the divisor */
-     if (rate * divisor < *prate)
+     /* If parent_rate / rate would be decimal, incr the divisor */
+     if (rate * divisor < parent_rate)
              divisor++;
 
Quoted 5 lines

drivers/clk/clk-vt8500.c static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, · line 163

Quoted 1 line
drivers/clk/clk-vt8500.c +0 -0
      if (divisor == cdev->div_mask + 1)

What about just

         divisor = (parent_rate + rate - 1) / rate;

This is now broken in Linus' upstream tree. Could you get one fix merged?

Arnd