xfs: simplify xfs_ail_max() via list_last_entry_or_null()

PATCH In review Jeff Liu 1 participant 1 message Nov 15, 2013

Subsystems (2)

Memory technology devices (MTD) XFS filesystem

lore

Share & tools

lore

Jeff Liu

author

2013-11-15 04:31 UTC #0 lore raw

PATCH 2/6 xfs: simplify xfs_ail_max() via list_last_entry_or_null()

From: Jie Liu <[email protected]>

Simplify xfs_ail_max() with list_last_entry_or_null(), and move it to xfs_trans_priv.h as an inline function as now it is one line.

Signed-off-by Jie Liu <[email protected]>

---
 fs/xfs/xfs_trans_ail.c  | 14 --------------
 fs/xfs/xfs_trans_priv.h | 12 ++++++++++++
 2 files changed, 12 insertions(+), 14 deletions(-)

fs/xfs/xfs_trans_ail.c +0 ~~-14~~

index a728735..af605d0 100644
@@ -62,20 +62,6 @@ xfs_ail_check(
 #endif /* DEBUG */
 
 /*
- * Return a pointer to the last item in the AIL.  If the AIL is empty, then
- * return NULL.
- */
-static xfs_log_item_t *
-xfs_ail_max(
-	struct xfs_ail  *ailp)
-{
-	if (list_empty(&ailp->xa_ail))
-		return NULL;
-
-	return list_entry(ailp->xa_ail.prev, xfs_log_item_t, li_ail);
-}
-
-/*
  * Return a pointer to the item which follows the given item in the AIL.  If
  * the given item is the last item in the list, then return NULL.
  */

fs/xfs/xfs_trans_priv.h +12 -0

index 12e86af..b1d93ae 100644
@@ -97,6 +97,18 @@ xfs_ail_min(
 					li_ail);
 }
 
+/*
+ * Return a pointer to the last item in the AIL.  If the AIL is empty, then
+ * return NULL.
+ */
+static inline struct xfs_log_item *
+xfs_ail_max(
+	struct xfs_ail  *ailp)
+{
+	return list_last_entry_or_null(&ailp->xa_ail, struct xfs_log_item,
+				       li_ail);
+}
+
 static inline void
 xfs_trans_ail_update(
 	struct xfs_ail		*ailp,

Signature · 1 line

1.8.3.2