xfs: Introduce a common helper to calculate the number of blocks per cluster
v2 cover xfs: Introduce a common helper to calculate the number of blocks per cluster
Hi Folks,
Here is the v2 patch series to introduce a common helper which could be used to calculate the number of file system blocks in an inode cluster.
v2->v1:
* Rename xfs_ialloc_blks_per_cluster() to xfs_icluster_size_fsb() as per dave's suggestion.
* Remove three macros XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS separately as preparation steps.
* s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
* Remove wrong commit notes I previously written for using xfs_ialloc_blks_per_cluster in xfs_imap().
Thanks,
-Jeff
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Jeff Liu
Hi Folks,
Here is the v2 patch series to introduce a common helper which could be used to calculate the number of file system blocks in an inode cluster.
Quoted 8 lines
v2->v1:
* Renamexfs_ialloc_blks_per_cluster()toxfs_icluster_size_fsb()as per dave's suggestion.
* Remove three macros XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS separately as preparation steps.
* s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
* Remove wrong commit notes I previously written for usingxfs_ialloc_blks_per_clusterinxfs_imap().
All looks good, Jeff. Nice work, and thanks for adding all the extra cleanups to it :)
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
The whole series looks good to me, although I've just posted two very minor nitpicks.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs