Skip to contentSkip to conversation

xfs: Introduce a common helper to calculate the number of blocks per cluster

PATCH In review Jeff Liu 3 participants 3 messages Dec 12, 2013 – Dec 13, 2013

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

v2 cover xfs: Introduce a common helper to calculate the number of blocks per cluster

Hi Folks,

Here is the v2 patch series to introduce a common helper which could be used to calculate the number of file system blocks in an inode cluster.

v2->v1:
* Rename xfs_ialloc_blks_per_cluster() to xfs_icluster_size_fsb() as per dave's suggestion.
* Remove three macros XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS separately as preparation steps.
* s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
* Remove wrong commit notes I previously written for using xfs_ialloc_blks_per_cluster in xfs_imap().

Thanks,
-Jeff

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 5 lines · Jeff Liu

Hi Folks,

Here is the v2 patch series to introduce a common helper which could be used to calculate the number of file system blocks in an inode cluster.

Quoted 8 lines

v2->v1:
* Rename xfs_ialloc_blks_per_cluster() to xfs_icluster_size_fsb() as per dave's suggestion.
* Remove three macros XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS separately as preparation steps.
* s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
* Remove wrong commit notes I previously written for using xfs_ialloc_blks_per_cluster in xfs_imap().

All looks good, Jeff. Nice work, and thanks for adding all the extra cleanups to it :)

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs