Skip to contentSkip to conversation

net: enic: slight optimization of addr compare

PATCH Superseded Ding Tianhong 1 participant 1 message Dec 28, 2013

Subsystems (3)
Networking Network drivers Cisco VIC Ethernet NIC driver

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Ding Tianhong

author
#0 lore raw

PATCH v2 4/20 net: enic: slight optimization of addr compare

Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc Christian Benvenuti <[email protected]>
Cc Sujith Sankar <[email protected]>
Cc Govindarajulu Varadarajan <[email protected]>
Cc Neel Patel <[email protected]>
Cc Nishank Trivedi <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
---
 drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/cisco/enic/enic_pp.c +1 -1
index 43464f0..e6a8319 100644
@@ -162,7 +162,7 @@ static int enic_are_pp_different(struct enic_port_profile *pp1,
 	return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
 		pp2->instance_uuid, PORT_UUID_MAX) |
 		!!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
-		!!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
+		!ether_addr_equal(pp1->mac_addr, pp2->mac_addr);
 }
 
 static int enic_pp_preassociate(struct enic *enic, int vf,
Signature · 1 line
1.8.0