Skip to contentSkip to conversation

rtlwifi: slight optimization of addr compare

PATCH In review Ding Tianhong 1 participant 1 message Jan 8, 2014

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

Ding Tianhong

author
#0 lore raw

PATCH 18/19 rtlwifi: slight optimization of addr compare

Use possibly more efficient ether_addr_equal_unaligned instead of memcmp.

Cc Larry Finger <[email protected]>
Cc Chaoming Li <[email protected]>
Cc John W. Linville <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Weilong Chen <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
---
 drivers/net/wireless/rtlwifi/cam.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/rtlwifi/cam.c +2 -2
index 0e510f7..0276153 100644
@@ -295,7 +295,7 @@ u8 rtl_cam_get_free_entry(struct ieee80211_hw *hw, u8 *sta_addr)
 	/* Does STA already exist? */
 	for (i = 4; i < TOTAL_CAM_ENTRY; i++) {
 		addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
-		if (memcmp(addr, sta_addr, ETH_ALEN) == 0)
+		if (ether_addr_equal_unaligned(addr, sta_addr))
 			return i;
 	}
 	/* Get a free CAM entry. */

@@ -335,7 +335,7 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
 		addr = rtlpriv->sec.hwsec_cam_sta_addr[i];
 		bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i;
 		if (((bitmap & BIT(0)) == BIT(0)) &&
-		    (memcmp(addr, sta_addr, ETH_ALEN) == 0)) {
+		    (ether_addr_equal_unaligned(addr, sta_addr))) {
 			/* Remove from HW Security CAM */
 			eth_zero_addr(rtlpriv->sec.hwsec_cam_sta_addr[i]);
 			rtlpriv->sec.hwsec_cam_bitmap &= ~(BIT(0) << i);
Signature · 1 line
1.8.0