Skip to contentSkip to conversation

bonding: Fix some issues for fail_over_mac

PATCH Superseded Ding Tianhong 2 participants 3 messages Jan 24, 2014 – Jan 25, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover bonding: Fix some issues for fail_over_mac

The parameter fail_over_mac only affect active-backup mode, if it was set to active or follow and works with other modes, just like RR or XOR mode, the bonding could not set all slaves to the master's address, it will cause the slave could not work well with master.

So set the fail_over_mac to none if the mode is not active-backup and slight optimization for bond_set_mac_address().

v1->v2: According Jay's suggestion, that we should permit setting an option
at any time, but only have it take effect in active-backup mode, so I add mode checking together with fail_over_mac during enslavement and rebuild the patches.

v2->v3: The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing to check the mode in addition to fail_over_mac when setting a slave's MAC during enslavement. The change active slave processing already only calls the fail_over_mac function when in active-backup mode.

Remove the cleanup patch because the net-next is frozen now.

Regards
Ding

Ding Tianhong (2):
bonding: bonding: fail_over_mac should only affect AB mode at
enslave and removal processing
bonding: fail_over_mac should only affect AB mode in
bond_set_mac_address()

 drivers/net/bonding/bond_main.c | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.0
maintainer
#1 lore raw

From: Ding Tianhong <[email protected]>
Date: Fri, 24 Jan 2014 12:27:28 +0800

Quoted 2 lines

So set the fail_over_mac to none if the mode is not active-backup and slight optimization for bond_set_mac_address().

This is no longer how your series fixes the problem, please fix this text and resubmit.

#2 lore raw
Quoted 10 lines · David Miller

From: Ding Tianhong <[email protected]>
Date: Fri, 24 Jan 2014 12:27:28 +0800

Quoted 2 lines

So set the fail_over_mac to none if the mode is not active-backup and slight optimization for bond_set_mac_address().

This is no longer how your series fixes the problem, please fix this text and resubmit.

OK, sorry for that.