bonding: fail_over_mac should only affect AB mode in bond_set_mac_address()
Subsystems (3)
PATCH v3 2/2 bonding: fail_over_mac should only affect AB mode in bond_set_mac_address()
The fail_over_mac could be set to active or follow in any time for every mode, so if the fail_over_mac is not none when the mode is not in active-backup, the bond_set_moc_address() could not change the master and slave's MAC address.
In bond_set_mac_address(), the fail_over_mac should only affect AB mode, so modify to check the mode in addition to fail_over_mac when setting bond's MAC address.
Cc Jay Vosburgh <[email protected]>
Cc Veaceslav Falico <[email protected]>
Cc Andy Gospodarek <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
--- drivers/net/bonding/bond_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +2 -1
@@ -3423,7 +3423,8 @@ static int bond_set_mac_address(struct net_device *bond_dev, void *addr)/* If fail_over_mac is enabled, do nothing and return success. * Returning an error causes ifenslave to fail. */ -if (bond->params.fail_over_mac) +if (bond->params.fail_over_mac && + bond->params.mode ==BOND_MODE_ACTIVEBACKUP )return 0 ;if (!is_valid_ether_addr (sa->sa_data))
Signature · 1 line
1.8.0