ARM: dts: add cm36651 light/proximity sensor node
Subsystems (2)
PATCH v2 2/3 ARM: dts: add cm36651 light/proximity sensor node
Exynos4412-trats2 board have light/proximity sensor. This patch add cm36651 light/ proximity sensor node for exynos4412. cm36651 is required properties as below.
- Use i2c-gpio for cm36651 sensor.
- Use fixed regulator for the IR LED.
It is a part of the cm36651 for proximity detection.
- cm36651 is i2c device driver so need to use i2c-gpio driver.
---
Changes in v2:
- Compatible is changed according to device tree binding document and driver.
--- arch/arm/boot/dts/exynos4412-trats2.dts | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
arch/arm/boot/dts/exynos4412-trats2.dts +26 -0
@@ -21,6 +21,7 @@ aliases { i2c8 = &i2c_ak8975; + i2c9 = &i2c_cm36651; }; memory {
@@ -71,6 +72,14 @@ enable-active-high; }; + ps_als_reg: voltage-regulator-2 { + compatible = "regulator-fixed"; + regulator-name = "LED_A_3.0V"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + gpio = <&gpj0 5 0>; + enable-active-high; + }; /* More to come */ };
@@ -500,6 +509,23 @@ }; }; + i2c_cm36651: i2c-gpio-2 { + compatible = "i2c-gpio"; + gpios = <&gpf0 0 0>, <&gpf0 1 0>; + i2c-gpio,delay-us = <2>; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + cm36651@18 { + compatible = "capella,cm36651"; + reg = <0x18>; + interrupt-parent = <&gpx0>; + interrupts = <2 0>; + vled-supply = <&ps_als_reg>; + }; + }; + spi_1: spi@13930000 { pinctrl-names = "default"; pinctrl-0 = <&spi1_bus>;
Signature · 1 line
1.7.9.5
Hi Beomho,
Quoted 45 lines · Beomho Seo
Exynos4412-trats2 board have light/proximity sensor. This patch add cm36651 light/ proximity sensor node for exynos4412. cm36651 is required properties as below.
- Use i2c-gpio for cm36651 sensor.
- Use fixed regulator for the IR LED.
It is a part of the cm36651 for proximity detection.
- cm36651 is i2c device driver so need to use i2c-gpio driver.Signed-off-by Beomho Seo <[email protected]>Signed-off-by MyungJoo Ham <[email protected]>---
Changes in v2:
- Compatible is changed according to device tree binding document and driver.--- arch/arm/boot/dts/exynos4412-trats2.dts | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)arch/arm/boot/dts/exynos4412-trats2.dts +9
-0@@ -21,6 +21,7 @@ aliases { i2c8 = &i2c_ak8975; + i2c9 = &i2c_cm36651; }; memory {@@ -71,6 +72,14 @@ enable-active-high; }; + ps_als_reg: voltage-regulator-2 { + compatible = "regulator-fixed"; + regulator-name = "LED_A_3.0V"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + gpio = <&gpj0 5 0>; + enable-active-high; + }; /* More to come */ };
arch/arm/boot/dts/exynos4412-trats2.dts line 517
Quoted 9 lines
arch/arm/boot/dts/exynos4412-trats2.dts +6
-0@@ -500,6 +509,23 @@ }; }; + i2c_cm36651: i2c-gpio-2 { + compatible = "i2c-gpio"; + gpios = <&gpf0 0 0>, <&gpf0 1 0>; + i2c-gpio,delay-us = <2>; + #address-cells = <1>; + #size-cells = <0>;
Shouldn't you also have pinctrl settings for both pins specified here, at least to disable pull-down that is active by default after SoC reset?
arch/arm/boot/dts/exynos4412-trats2.dts line 524
Quoted 7 lines
arch/arm/boot/dts/exynos4412-trats2.dts +7
-0+ status = "okay"; + + cm36651@18 { + compatible = "capella,cm36651"; + reg = <0x18>; + interrupt-parent = <&gpx0>; + interrupts = <2 0>;
Same here. What kind of signal driver does the interrupt pin of CM36651 chip have? The most common are normal and open-drain drivers, so I suspect that the default pull-down on the pin is not correct.
Also I'd say that you should specify some kind of default trigger here, instead of simply using 0 as the second cell in interrupt specifier. How does the CM36651 chip trigger an interrupt (level or edge, which polarity)?
Best regards,
Tomasz