Skip to contentSkip to conversation

Board Porting MACH_TYPE question

U-Boot Robert Mortimer 2 participants 2 messages Dec 20, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 538775639.248.1292839367761.JavaMail.root@mailserver.xen.bluechiptechnology.co.uk

#1 lore raw

Hi,

I am porting a board similar to the Beagle to U-Boot. The Beagle config works but needs further pin MUXing . I have copied the Beagle board config to a new name and when compiled the binary performs as per the Beale one. My issue is when I change the line

51: gd->bd->bi_arch_number = MACH_TYPE_OMAP3_BEAGLE;

in the copy of beagle.h (now re2v2.h) to

51: gd->bd->bi_arch_number = MACH_TYPE_OMAP3_RE2V2;

The loader now unpacks the loaded kernel and then halts at the stage where it tries to boot it

I have updated arch/arm/include/ asm /mach-types.h and include/ asm /mach-types.h. If I grep for the relevant changes/ additions I get the following:-

grep -r machine_is_omap3_beagle *
arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_beagle() (machine_arch_type == MACH_TYPE_OMAP3_BEAGLE) arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_beagle() (0)
include/ asm /mach-types.h:# define machine_is_omap3_beagle() (machine_arch_type == MACH_TYPE_OMAP3_BEAGLE) include/ asm /mach-types.h:# define machine_is_omap3_beagle() (0)

grep -r machine_is_omap3_re2v2 *
arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (machine_arch_type == MACH_TYPE_OMAP3_RE2V2) arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (0)
include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (machine_arch_type == MACH_TYPE_OMAP3_RE2V2) include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (0)

grep -r machine_is_omap3_beagle *
arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_beagle() (machine_arch_type == MACH_TYPE_OMAP3_BEAGLE) arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_beagle() (0)
include/ asm /mach-types.h:# define machine_is_omap3_beagle() (machine_arch_type == MACH_TYPE_OMAP3_BEAGLE) include/ asm /mach-types.h:# define machine_is_omap3_beagle() (0)

grep -r machine_is_omap3_re2v2 *
arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (machine_arch_type == MACH_TYPE_OMAP3_RE2V2) arch/arm/include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (0)
include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (machine_arch_type == MACH_TYPE_OMAP3_RE2V2) include/ asm /mach-types.h:# define machine_is_omap3_re2v2() (0)

I have defined MACH_TYPE_OMAP3_RE2V2 in arch/arm/include/ asm /mach-types.h and given it the next number I can't see where machine_arch_type is used outside of board configuration
I can't see where 1546 (the Beagle number) is used either

Any idea what additional work needs to be done to move to MACH_TYPE_OMAP3_RE2V2 from MACH_TYPE_OMAP3_BEAGLE?

Regards Rob

Blue Chip Technology Limited. Chowley Oak Lane, Tattenhall, Chester, Cheshire CH3 9EX Tel: 01829 772000 Registered in England 3110403 Vat No: GB 618 374134

#2 lore raw

Dear Robert Mortimer,

Quoted 3 lines · In message <1259520402.588.1292850598306.JavaMail.root@mailserver.xen.bluechipt…

I am porting a board similar to the Beagle to U-Boot. The Beagle config works but needs further pin MUXing . I have copied the Beagle board config to a new name and when compiled the binary performs as per the Beale one. My issue is when I change the li ne

Please make sure to use a line lenght of some 70 characters or less.

Quoted 3 lines

51: gd->bd->bi_arch_number = MACH_TYPE_OMAP3_BEAGLE;

in the copy of beagle.h (now re2v2.h) to

You are not supposed to mess with exsiting boards. Please create your own board config instead.

Quoted 1 line

51: gd->bd->bi_arch_number = MACH_TYPE_OMAP3_RE2V2;

Is this an officially registered machine type? I can't find it.

Quoted 3 lines

The loader now unpacks the loaded kernel and then halts at the stage where it tries to boot it

I have updated arch/arm/include/ asm /mach-types.h and include/ asm /mach-types.h.

You are not supposed to do that. Please register your board at the ARM machine registry, and when the ID has become available in the Linux tree, then submit an update request for mach-types.h here.

Quoted 1 line

Any idea what additional work needs to be done to move to MACH_TYPE_OMAP3_RE2V2 from MACH_TYPE_OMAP3_BEAGLE?

Please register your board.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A verbal contract isn't worth the paper it's printed on."
- Samuel Goldwyn