Skip to contentSkip to conversation

ARM: shmobile: r8a7790/lager dts: Add DVFS parameters into cpu0 node for r8a7790

PATCH In review Gaku Inami 2 participants 2 messages Jun 3, 2014 – Jun 4, 2014

Subsystems (2)
lore
Share & tools
lore

Gaku Inami

author
#0 lore raw

PATCH v2 2/8 ARM: shmobile: r8a7790/lager dts: Add DVFS parameters into cpu0 node for r8a7790

From: Benoit Cousson <[email protected]>

Add needed information inside CPU0 for the generic cpufreq-cpu0 driver.

- voltage-tolerance = 1%
It reflects the tolerance for the CPU voltage defined inside the OPP table. Due to the lack of proper OPP definition, use an arbitrary safe value.
- clock-latency = 300 us
Approximate worst-case latency to do a full DVFS transition for every OPPs. Due to the lack of HW information, use an arbitrary safe value.
Note: The term transition-latency will be more accurate to define this value since the clock transition latency is not the only parameter that will define the overall DVFS transition.
- operating-points = < kHz - uV >
List of 6 operating points. All of them are using the same voltage since the valid Vmin voltage is not documented in the HW spec.
- clocks
phandle to the CPU clock source. This clock source is used for all the 4 CortexA15 located inside the same cluster.

[[email protected]: Change the setting of OPPs for ES2.0]

---

Changes since version 1:
- changed "Signed-off-by" and "From" correctly.
- added the setting of VDD.
- changed the setting of OPPs for ES2.0
- fixed subject.

 arch/arm/boot/dts/r8a7790-lager.dts |    4 ++++
 arch/arm/boot/dts/r8a7790.dtsi      |   11 +++++++++++
 2 files changed, 15 insertions(+)
arch/arm/boot/dts/r8a7790-lager.dts +4 -0
index 8428204..b9cbeda 100644
@@ -338,3 +338,7 @@
 		regulator-always-on;
 	};
 };
+
+&cpu0 {
+	cpu0-supply = <&vdd_dvfs>;
+};
arch/arm/boot/dts/r8a7790.dtsi +11 -0
index 7ff2960..30f7104 100644
@@ -44,6 +44,17 @@
 			compatible = "arm,cortex-a15";
 			reg = <0>;
 			clock-frequency = <1300000000>;
+			voltage-tolerance = <1>; /* 1% */
+			clocks = <&cpg_clocks R8A7790_CLK_Z>;
+			clock-latency = <300000>; /* 300 us */
+
+			/* kHz - uV - OPPs unknown yet */
+			operating-points = <1400000 1000000>,
+					   <1225000 1000000>,
+					   <1050000 1000000>,
+					   < 875000 1000000>,
+					   < 700000 1000000>,
+					   < 350000 1000000>;
 		};
 
 		cpu1: cpu@1 {
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 21 lines · Gaku Inami

From: Benoit Cousson <[email protected]>

Add needed information inside CPU0 for the generic cpufreq-cpu0 driver.

- voltage-tolerance = 1%
It reflects the tolerance for the CPU voltage defined inside the OPP table. Due to the lack of proper OPP definition, use an arbitrary safe value.
- clock-latency = 300 us
Approximate worst-case latency to do a full DVFS transition for every OPPs. Due to the lack of HW information, use an arbitrary safe value.
Note: The term transition-latency will be more accurate to define this value since the clock transition latency is not the only parameter that will define the overall DVFS transition.
- operating-points = < kHz - uV >
List of 6 operating points. All of them are using the same voltage since the valid Vmin voltage is not documented in the HW spec.
- clocks
phandle to the CPU clock source. This clock source is used for all the 4 CortexA15 located inside the same cluster.

Quoted 3 lines
[[email protected]: Change the setting of OPPs for ES2.0]

Thanks, I have queued this up with Magnus's ack.

Quoted 49 lines

---

Changes since version 1:
- changed "Signed-off-by" and "From" correctly.
- added the setting of VDD.
- changed the setting of OPPs for ES2.0
- fixed subject.

 arch/arm/boot/dts/r8a7790-lager.dts |    4 ++++
 arch/arm/boot/dts/r8a7790.dtsi      |   11 +++++++++++
 2 files changed, 15 insertions(+)
arch/arm/boot/dts/r8a7790-lager.dts +4 -0
index 8428204..b9cbeda 100644
@@ -338,3 +338,7 @@
 		regulator-always-on;
 	};
 };
+
+&cpu0 {
+	cpu0-supply = <&vdd_dvfs>;
+};
arch/arm/boot/dts/r8a7790.dtsi +11 -0
index 7ff2960..30f7104 100644
@@ -44,6 +44,17 @@
 			compatible = "arm,cortex-a15";
 			reg = <0>;
 			clock-frequency = <1300000000>;
+			voltage-tolerance = <1>; /* 1% */
+			clocks = <&cpg_clocks R8A7790_CLK_Z>;
+			clock-latency = <300000>; /* 300 us */
+
+			/* kHz - uV - OPPs unknown yet */
+			operating-points = <1400000 1000000>,
+					   <1225000 1000000>,
+					   <1050000 1000000>,
+					   < 875000 1000000>,
+					   < 700000 1000000>,
+					   < 350000 1000000>;
 		};
 
 		cpu1: cpu@1 {
Signature · 1 line
1.7.9.5