qemu-img: Remove redundancy "ret = -1"

In this case, 'ret' is already '-1', so need not do it again.

---
 qemu-img.c | 1 -
 1 file changed, 1 deletion(-)

index c98896b..d4518e7 100644
@@ -246,7 +246,6 @@ static int read_password(char *buf, int buf_size)
             if (errno == EAGAIN || errno == EINTR) {
                 continue;
             } else {
-                ret = -1;
                 break;
             }
         } else if (ret == 0) {

1.7.11.7

It's a very minor thing in an error path, maybe compiler even eliminates this statement entirely by its own already.

Not sure it is worth the effort but applied to the -trivial tree anyway, thanks!

/mjt

Yeah, normal compiler with -O2, should eliminate it (maybe -O1 also OK).

For me, '-trivial' means none-urgent, but not mean minor (in fact some of urgent things are minor), Coding-styles and trying to keep source code simple are none-urgent, but not minor.

Normal things:

- None-urgent and none-important things, we need not do -- it is just wasting members' time resources.

- Urgent and none-important things, need process it in time.

- None-urgent and important things, need process it when have time.

Special things:

- For urgent and important things which can be separated:

- need process for its' urgent part in time.

- and then process for its important part when have time.

- For urgent and important things which can not be separated:

- air, water and life are in this case.

- open, share, and attitude like air, water, and life.

- God have already blessed, but we need let them better and better.

Welcome any suggestions, discussions and completions.

Thanks.

Chen Gang

Open, share, and attitude like air, water, and life which God blessed