Skip to contentSkip to conversation

m68k: generic board

RFC Angelo Dureghello 3 participants 7 messages Jan 15, 2015 – Feb 24, 2015

lore
Share & tools
lore
#0 lore raw

Dear all,

i would like to post a patch with the m68k generic board support, tested and working here, but of course not tested for all the other m68k boards except mine.

My coldfire board is the "amcore" board not yet accepted.

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660

I need some suggestions on how to proceed now.

I already modified my board config to work with generic board support.

So my thought is to post 2 separate patches:
1
- add generic board (1/1). Each board maintainer should then test it and report for feedbacks.
2
Re-post a 2/2 patch (v8) of amcore using generic board:
- amcore board (1),
- mcf5307 support (2),

This amcore board is the coldfire base i use here for all the general m68k tests.

With your help commenting on this patch until it is conformant to the last recent coding guidelines could help me and Alison to know what has to be purged / changed, (eventually, if needed) in all other m68k boards code.

What do you think ?

Best regards,
Angelo Dureghello

#1 lore raw
Quoted 28 lines · Angelo Dureghello

Dear all,

i would like to post a patch with the m68k generic board support, tested and working here, but of course not tested for all the other m68k boards except mine.

My coldfire board is the "amcore" board not yet accepted.

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660

I need some suggestions on how to proceed now.

I already modified my board config to work with generic board support.

So my thought is to post 2 separate patches:
1
- add generic board (1/1). Each board maintainer should then test it and report for feedbacks.
2
Re-post a 2/2 patch (v8) of amcore using generic board:
- amcore board (1),
- mcf5307 support (2),

This amcore board is the coldfire base i use here for all the general m68k tests.

Quoted 6 lines

With your help commenting on this patch until it is conformant to the last recent coding guidelines could help me and Alison to know what has to be purged / changed, (eventually, if needed) in all other m68k boards code.

What do you think ?

Lets go with #2 and we'll purge the rest of the boards that you don't want to convert and compile test after -rc1. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150123/a5c94a8f/attachment.pgp>
#2 lore raw

Hi, Tom,

Quoted 33 lines · Angelo Dureghello
Quoted 32 lines

Dear all,

i would like to post a patch with the m68k generic board support, tested and working here, but of course not tested for all the other m68k boards except mine.

My coldfire board is the "amcore" board not yet accepted.

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660

I need some suggestions on how to proceed now.

I already modified my board config to work with generic board support.

So my thought is to post 2 separate patches:
1
- add generic board (1/1). Each board maintainer should then test it and report for feedbacks.
2
Re-post a 2/2 patch (v8) of amcore using generic board:
- amcore board (1),
- mcf5307 support (2),

This amcore board is the coldfire base i use here for all the general m68k tests.

With your help commenting on this patch until it is conformant to the last recent coding guidelines could help me and Alison to know what has to be purged / changed, (eventually, if needed) in all other m68k boards code.

Quoted 5 lines
Quoted 1 line

What do you think ?

Lets go with #2 and we'll purge the rest of the boards that you don't want to convert and compile test after -rc1. Thanks!

[Alison Wang] Do you mean you will purge the rest of the boards if they are not converted and tested?

I have these boards, such as m52277evb, m5253demo, m53017evb, m5329evb, m5373evb, m54418twr, m54451evb, m54455evb, m547xevb and m548xevb. I think I really need some time to convert and test them.

Best Regards,
Alison Wang

#3 lore raw
Quoted 40 lines · Huan Wang

Hi, Tom,

Quoted 33 lines · Angelo Dureghello
Quoted 32 lines

Dear all,

i would like to post a patch with the m68k generic board support, tested and working here, but of course not tested for all the other m68k boards except mine.

My coldfire board is the "amcore" board not yet accepted.

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660

I need some suggestions on how to proceed now.

I already modified my board config to work with generic board support.

So my thought is to post 2 separate patches:
1
- add generic board (1/1). Each board maintainer should then test it and report for feedbacks.
2
Re-post a 2/2 patch (v8) of amcore using generic board:
- amcore board (1),
- mcf5307 support (2),

This amcore board is the coldfire base i use here for all the general m68k tests.

With your help commenting on this patch until it is conformant to the last recent coding guidelines could help me and Alison to know what has to be purged / changed, (eventually, if needed) in all other m68k boards code.

Quoted 5 lines
Quoted 1 line

What do you think ?

Lets go with #2 and we'll purge the rest of the boards that you don't want to convert and compile test after -rc1. Thanks!

Quoted 6 lines

[Alison Wang] Do you mean you will purge the rest of the boards if they are not converted and tested?

I have these boards, such as m52277evb, m5253demo, m53017evb, m5329evb, m5373evb, m54418twr, m54451evb, m54455evb, m547xevb and m548xevb. I think I really need some time to convert and test them.

Please get them converted ASAP and remove the rest of the boards which you do not plan to support. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150206/bb05aa08/attachment.sig>
#4 lore raw
Quoted 44 lines · Tom Rini
Quoted 43 lines · Huan Wang

Hi, Tom,

Quoted 33 lines · Angelo Dureghello
Quoted 32 lines

Dear all,

i would like to post a patch with the m68k generic board support, tested and working here, but of course not tested for all the other m68k boards except mine.

My coldfire board is the "amcore" board not yet accepted.

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660

I need some suggestions on how to proceed now.

I already modified my board config to work with generic board support.

So my thought is to post 2 separate patches:
1
- add generic board (1/1). Each board maintainer should then test it and report for feedbacks.
2
Re-post a 2/2 patch (v8) of amcore using generic board:
- amcore board (1),
- mcf5307 support (2),

This amcore board is the coldfire base i use here for all the general m68k tests.

With your help commenting on this patch until it is conformant to the last recent coding guidelines could help me and Alison to know what has to be purged / changed, (eventually, if needed) in all other m68k boards code.

Quoted 5 lines
Quoted 1 line

What do you think ?

Lets go with #2 and we'll purge the rest of the boards that you don't want to convert and compile test after -rc1. Thanks!

[Alison Wang] Do you mean you will purge the rest of the boards if they are not converted and tested?

Quoted 7 lines
Quoted 3 lines

I have these boards, such as m52277evb, m5253demo, m53017evb, m5329evb, m5373evb, m54418twr, m54451evb, m54455evb, m547xevb and m548xevb. I think I really need some time to convert and test them.

Please get them converted ASAP and remove the rest of the boards which you do not plan to support. Thanks!

Sorry but i had some delays in these days, especially due to a bug in the kernel.org 4.6.3 toolchain for i686:

https://lkml.org/lkml/2015/2/6/654

I am about to send in some days amcore board patch already set up to work with generic board support.

Once the set is accepted, we should be able to convert the other boards, or re-introduce easily the boards.

Best regards,
Angelo Dureghello

#5 lore raw
In reply to Tom Rini
Quoted 44 lines · Tom Rini
Quoted 43 lines · Huan Wang

Hi, Tom,

Quoted 33 lines · Angelo Dureghello
Quoted 32 lines

Dear all,

i would like to post a patch with the m68k generic board support, tested and working here, but of course not tested for all the other m68k boards except mine.

My coldfire board is the "amcore" board not yet accepted.

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660

I need some suggestions on how to proceed now.

I already modified my board config to work with generic board support.

So my thought is to post 2 separate patches:
1
- add generic board (1/1). Each board maintainer should then test it and report for feedbacks.
2
Re-post a 2/2 patch (v8) of amcore using generic board:
- amcore board (1),
- mcf5307 support (2),

This amcore board is the coldfire base i use here for all the general m68k tests.

With your help commenting on this patch until it is conformant to the last recent coding guidelines could help me and Alison to know what has to be purged / changed, (eventually, if needed) in all other m68k boards code.

Quoted 5 lines
Quoted 1 line

What do you think ?

Lets go with #2 and we'll purge the rest of the boards that you don't want to convert and compile test after -rc1. Thanks!

[Alison Wang] Do you mean you will purge the rest of the boards if they are not converted and tested?

Quoted 6 lines
Quoted 3 lines

I have these boards, such as m52277evb, m5253demo, m53017evb, m5329evb, m5373evb, m54418twr, m54451evb, m54455evb, m547xevb and m548xevb. I think I really need some time to convert and test them.

Please get them converted ASAP and remove the rest of the boards which you do not plan to support. Thanks!

Dear Tom and all,

so basically, i posted a patch with with 1 and 2 together, since "amcore" board and m68k generic-board additions was connected.

Alison then added some changes over my generic-board patch.

What is now the correct way to proceed, as m68k custodians ? We need to wait for feedbacks/ack on the patches or, at what stage could we apply this patches into the u-boot-coldfire repo ?

Thanks,

Best regards,
Angelo Dureghello

#6 lore raw
Quoted 56 lines · Angelo Dureghello
Quoted 44 lines · Tom Rini
Quoted 43 lines · Huan Wang

Hi, Tom,

Quoted 33 lines · Angelo Dureghello
Quoted 32 lines

Dear all,

i would like to post a patch with the m68k generic board support, tested and working here, but of course not tested for all the other m68k boards except mine.

My coldfire board is the "amcore" board not yet accepted.

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193661
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/193660

I need some suggestions on how to proceed now.

I already modified my board config to work with generic board support.

So my thought is to post 2 separate patches:
1
- add generic board (1/1). Each board maintainer should then test it and report for feedbacks.
2
Re-post a 2/2 patch (v8) of amcore using generic board:
- amcore board (1),
- mcf5307 support (2),

This amcore board is the coldfire base i use here for all the general m68k tests.

With your help commenting on this patch until it is conformant to the last recent coding guidelines could help me and Alison to know what has to be purged / changed, (eventually, if needed) in all other m68k boards code.

Quoted 5 lines
Quoted 1 line

What do you think ?

Lets go with #2 and we'll purge the rest of the boards that you don't want to convert and compile test after -rc1. Thanks!

[Alison Wang] Do you mean you will purge the rest of the boards if they are not converted and tested?

Quoted 6 lines
Quoted 3 lines

I have these boards, such as m52277evb, m5253demo, m53017evb, m5329evb, m5373evb, m54418twr, m54451evb, m54455evb, m547xevb and m548xevb. I think I really need some time to convert and test them.

Please get them converted ASAP and remove the rest of the boards which you do not plan to support. Thanks!

Dear Tom and all,

Quoted 8 lines

so basically, i posted a patch with with 1 and 2 together, since "amcore" board and m68k generic-board additions was connected.

Alison then added some changes over my generic-board patch.

What is now the correct way to proceed, as m68k custodians ? We need to wait for feedbacks/ack on the patches or, at what stage could we apply this patches into the u-boot-coldfire repo ?

Go ahead and push them to u-boot-coldfire and send me a PR as they've been in public for long enough without further comments, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150224/09804259/attachment.sig>