Skip to contentSkip to conversation

mtip32xx: various fixes

PATCH In review Asai Thambi SP 2 participants 5 messages May 11, 2015 – Jun 16, 2015

lore
Share & tools
lore

Asai Thambi SP

author
#0 lore raw

cover mtip32xx: various fixes

Hi Jens,

This patchset includes few changes to align with recent kernel changes, few fixes and cleanup

Asai Thambi S P (9):
mtip32xx: fix rmmod issue
mtip32xx: remove unused variable 'port->allocated'
mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
mtip32xx: Abort I/O during secure erase operation
mtip32xx: fix crash on surprise removal of the drive
mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
mtip32xx: fix minor number
mtip32xx: abort secure erase operation if the device is mounted
mtip32xx: increase wait time for hba reset

 drivers/block/mtip32xx/mtip32xx.c |  223 ++++++++++++++++---------------------
 drivers/block/mtip32xx/mtip32xx.h |    8 +-
 2 files changed, 98 insertions(+), 133 deletions(-)
#1 lore raw
Quoted 5 lines · Asai Thambi SP

Hi Jens,

This patchset includes few changes to align with recent kernel changes, few fixes and cleanup

Quoted 10 lines

Asai Thambi S P (9):
mtip32xx: fix rmmod issue
mtip32xx: remove unused variable 'port->allocated'
mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
mtip32xx: Abort I/O during secure erase operation
mtip32xx: fix crash on surprise removal of the drive
mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
mtip32xx: fix minor number
mtip32xx: abort secure erase operation if the device is mounted
mtip32xx: increase wait time for hba reset

Have these been through one of your qual cycles? Just wondering if I should attempt to squeeze this into the current series, or wait for 4.2.

Signature · 1 line
Jens Axboe
author
#2 lore raw
Quoted 17 lines · Jens Axboe
Quoted 5 lines · Asai Thambi SP

Hi Jens,

This patchset includes few changes to align with recent kernel changes, few fixes and cleanup

Quoted 10 lines

Asai Thambi S P (9):
mtip32xx: fix rmmod issue
mtip32xx: remove unused variable 'port->allocated'
mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
mtip32xx: Abort I/O during secure erase operation
mtip32xx: fix crash on surprise removal of the drive
mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
mtip32xx: fix minor number
mtip32xx: abort secure erase operation if the device is mounted
mtip32xx: increase wait time for hba reset

Quoted 2 lines

Have these been through one of your qual cycles? Just wondering if I should attempt to squeeze this into the current series, or wait for 4.2.

Yes, we have tested. You can include in the current series.

--
Regards,
Asai

#3 lore raw
Quoted 18 lines · Asai Thambi SP
Quoted 17 lines · Jens Axboe
Quoted 15 lines · Asai Thambi SP

Hi Jens,

This patchset includes few changes to align with recent kernel changes, few fixes and cleanup

Asai Thambi S P (9):
mtip32xx: fix rmmod issue
mtip32xx: remove unused variable 'port->allocated'
mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
mtip32xx: Abort I/O during secure erase operation
mtip32xx: fix crash on surprise removal of the drive
mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
mtip32xx: fix minor number
mtip32xx: abort secure erase operation if the device is mounted
mtip32xx: increase wait time for hba reset

Quoted 3 lines
Quoted 2 lines

Have these been through one of your qual cycles? Just wondering if I should attempt to squeeze this into the current series, or wait for 4.2.

Yes, we have tested. You can include in the current series.

I will apply 1-7, and 9. 8 you promised you'd look into a cleaner solution.

Signature · 1 line
Jens Axboe
author
#4 lore raw
Quoted 19 lines · Jens Axboe
Quoted 18 lines · Asai Thambi SP
Quoted 17 lines · Jens Axboe
Quoted 15 lines · Asai Thambi SP

Hi Jens,

This patchset includes few changes to align with recent kernel changes, few fixes and cleanup

Asai Thambi S P (9):
mtip32xx: fix rmmod issue
mtip32xx: remove unused variable 'port->allocated'
mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
mtip32xx: Abort I/O during secure erase operation
mtip32xx: fix crash on surprise removal of the drive
mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
mtip32xx: fix minor number
mtip32xx: abort secure erase operation if the device is mounted
mtip32xx: increase wait time for hba reset

Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

Have these been through one of your qual cycles? Just wondering if I should attempt to squeeze this into the current series, or wait for 4.2.

Yes, we have tested. You can include in the current series.

I will apply 1-7, and 9. 8 you promised you'd look into a cleaner solution.

Thanks Jens. We made a cleaner solution for 8 and testing it.

--
Regards,
Asai