Skip to contentSkip to conversation

net: dsa: mv88e6060: use the correct InitReady bit

PATCH Superseded Neil Armstrong 2 participants 2 messages Nov 10, 2015

Subsystems (3)
Networking Network drivers Networking DSA

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Neil Armstrong

author
#0 lore raw

PATCH 2/6 net: dsa: mv88e6060: use the correct InitReady bit

According to the mv88e6060 datasheet, the InitReady bit position is 11 and the polarity is inverted.
Use the bit correctly to detect the end of initialization.

Signed-off-by Neil Armstrong <[email protected]>
---
 drivers/net/dsa/mv88e6060.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/mv88e6060.c +1 -1
index 6885ef5..26f668c 100644
@@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds)
 	timeout = jiffies + 1 * HZ;
 	while (time_before(jiffies, timeout)) {
 		ret = REG_READ(REG_GLOBAL, 0x00);
-		if ((ret & 0x8000) == 0x0000)
+		if ((ret & 0x800))
 			break;
 
 		usleep_range(1000, 2000);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 14 lines · Neil Armstrong

According to the mv88e6060 datasheet, the InitReady bit position is 11 and the polarity is inverted.
Use the bit correctly to detect the end of initialization.

Signed-off-by Neil Armstrong <[email protected]>
---
 drivers/net/dsa/mv88e6060.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/mv88e6060.c +0 -0
index 6885ef5..26f668c 100644

drivers/net/dsa/mv88e6060.c static int mv88e6060_switch_reset(struct dsa_switch *ds) · line 106

Quoted 6 lines
drivers/net/dsa/mv88e6060.c +1 -1
@@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds)
 	timeout = jiffies + 1 * HZ;
 	while (time_before(jiffies, timeout)) {
 		ret = REG_READ(REG_GLOBAL, 0x00);
-		if ((ret & 0x8000) == 0x0000)
+		if ((ret & 0x800))
 			break;

You can drop a pair of parenthesis here.

drivers/net/dsa/mv88e6060.c static int mv88e6060_switch_reset(struct dsa_switch *ds) · line 108

Quoted 2 lines
drivers/net/dsa/mv88e6060.c +0 -0
 		usleep_range(1000, 2000);

Thanks,
-v