Skip to contentSkip to conversation

leds-bcm6328: add more init configuration options

DISCUSSION Simon Arlott 3 participants 3 messages Nov 15, 2015 – Nov 16, 2015 LED

lore
Share & tools
lore
#0 lore raw

commit 1d3ff22d633d35048c35c3deeead7ab116cebc32

Author: Álvaro Fernández Rojas <[email protected]>
Date:   Thu Oct 8 12:35:55 2015 +0200

Documentation: leds: update DT bindings for leds-bcm6328

This patch adds latest DT bindings for leds-bcm6328 init register configuration.

commit 9f82c778ce17789a038351a411ff65cd41033c7a

Author: Álvaro Fernández Rojas <[email protected]>
Date:   Thu Oct 8 12:35:54 2015 +0200

leds-bcm6328: add more init configuration options

This patch adds more init register configuration options:
- Serial LEDs multiplexing.
- Serial LEDs clock signal low/high polarity.
- Serial LEDs data signal low/high polarity.
- Serial LEDs shift direction inverted/normal.

This was not a backwards-compatible change, because the driver is now turning off all of the serial LED options by default when previously it only turned off brcm,serial-leds and left the other options unchanged.

There are currently no in-tree users of this binding, so any existing users will be broken by this change.

Signature · 1 line
Simon Arlott
#1 lore raw

Hi Simon,

Quoted 21 lines · Simon Arlott

commit 1d3ff22d633d35048c35c3deeead7ab116cebc32

Author: Álvaro Fernández Rojas <[email protected]>
Date:   Thu Oct 8 12:35:55 2015 +0200

Documentation: leds: update DT bindings for leds-bcm6328

This patch adds latest DT bindings for leds-bcm6328 init register configuration.

commit 9f82c778ce17789a038351a411ff65cd41033c7a

Author: Álvaro Fernández Rojas <[email protected]>
Date:   Thu Oct 8 12:35:54 2015 +0200

leds-bcm6328: add more init configuration options

This patch adds more init register configuration options:
- Serial LEDs multiplexing.
- Serial LEDs clock signal low/high polarity.
- Serial LEDs data signal low/high polarity.
- Serial LEDs shift direction inverted/normal.

Quoted 8 lines

This was not a backwards-compatible change, because the driver is now turning off all of the serial LED options by default when previously it only turned off brcm,serial-leds and left the other options unchanged.

There are currently no in-tree users of this binding, so any existing users will be broken by this change.

Please submit a patch fixing the issue in such cases, so that we could discuss possible solutions to the problem.

Signature · 2 lines
Best Regards,
Jacek Anaszewski
#2 lore raw

Hi Simon and Jacek,

This is done on purpose because not every BCM63268 device has serial LEDs and we should be able to enable/disable those options in order to avoid depending on the bootloader setting the registers correctly.

Regards,
Álvaro.

Quoted 29 lines · Jacek Anaszewski

Hi Simon,

Quoted 26 lines · Simon Arlott

commit 1d3ff22d633d35048c35c3deeead7ab116cebc32

Author: Álvaro Fernández Rojas <[email protected]>
Date:   Thu Oct 8 12:35:55 2015 +0200

Documentation: leds: update DT bindings for leds-bcm6328

This patch adds latest DT bindings for leds-bcm6328 init register configuration.

commit 9f82c778ce17789a038351a411ff65cd41033c7a

Author: Álvaro Fernández Rojas <[email protected]>
Date:   Thu Oct 8 12:35:54 2015 +0200

leds-bcm6328: add more init configuration options

This patch adds more init register configuration options:
- Serial LEDs multiplexing.
- Serial LEDs clock signal low/high polarity.
- Serial LEDs data signal low/high polarity.
- Serial LEDs shift direction inverted/normal.

This was not a backwards-compatible change, because the driver is now turning off all of the serial LED options by default when previously it only turned off brcm,serial-leds and left the other options unchanged.

Quoted 7 lines
Quoted 3 lines

There are currently no in-tree users of this binding, so any existing users will be broken by this change.

Please submit a patch fixing the issue in such cases, so that we could discuss possible solutions to the problem.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html